[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 Amir E. Aharoni amir.ahar...@mail.huji.ac.il changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 --- Comment #45 from kipod fur.hew...@gmail.com --- i think this should be closed. did not see any report about freezing browser since the patch was deployed. did anyone see any more report(s) about browser freezing after the patch was deployed? peace. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 Strainu crangasi2...@yahoo.com changed: What|Removed |Added CC||crangasi2...@yahoo.com --- Comment #37 from Strainu crangasi2...@yahoo.com --- (In reply to comment #36) if the people who reported the freeze can confirm they see high cpu usage during the time the browser is frozen, i think it would mean that you were right, and the two reports are actually duplicates. Either way, the profiling information definitely fits bug 50836 . I can confirm that. High CPU usage is present even without the freeze. On a Quad Core@3GHz, Firefox does not freeze, but one of the cores is 100% busy. On a Dual Core@2.40GHz, Firefox freezes and again, one core is at 100%. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 --- Comment #38 from Bartosz Dziewoński matma@gmail.com --- Just a note that the Language Engineering team responsible for ULS will be holding an office hour later today, at 17:00 UTC on #wikimedia-office (on Freenode): http://www.mail-archive.com/wikitech-l@lists.wikimedia.org/msg69718.html -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 --- Comment #39 from Nemo federicol...@tiscali.it --- (In reply to comment #11) Confirmed on Firefox 21.0, Windows XP SP3, Intel Atom N270, 1 GB RAM. Work for me with that machine on http://en.wikipedia.beta.wmflabs.org/wiki/Barack_Obama after https://gerrit.wikimedia.org/r/72967, no idea about CPU usage (though I watched it). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 --- Comment #40 from Nemo federicol...@tiscali.it --- (In reply to comment #39) (In reply to comment #11) Confirmed on Firefox 21.0, Windows XP SP3, Intel Atom N270, 1 GB RAM. Work for me with that machine on http://en.wikipedia.beta.wmflabs.org/wiki/Barack_Obama after https://gerrit.wikimedia.org/r/72967, no idea about CPU usage (though I watched it). Works as in doesn't freeze; I'm no longer served the font to see the dv interwiki, I don't know if this is expected (chr font is missing for me in both cases). On Linux/AMD E350 I definitely notice the CPU usage decrease too (bug 50836). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 --- Comment #41 from Amir E. Aharoni amir.ahar...@mail.huji.ac.il --- (In reply to comment #40) (In reply to comment #39) (In reply to comment #11) Confirmed on Firefox 21.0, Windows XP SP3, Intel Atom N270, 1 GB RAM. Work for me with that machine on http://en.wikipedia.beta.wmflabs.org/wiki/Barack_Obama after https://gerrit.wikimedia.org/r/72967, no idea about CPU usage (though I watched it). Works as in doesn't freeze; I'm no longer served the font to see the dv interwiki, I don't know if this is expected (chr font is missing for me in both cases). On Linux/AMD E350 I definitely notice the CPU usage decrease too (bug 50836). Nemo, thanks for this comment - it helped us uncover another bug, which we fixed before the deployment. The fixes are deployed now, so the major performance problem should be mostly resolved now. Please test. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 Niklas Laxström niklas.laxst...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|wikibugs-l@lists.wikimedia. |niklas.laxst...@gmail.com |org | --- Comment #43 from Niklas Laxström niklas.laxst...@gmail.com --- Created attachment 12818 -- https://bugzilla.wikimedia.org/attachment.cgi?id=12818action=edit Flame chart profile -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 --- Comment #44 from Niklas Laxström niklas.laxst...@gmail.com --- Created attachment 12819 -- https://bugzilla.wikimedia.org/attachment.cgi?id=12819action=edit Tree profile In your screenshot I don't see anything that hints to ULS webfonts loading. Here are my profiles on Chrome. You can clearly see that webfonts are in the call stack. They still do take time, but less than before the performance fix I deployed few hours ago. The time taken is split between curCSS and appendChild (adding the font-face definitions to CSS). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 --- Comment #26 from kipod fur.hew...@gmail.com --- (In reply to comment #25) kipod, that path of code in the library will never get executed from ULS. If you read the code again, you will see that instead of using jquery.i18n message loading mechanism, which is generic, not written specifically for MW, we have our own message loading and saving mechanism, that always use asynchronous loading. Look for the MWMessageStore definition in the code. Thanks. not sure i understand. this code has your signature/copyright messsage, and appears in the tree under univerals language selector. what is the generic library this was imported from? is it used for anything other than ULS? if it's never executed, why is it there? what's the point of keeping dead code in the tree? is it possible to remove all the dead code from the project? i think this will help volunteers (and non-volunteers) to identify the *real* problems a bit easier. in any event, if this code is never executed, then we can't blame async:false for the lockups, so someone has to figure out the real cause for the lockups many users reported. if you think some other code change maybe solved the problem, it may be worthwhile going back to those people to find out if the problem still exists. peace. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 Bawolff (Brian Wolff) bawolff...@gmail.com changed: What|Removed |Added CC||bawolff...@gmail.com --- Comment #27 from Bawolff (Brian Wolff) bawolff...@gmail.com --- On my browser the line: webfonts.$element.find( '*[lang], [style], [class]' ).each( function( i, element ) of jQuery.webfonts.js (about line 134). seems to be expensive. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 SpeedyGonsales s...@vip.hr changed: What|Removed |Added CC||s...@vip.hr --- Comment #28 from SpeedyGonsales s...@vip.hr --- Firefox 22, Windows 7 Vector, 2 GB Firefox 22, Linux kernel 3.5 branch Monobook, 4 GB http://bits.wikimedia.org/hr.wikipedia.org/load.php?debug=falselang=hrmodules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupportonly=scriptsskin=vectorversion=20130620T163512Z:106 Vector Windows URL of unresponsive script -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 --- Comment #29 from SpeedyGonsales s...@vip.hr --- Firebug profiler reports 9210 calls 20186.226ms in http://bits.wikimedia.org/hr.wikipedia.org/load.php?debug=falselang=hrmodules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupportonly=scriptsskin=monobookversion=20130620T163512Z Total is (22094.644ms, 152876 calls), so above is 91.36 %. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 --- Comment #30 from kipod fur.hew...@gmail.com --- (In reply to comment #29) Firebug profiler reports 9210 calls 20186.226ms in http://bits.wikimedia.org/hr.wikipedia.org/load. php?debug=falselang=hrmodules=jquery%2Cmediawiki%2CSpinner%7Cjquery. triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw. MwEmbedSupportonly=scriptsskin=monobookversion=20130620T163512Z Total is (22094.644ms, 152876 calls), so above is 91.36 %. can you run the same profiling again, but with ?debug=1 added to address line? this will allow to identify the actual file/function much better. peace. (In reply to comment #27) On my browser the line: webfonts.$element.find( '*[lang], [style], [class]' ).each( function( i, element ) of jQuery.webfonts.js (about line 134). seems to be expensive. this seems to be related to bug 50836 (i.e., performance vs. freeze). i think if you'll dig a bit deeper you'll find that the expensive part there is calling getCSS(). this can be easily improved by doing the little optimization i outlined there for the load function. peace. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 --- Comment #31 from Bawolff (Brian Wolff) bawolff...@gmail.com --- this seems to be related to bug 50836 (i.e., performance vs. freeze). i think if you'll dig a bit deeper you'll find that the expensive part there is calling getCSS(). this can be easily improved by doing the little optimization i outlined there for the load function. peace. Depending on the browser, a high cpu spike could equal browser lock up until its done doing what its doing. Are we sure these two bugs aren't the same issue? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935
--- Comment #32 from SpeedyGonsales s...@vip.hr ---
This time 9223 calls, 20145.512ms debug=1 gives:
load.p...163512Z (line 6824)
if ( window.getComputedStyle ) {6822
curCSS = function( elem, name ) { 6823
var ret, width, minWidth, maxWidth, 6824
computed = window.getComputedStyle( elem, null ), 6825
style = elem.style;
---
Seems like recursion on window.getComputedStyle().
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935
--- Comment #33 from Bartosz Dziewoński matma@gmail.com ---
That sounds like something is calling $el.css('property') repeatedly without
caching the result. So it's either yet another performance issue (fourth or
fifth by my count) or an error in the measurement method.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935
--- Comment #34 from Bawolff (Brian Wolff) bawolff...@gmail.com ---
(In reply to comment #33)
That sounds like something is calling $el.css('property') repeatedly without
caching the result. So it's either yet another performance issue (fourth or
fifth by my count) or an error in the measurement method.
I think its the same issue that I was having
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 --- Comment #35 from Helder mybugs.m...@gmail.com --- Created attachment 12808 -- https://bugzilla.wikimedia.org/attachment.cgi?id=12808action=edit Screenshot on Firefox 22.0 (Win XP) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935
--- Comment #36 from kipod fur.hew...@gmail.com ---
(In reply to comment #33)
That sounds like something is calling $el.css('property') repeatedly without
caching the result. So it's either yet another performance issue (fourth or
fifth by my count) or an error in the measurement method.
this actually *is* bug 50836.
there is a little explanation there (getCSS() is called from load, but the
results are not cached, as you and Bartos noted), and an untested patch that
fixes the issue.
if the people who reported the freeze can confirm they see high cpu usage
during the time the browser is frozen, i think it would mean that you were
right, and the two reports are actually duplicates.
Either way, the profiling information definitely fits bug 50836 .
peace.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 MZMcBride b...@mzmcbride.com changed: What|Removed |Added Summary|Browser freezes on loading |Browser freezes on loading |a large page|a large page with ||UniversalLanguageSelector ||(ULS) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 Siebrand s.mazel...@xs4all.nl changed: What|Removed |Added Priority|Normal |High -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 Siebrand s.mazel...@xs4all.nl changed: What|Removed |Added CC||liang...@gmail.com --- Comment #23 from Siebrand s.mazel...@xs4all.nl --- *** Bug 50245 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 --- Comment #24 from kipod fur.hew...@gmail.com --- (In reply to comment #22) Change 71990 merged by jenkins-bot: jquery.i18n message store for ULS https://gerrit.wikimedia.org/r/71990 maybe replying to a bot is plain stupid of me, but let me try: the problem of freezing the browser is plainly and clearly related to calling ajax with async:false. it is also very clear why this type of problem will be intermittent: it depends on the network and the server: if the network and server are both A-OK, the user will hardly notice any problem. however, if the localized messages page does not arrive to the browser promptly, async:false basically *tells* the browser to freeze. since this patch does not remove the async:false, it should not be expected to solve the issue. (as of now, it's line 481 in jquery.i18n.js on head version in git: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FUniversalLanguageSelector/HEAD/lib%2Fjquery.i18n.js ) peace. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49935] Browser freezes on loading a large page with UniversalLanguageSelector (ULS)
https://bugzilla.wikimedia.org/show_bug.cgi?id=49935 --- Comment #25 from Santhosh Thottingal santhosh.thottin...@gmail.com --- kipod, that path of code in the library will never get executed from ULS. If you read the code again, you will see that instead of using jquery.i18n message loading mechanism, which is generic, not written specifically for MW, we have our own message loading and saving mechanism, that always use asynchronous loading. Look for the MWMessageStore definition in the code. Thanks. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
