[Bug 50868] VisualEditor: Escape key (and on Macs additionally ⌘-. ) inside the main editor should cancel VE mode and return to action=view
https://bugzilla.wikimedia.org/show_bug.cgi?id=50868 WhatamIdoing wmf.whatamido...@yahoo.com changed: What|Removed |Added CC||wmf.whatamido...@yahoo.com --- Comment #11 from WhatamIdoing wmf.whatamido...@yahoo.com --- I'm a bit worried about this. What if I'm in a template dialog and accidentally press Esc twice/too long? If this triggered the Do you really wnt to exit? confirmation, it might be okay. However, I suspect that this might not have the ultimate effect that was intended. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50868] VisualEditor: Escape key (and on Macs additionally ⌘-. ) inside the main editor should cancel VE mode and return to action=view
https://bugzilla.wikimedia.org/show_bug.cgi?id=50868 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added CC||roan.katt...@gmail.com --- Comment #12 from Roan Kattouw roan.katt...@gmail.com --- (In reply to WhatamIdoing from comment #11) I'm a bit worried about this. What if I'm in a template dialog and accidentally press Esc twice/too long? If this triggered the Do you really wnt to exit? confirmation, it might be okay. However, I suspect that this might not have the ultimate effect that was intended. Comment 10 asks for the unsaved changes warning to be shown. If we do that, I think it'll be fine. Pressing escape while a dialog is open will dismiss that dialog with a safe action (the cancel/never mind action). So if you press escape again when the unsaved changes warning is visible, that'll dismiss the warning with the safe action, which is never mind, I want to continue editing. So if you press Esc a bunch of times or hold it too long, you'll end up in a loop of the unsaved changes warning appearing and being dismissed. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50868] VisualEditor: Escape key (and on Macs additionally ⌘-. ) inside the main editor should cancel VE mode and return to action=view
https://bugzilla.wikimedia.org/show_bug.cgi?id=50868 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Assignee|rm...@wikimedia.org |jforrester+veteambztickets@ ||wikimedia.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50868] VisualEditor: Escape key (and on Macs additionally ⌘-. ) inside the main editor should cancel VE mode and return to action=view
https://bugzilla.wikimedia.org/show_bug.cgi?id=50868 Chris McKenna cmcke...@sucs.org changed: What|Removed |Added CC||cmcke...@sucs.org --- Comment #10 from Chris McKenna cmcke...@sucs.org --- Yes, pressing escape when in a dialog should close that level of the dialog (if more than one) or the dialog if it's at the top level of the dialog. If a change was confirmed then it should remain when closed, if a change was unconfirmed it should be cancelled. With no dialogs open, escape should exit VE but should ask for confirmation before doing so if there are unsaved changes. That dialog should have keyboard actions such that enter confirms you want to leave and escape indicates that you don't want to leave and take you back to the VE. This will stop people losing work if they hit esc accidentally or too many times. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50868] VisualEditor: Escape key (and on Macs additionally ⌘-. ) inside the main editor should cancel VE mode and return to action=view
https://bugzilla.wikimedia.org/show_bug.cgi?id=50868 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Summary|VisualEditor: Escape key|VisualEditor: Escape key |(and on Macs ⌘-. ) should |(and on Macs additionally |cancel edit mode|⌘-. ) inside the main ||editor should cancel VE ||mode and return to ||action=view --- Comment #9 from James Forrester jforres...@wikimedia.org --- Clarify title so it's clear we all agree. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
