[Bug 51958] Watchlist and recent changes should be able to show diffs inline
https://bugzilla.wikimedia.org/show_bug.cgi?id=51958
--- Comment #11 from Bartosz Dziewoński matma@gmail.com ---
Works and I like it :)
If we wanted to make this a core feature, I think we should just make
it hook to the N changes / cur | prev links instead of adding more
(as the watchlist interface is already rather cluttered and
intimidating).
When we do that, we should make viewing the diff inline update the
page visitedness status (whether the pages on Watchlist are bolded;
I think there's some default gadget at en.wp which disables this
incredibly useful feature :(, so you'd have to disable it to see the
result there).
If we were to merge your script into core MediaWiki, we'd have to make
it adhere to our coding conventions (see [[mw:CC]] and [[mw:CC/JS]])
and you'd have to agree to a relicense it under GNU GPL or a
compatible license (e.g. MIT) – unfortunately CC BY-SA (under which
you implicitly released it by putting it in a Wikipedia page) is
apparently not compatible, but things can easily have multiple
different licenses.
As for general review of the code, if you're interested :)
* After you click the [inspect diff] link, there's a period of time
when nothing is happening (while the API request is loading) – there
needs to be some indicator that the script is not stuck.
I pastebinned a simple solution here: http://pastebin.com/cb7W2U9i ,
feel free to use it.
* Why are you allowing only one API request to be active at a time?
* Selectors like :contains are rather slow and should not be used
unless absolutely necessary; not sure if this is the cause, but the
script can take a few seconds to set up the buttons on large pages
* Changing the 'type' of inputs and buttons after they are created
will throw an exception on IE=8; it's better to use something like
$('input type=button')[0] to create them
* Using Object.keys will likewise throw an exception on some older
browsers, I think.
* We have a few fancy libraries you could use instead of
reimplementing some logic, like mediawiki.api or mediawiki.Uri, or
the aforementioned jquery.spinner. They all are (or should be)
documented at https://doc.wikimedia.org/mediawiki-core/master/js/
and can be loaded using mw.loader.using([dependencies], callback)
like in my pastebin above.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51958] Watchlist and recent changes should be able to show diffs inline
https://bugzilla.wikimedia.org/show_bug.cgi?id=51958
--- Comment #12 from Rainer Rillke @commons.wikimedia
rainerril...@hotmail.com ---
(In reply to comment #11)
$('input type=button')[0] to create them
Note that this should be valid HTML then, including closing tags for elements
that need closing tags.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51958] Watchlist and recent changes should be able to show diffs inline
https://bugzilla.wikimedia.org/show_bug.cgi?id=51958 writ.keeper.e...@gmail.com changed: What|Removed |Added CC||writ.keeper.e...@gmail.com --- Comment #6 from writ.keeper.e...@gmail.com --- What doesn't it work with? Seems to work on my watchlist and RC on en at least; is there a different thing for which it doesn't work? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51958] Watchlist and recent changes should be able to show diffs inline
https://bugzilla.wikimedia.org/show_bug.cgi?id=51958 --- Comment #7 from Quiddity pandiculat...@gmail.com --- (In reply to comment #6) What doesn't it work with? Seems to work on my watchlist and RC on en at least; is there a different thing for which it doesn't work? If you bundle changes, (by enabling in preferences: [Recent change]-Group changes by page in recent changes and watchlist and [Watchlist]-Expand watchlist to show all changes, not just the most recent) then it doesn't work. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51958] Watchlist and recent changes should be able to show diffs inline
https://bugzilla.wikimedia.org/show_bug.cgi?id=51958 --- Comment #8 from writ.keeper.e...@gmail.com --- Well, jeez, it's hardly my fault that, if you switch the grouped RC changes on, it changes the format for both RC *and* watchlist to use tables instead of uls. (Is that a bug, by the way? Why would changing an RC setting also change the format of the watchlist too? Switching on the expanded watchlist without switching on the grouped RC doesn't change the format of the watchlist page, and the script still works.) Anyway, I'll fix that. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51958] Watchlist and recent changes should be able to show diffs inline
https://bugzilla.wikimedia.org/show_bug.cgi?id=51958 --- Comment #9 from writ.keeper.e...@gmail.com --- Ah, nevermind, I see the point now. Still going to try to fix it. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51958] Watchlist and recent changes should be able to show diffs inline
https://bugzilla.wikimedia.org/show_bug.cgi?id=51958 --- Comment #10 from writ.keeper.e...@gmail.com --- Okay, done! I think it should work on the enhanced RC and watchlist now, for both collapsing and uncollapsing entries. Give it a shot and let me know if it works, and whether there are any more suggestions. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51958] Watchlist and recent changes should be able to show diffs inline
https://bugzilla.wikimedia.org/show_bug.cgi?id=51958 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added CC||matma@gmail.com --- Comment #4 from Bartosz Dziewoński matma@gmail.com --- It doesn't seem to work with enhanced watchlist/RC :( -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51958] Watchlist and recent changes should be able to show diffs inline
https://bugzilla.wikimedia.org/show_bug.cgi?id=51958 --- Comment #5 from Bartosz Dziewoński matma@gmail.com --- (I definitely like what it's doing when it works, though, I was imagining pretty much exactly that.) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51958] Watchlist and recent changes should be able to show diffs inline
https://bugzilla.wikimedia.org/show_bug.cgi?id=51958
Quiddity pandiculat...@gmail.com changed:
What|Removed |Added
CC||pandiculat...@gmail.com
--- Comment #3 from Quiddity pandiculat...@gmail.com ---
https://en.wikipedia.org/wiki/User:Writ_Keeper/Scripts/inlineDiffDocs does
this.
To test:
importScript('User:Writ Keeper/Scripts/commonHistory.js');
I think this could be a good new gadget (for now, and possibly a mediawiki
feature in future months/years); I shall suggest that on the talkpage, next.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51958] Watchlist and recent changes should be able to show diffs inline
https://bugzilla.wikimedia.org/show_bug.cgi?id=51958 Rainer Rillke @commons.wikimedia rainerril...@hotmail.com changed: What|Removed |Added CC||rainerril...@hotmail.com --- Comment #2 from Rainer Rillke @commons.wikimedia rainerril...@hotmail.com --- Or at least it should allow loading the diffs using AJAX. Navigation popups is rather ugly: 1) The timeout before it sends the request 2) you can't move your pointer away or the popup closes. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51958] Watchlist and recent changes should be able to show diffs inline
https://bugzilla.wikimedia.org/show_bug.cgi?id=51958 Jesús Martínez Novo (Ciencia Al Poder) martinezn...@gmail.com changed: What|Removed |Added CC||martinezn...@gmail.com Severity|normal |enhancement --- Comment #1 from Jesús Martínez Novo (Ciencia Al Poder) martinezn...@gmail.com --- Changing to Enhancement. It exists as a Gadget. See [[Wikipedia:Tools/Navigation popups]] -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51958] Watchlist and recent changes should be able to show diffs inline
https://bugzilla.wikimedia.org/show_bug.cgi?id=51958 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
