[Bug 52347] Use an IContextSource instead of globals
https://bugzilla.wikimedia.org/show_bug.cgi?id=52347 Raylton P. Sousa raylton.so...@gmail.com changed: What|Removed |Added Assignee|molly.whi...@gmail.com |legoktm.wikipe...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52347] Use an IContextSource instead of globals
https://bugzilla.wikimedia.org/show_bug.cgi?id=52347 Thomas Lam t@lamsinfosystem.com changed: What|Removed |Added CC||t@lamsinfosystem.com --- Comment #4 from Thomas Lam t@lamsinfosystem.com --- so is what I need to do just add $context as a parameter for the method and use the context's methods to get the variables? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52347] Use an IContextSource instead of globals
https://bugzilla.wikimedia.org/show_bug.cgi?id=52347 --- Comment #5 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com --- (In reply to comment #4) so is what I need to do just add $context as a parameter for the method and use the context's methods to get the variables? Basically yup! -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52347] Use an IContextSource instead of globals
https://bugzilla.wikimedia.org/show_bug.cgi?id=52347 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52347] Use an IContextSource instead of globals
https://bugzilla.wikimedia.org/show_bug.cgi?id=52347 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 99584 had a related patch set uploaded by Tholam: Use an IContextSource instead of globals in addDate method https://gerrit.wikimedia.org/r/99584 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52347] Use an IContextSource instead of globals
https://bugzilla.wikimedia.org/show_bug.cgi?id=52347 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 99584 merged by jenkins-bot: Use an IContextSource instead of globals in addDate method https://gerrit.wikimedia.org/r/99584 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52347] Use an IContextSource instead of globals
https://bugzilla.wikimedia.org/show_bug.cgi?id=52347 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com --- Thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52347] Use an IContextSource instead of globals
https://bugzilla.wikimedia.org/show_bug.cgi?id=52347 Quim Gil q...@wikimedia.org changed: What|Removed |Added URL||http://www.google-melange.c ||om/gci/task/view/google/gci ||2013/5818417563041792 --- Comment #3 from Quim Gil q...@wikimedia.org --- Thank you! Google Code-in task created. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52347] Use an IContextSource instead of globals
https://bugzilla.wikimedia.org/show_bug.cgi?id=52347 --- Comment #1 from Quim Gil q...@wikimedia.org --- I m happy to submit this bug as a Google Code-in task. However, in its current status it is quite cryptic for a newcomer. There is only a link to a patch merged with some comments around. Can you add a proper description of the bug, please? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52347] Use an IContextSource instead of globals
https://bugzilla.wikimedia.org/show_bug.cgi?id=52347 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added Keywords||easy CC||legoktm.wikipe...@gmail.com --- Comment #2 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com --- That function uses $wgLang and $wgUser, which are evil globals. Each parent caller (through various functions) provides context, which is some object that implements IContextSource. The code should simply pass the context down and use $context-getLanguage() and $context-getUser() instead of relying on globals. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52347] Use an IContextSource instead of globals
https://bugzilla.wikimedia.org/show_bug.cgi?id=52347 Quim Gil q...@wikimedia.org changed: What|Removed |Added CC||q...@wikimedia.org Whiteboard||gci2013 ||https://www.mediawiki.org/w ||iki/Google_Code-In#Candidat ||e_tasks -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52347] Use an IContextSource instead of globals
https://bugzilla.wikimedia.org/show_bug.cgi?id=52347 Raylton P. Sousa raylton.so...@gmail.com changed: What|Removed |Added Priority|Unprioritized |Normal Status|UNCONFIRMED |NEW CC||raylton.so...@gmail.com Assignee|wikibugs-l@lists.wikimedia. |molly.whi...@gmail.com |org | Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52347] Use an IContextSource instead of globals
https://bugzilla.wikimedia.org/show_bug.cgi?id=52347 Molly White molly.whi...@gmail.com changed: What|Removed |Added Blocks||50386 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
