[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 --- Comment #14 from Antoine hashar Musso has...@free.fr --- (In reply to comment #13) (In reply to comment #12) Do we want to introduce CIDR ranges in operations/mediawiki-config.git as well or is using a list of IP good enough for us? I think that Mark would like to start using CIDR ranges at least for the IPv6 varnish addresses. Actually doing this work was escalated due to some configuration related issues that marked edits as coming from internal IPs following the ulsfo rollout. I have pinged the ops internal mailing list to figure out whether they are interested in getting CIDR ranges for $wgSquidServersNoPurge. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 --- Comment #12 from Antoine hashar Musso has...@free.fr --- Do we want to introduce CIDR ranges in operations/mediawiki-config.git as well or is using a list of IP good enough for us? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 --- Comment #13 from Bryan Davis bda...@wikimedia.org --- (In reply to comment #12) Do we want to introduce CIDR ranges in operations/mediawiki-config.git as well or is using a list of IP good enough for us? I think that Mark would like to start using CIDR ranges at least for the IPv6 varnish addresses. Actually doing this work was escalated due to some configuration related issues that marked edits as coming from internal IPs following the ulsfo rollout. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 Faidon Liambotis fai...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|REOPENED CC||fai...@wikimedia.org, ||o...@wikimedia.org Resolution|FIXED |--- --- Comment #8 from Faidon Liambotis fai...@wikimedia.org --- So, because this checked against the list we already have, $wgSquidServersNoPurge, which is currently 225 entries of single IPs, this ran a CIDR match up to 225 times, which in turn increased the appserver load by about 20-30% -- the CPU cost could be differ a lot depending on hour of the day (- service region - datacenter - list order :)). This was deployed yesterday and we had to revert today, which brought appservers down from 80% to 50% usage and API appservers from 60% to 30%. Reedy optimized this check with https://gerrit.wikimedia.org/r/#/c/95163/ which Antoine reviewed and merged, but hasn't deployed yet. We could also reduce our load in another way, by aggregating our list to CIDR and cutting it down to 10-15 entries at most (which was the original intention anyway). Since the isInRange seems to be expensive, though, I'd feel more comfortable if someone took a closer look and optimized the call (e.g. by making it be *just* CIDR with a simple bitwise operation, not ranges in general) and/or made a separate array for CIDR ranges as it sounds pretty silly to do such expensive checks on what is known to have been a list of single IP addresses until now. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 Antoine hashar Musso has...@free.fr changed: What|Removed |Added CC||has...@free.fr --- Comment #9 from Antoine hashar Musso has...@free.fr --- As a summary, we have to apply on the wmf branches: Support CIDR ranges in $wgSquidServersNoPurge https://gerrit.wikimedia.org/r/#/c/94186/ f111b2687c894bd744f53edff4ae049ddb48c59a AND Short circuit $wgSquidServersNoPurge iteration if ip is listed https://gerrit.wikimedia.org/r/#/c/95163/ b89355c27035be293f6b28d32239fe8879b7e46c Then later on we can introduce CIDR ranges in operations/mediawiki-config.git which should probably be another bug. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 Bryan Davis bda...@wikimedia.org changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=57021 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 --- Comment #10 from Ori Livneh o...@wikimedia.org --- (In reply to comment #8) So, because this checked against the list we already have, $wgSquidServersNoPurge, which is currently 225 entries of single IPs, this ran a CIDR match up to 225 times, which in turn increased the appserver load by about 20-30% -- the CPU cost could be differ a lot depending on hour of the day (- service region - datacenter - list order :)). This was deployed yesterday and we had to revert today, which brought appservers down from 80% to 50% usage and API appservers from 60% to 30%. Reedy optimized this check with https://gerrit.wikimedia.org/r/#/c/95163/ which Antoine reviewed and merged, but hasn't deployed yet. We could also reduce our load in another way, by aggregating our list to CIDR and cutting it down to 10-15 entries at most (which was the original intention anyway). Since the isInRange seems to be expensive, though, I'd feel more comfortable if someone took a closer look and optimized the call (e.g. by making it be *just* CIDR with a simple bitwise operation, not ranges in general) and/or made a separate array for CIDR ranges as it sounds pretty silly to do such expensive checks on what is known to have been a list of single IP addresses until now. Faidon, thanks very much for investigating; I should have reviewed this more carefully. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 --- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 94392 merged by jenkins-bot: Support CIDR ranges in $wgSquidServersNoPurge https://gerrit.wikimedia.org/r/94392 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 94396 merged by jenkins-bot: Support CIDR ranges in $wgSquidServersNoPurge https://gerrit.wikimedia.org/r/94396 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 Umherirrender umherirrender_de...@web.de changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED CC||umherirrender_de...@web.de Resolution|--- |FIXED --- Comment #7 from Umherirrender umherirrender_de...@web.de --- was successfully merged -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 --- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 94186 merged by jenkins-bot: Support CIDR ranges in $wgSquidServersNoPurge https://gerrit.wikimedia.org/r/94186 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 94392 had a related patch set uploaded by BryanDavis: Support CIDR ranges in $wgSquidServersNoPurge https://gerrit.wikimedia.org/r/94392 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 --- Comment #1 from Bryan Davis bda...@wikimedia.org --- Mark has asked for this as well as it would make dealing with IPv6 in the varnish clusters easier for Ops. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 Bryan Davis bda...@wikimedia.org changed: What|Removed |Added Priority|Low |Normal CC||bda...@wikimedia.org Version|1.22rc |1.23-git Assignee|wikibugs-l@lists.wikimedia. |bda...@wikimedia.org |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 --- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 94186 had a related patch set uploaded by BryanDavis: Support CIDR ranges in $wgSquidServersNoPurge https://gerrit.wikimedia.org/r/94186 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52829] $wgSquidServersNoPurge should support CIDR ranges
https://bugzilla.wikimedia.org/show_bug.cgi?id=52829 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Low -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
