[Bug 53477] VisualEditor: Edit tab replaced with Create source for Education Program pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477 --- Comment #12 from Andrew Green andrew.green...@gmail.com --- Added a comment on the Gerrit change. tl;dr: Is $wgContentNamespaces getting checked? I don't see how EP_NS could be there, and checking it in js seems to fix the issue. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53477] VisualEditor: Edit tab replaced with Create source for Education Program pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477
--- Comment #13 from Andrew Green andrew.green...@gmail.com ---
P.S. Go to a production wiki and try this in a js console:
mw.config.get('wgContentNamespaces')
The results coincide:
https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/InitialiseSettings.php#L9292-9349
I lost the scent of $wgVisualEditorNamespaces following a brief pursuit,
though...
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53477] VisualEditor: Edit tab replaced with Create source for Education Program pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED Target Milestone|--- |VE-deploy-2014-04-17 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53477] VisualEditor: Edit tab replaced with Create source for Education Program pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477 --- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125233 merged by jenkins-bot: Don't change tabs on Education Program pages https://gerrit.wikimedia.org/r/125233 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53477] VisualEditor: Edit tab replaced with Create source for Education Program pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477 --- Comment #7 from Krinkle krinklem...@gmail.com --- From a quick investigation it looks like there are about a dozen different ways in which VisualEditor can reasonably find out that the page is not a real wikipage. Not one of them is being used by EP right now. * It's pretending to be a wiki page (by having its own namespace and using action=view, albeit overridden, to render the dynamically constructed page). * Generally this is something we have Special pages for. If the rendering is completely taken over (as in, there is no page table entry, no revisions table entries etc.), it should be a Special page. Or at least a custom namespace with a negative namespace id. * It abuses existing WikiPage action queries (action=edit, action=delete), which doesn't make sense because it isn't a WikiPage. So inherently this is going to cause trouble because: 1) They aren't compatible (the query string parameters Action pages take aren't supported, other than title=). 2) It doesn't scale. Right now they take over move, delete, edit and view. But there are more page actions, and by design they will not support all of them (they override the ones they re-implement and the rest just fails). For example View history (action=history) is quite useless right now. And action=edit doesn't work as expected. Not to mention API actions, none of those are working as expected. 3) Existence check impossible. Because they aren't actually wiki pages with page and revision ids, existence check isn't possible. ContentModel can't be overridden because it doesn't use wikipage content. All pages are considered inexistent pages in a custom namespace, and then overridden to exist in some cases. There are many different ways in which EP could indicate in a standard / reliable way that doesn't require other code to hardcode for EP specifically, and it doesn't seem to be using any of them. I'd say EP should either let us know how to generically detect it without being EP specific, or it should implement support to at least do one thing right. Possibly we could do the latter ourselves (maybe Alex is interested in patching EP). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53477] VisualEditor: Edit tab replaced with Create source for Education Program pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477 --- Comment #8 from Alex Monk kren...@gmail.com --- (In reply to Krinkle from comment #7) I'd say EP should either let us know how to generically detect it without being EP specific, or it should implement support to at least do one thing right. Possibly we could do the latter ourselves (maybe Alex is interested in patching EP). I don't really think this bug is important enough to VE to justify making big changes to how another extension works... -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53477] VisualEditor: Edit tab replaced with Create source for Education Program pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477 --- Comment #9 from Andrew Green andrew.green...@gmail.com --- I can look into making the EP extension warn VE through some generic mechanism. The bug is moderately important for users of the extension, and I imagine there's some way to do this without making major changes. BTW, I wouldn't recommend that anyone try to make major changes to the EP extension, as the plan is just to rewrite it. The issues Krinkle mentions are certainly valid. Alex's patch also looks like a fine temporary solution. :) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53477] VisualEditor: Edit tab replaced with Create source for Education Program pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477 --- Comment #10 from James Forrester jforres...@wikimedia.org --- (In reply to Andrew Green from comment #9) I can look into making the EP extension warn VE through some generic mechanism. Ideally EP would warn VE through the existing generic mechanisms that Krinkle suggested; this would avoid VE having to have EP-specific code in it entirely. :-) BTW, I wouldn't recommend that anyone try to make major changes to the EP extension, as the plan is just to rewrite it. Understood. Alex's patch also looks like a fine temporary solution. :) Alex's patch is necessarily a horrible hack, but yeah… -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53477] VisualEditor: Edit tab replaced with Create source for Education Program pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125233 had a related patch set uploaded by Alex Monk: Only make tab changes on articles https://gerrit.wikimedia.org/r/125233 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53477] VisualEditor: Edit tab replaced with Create source for Education Program pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53477] VisualEditor: Edit tab replaced with Create source for Education Program pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477 Anna Koval ako...@wikimedia.org changed: What|Removed |Added CC||ako...@wikimedia.org --- Comment #3 from Anna Koval ako...@wikimedia.org --- Hi James, just noting for the record that this is still quite problematic, and we very much appreciate any efforts to fix it. :) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53477] VisualEditor: Edit tab replaced with Create source for Education Program pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Assignee|jforrester+veteambztickets@ |kren...@gmail.com |wikimedia.org | --- Comment #4 from James Forrester jforres...@wikimedia.org --- Slinging to Alex – not sure what the fix here would be (it feels like overriding the semantics of a tab is something that should involve a class change, really) – thoughts? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53477] VisualEditor: Edit tab replaced with Create source for Education Program pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477 --- Comment #5 from Alex Monk kren...@gmail.com --- I think VE shouldn't be modifying tabs on pages which aren't articles (check wgIsArticle is true before doing anything). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53477] VisualEditor: Edit tab replaced with Create source for Education Program pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Assignee|krinklem...@gmail.com |jforrester+veteambztickets@ ||wikimedia.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53477] VisualEditor: Edit tab replaced with Create source for Education Program pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Priority|Normal |High Status|NEW |ASSIGNED CC||roan.katt...@gmail.com, ||tpars...@wikimedia.org Component|General |MediaWiki integration Assignee|jforres...@wikimedia.org|krinklem...@gmail.com Summary|Edit tab replaced with |VisualEditor: Edit tab |Create source for |replaced with Create |Education Program pages |source for Education ||Program pages -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
