[Bug 54341] VisualEditor: ref name corruption for unnamed refs

2013-09-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54341

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|RESOLVED|PATCH_TO_REVIEW
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54341] VisualEditor: ref name corruption for unnamed refs

2013-09-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54341

--- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 85781 had a related patch set uploaded by Catrope:
Prevent naming collisions when generating unique reference names

https://gerrit.wikimedia.org/r/85781

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54341] VisualEditor: ref name corruption for unnamed refs

2013-09-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54341

--- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 85780 had a related patch set uploaded by Catrope:
Prevent naming collisions when generating unique reference names

https://gerrit.wikimedia.org/r/85780

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54341] VisualEditor: ref name corruption for unnamed refs

2013-09-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54341

--- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 85780 merged by jenkins-bot:
Prevent naming collisions when generating unique reference names

https://gerrit.wikimedia.org/r/85780

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54341] VisualEditor: ref name corruption for unnamed refs

2013-09-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54341

--- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 85781 merged by jenkins-bot:
Prevent naming collisions when generating unique reference names

https://gerrit.wikimedia.org/r/85781

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54341] VisualEditor: ref name corruption for unnamed refs

2013-09-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54341

--- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 85144 merged by jenkins-bot:
Prevent naming collisions when generating unique reference names

https://gerrit.wikimedia.org/r/85144

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54341] VisualEditor: ref name corruption for unnamed refs

2013-09-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54341

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

   Priority|Unprioritized   |High
 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED
   Target Milestone|--- |VE-deploy-2013-09-26

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54341] VisualEditor: ref name corruption for unnamed refs

2013-09-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54341

Roan Kattouw roan.katt...@gmail.com changed:

   What|Removed |Added

   Assignee|esand...@wikimedia.org  |roan.katt...@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54341] VisualEditor: ref name corruption for unnamed refs

2013-09-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54341

--- Comment #1 from Roan Kattouw roan.katt...@gmail.com ---
Isolated test case: https://en.wikipedia.org/wiki/User:Ed_g2s/Sandbox4

Diagnosis:

The automatically generated names are based on the number of distinct
references in the page up to that point, indexed at zero. The first unnamed
ref tag is the 4th distinct reference on the page (it's preceded by two :1s,
a :3 and a :0), so its autogenerated name is :3. However, there so happens to
already be a literal ref name=:3 on the page, so we get a naming collision
and the whole thing goes to hell.

In practice, this situation can only arise after multiple iterations of
duplicating unnamed references with VE (which adds ref name=:n tags to the
source), then removing or reordering references so the ref tags are aligned
exactly right for this bug to occur.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54341] VisualEditor: ref name corruption for unnamed refs

2013-09-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54341

--- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 85144 had a related patch set uploaded by Catrope:
Failing test for ref name=:3 bug

https://gerrit.wikimedia.org/r/85144

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54341] VisualEditor: ref name corruption for unnamed refs

2013-09-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54341

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l