[Bug 54357] 404 page is wrong on sister projects when path starts with /w/

2013-09-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54357

--- Comment #9 from Matthew Flaschen  ---
You're right, I forgot to attach it (nor does it look like I took it).  The
issue was just that it linked to Wikipedia instead of Wiktionary.

It's not clear what the correct behavior is.  I agree in those examples, adding
just /wiki would be better (e.g. https://en.wiktionary.org/wiki/w/o).

But it's quite possible someone could visit
https://en.wikipedia.org/w/John%20Smith, in which case the current behavior is
ideal (converting /w to /wiki).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54357] 404 page is wrong on sister projects when path starts with /w/

2013-09-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54357

MZMcBride  changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=35052

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54357] 404 page is wrong on sister projects when path starts with /w/

2013-09-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54357

--- Comment #8 from MZMcBride  ---
I agree with Jeremy that the current behavior isn't ideal. If a user visits
, he or she is currently prompted with:

---
To check for "o" see: https://en.wiktionary.org/wiki/o
---

This should be:

---
To check for "w/o" see: https://en.wiktionary.org/wiki/w/o
---

Perhaps we should special-case "w/"? This may be the subject of a separate
(future) bug report, but it certainly seems like a valid bug to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54357] 404 page is wrong on sister projects when path starts with /w/

2013-09-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54357

--- Comment #7 from jeremyb  ---
You said yields the "attached" but I see no attachment.

Is "/w/r/t" not supposed to go to /wiki/w/r/t ? (
https://en.wiktionary.org/wiki/WRT )

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54357] 404 page is wrong on sister projects when path starts with /w/

2013-09-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54357

--- Comment #6 from Matthew Flaschen  ---
(In reply to comment #5)
> not fixed AFAICT

The example in my report (https://en.wiktionary.org/w/r/t) works.  It shows the
correct 404 page, linking to https://en.wiktionary.org/wiki/r/t, just as
https://en.wikipedia.org/w/r/t links to https://en.wikipedia.org/wiki/r/t

Is there a similar example that still points to the wrong place on a sister
project?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54357] 404 page is wrong on sister projects when path starts with /w/

2013-09-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54357

jeremyb  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||bugzilla+org.wikimedia@tuxm
   ||achine.com
 Resolution|FIXED   |---

--- Comment #5 from jeremyb  ---
not fixed AFAICT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54357] 404 page is wrong on sister projects when path starts with /w/

2013-09-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54357

Sam Reed (reedy)  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54357] 404 page is wrong on sister projects when path starts with /w/

2013-09-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54357

--- Comment #4 from Gerrit Notification Bot  ---
Change 85380 merged by Reedy:
404 page is wrong on sister projects when path starts with /w/

https://gerrit.wikimedia.org/r/85380

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54357] 404 page is wrong on sister projects when path starts with /w/

2013-09-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54357

--- Comment #3 from Gerrit Notification Bot  ---
Change 85380 had a related patch set uploaded by Reedy:
404 page is wrong on sister projects when path starts with /w/

https://gerrit.wikimedia.org/r/85380

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54357] 404 page is wrong on sister projects when path starts with /w/

2013-09-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54357

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54357] 404 page is wrong on sister projects when path starts with /w/

2013-09-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54357

--- Comment #2 from Sam Reed (reedy)  ---
I've tidied up the file and removed some of the ancient unused code paths

The problem code is in this area:

if( preg_match( "|(%2f)|i", $loc, $matches )
|| preg_match( "|^/upload/(.*)|i",$loc, $matches )
|| preg_match("|^/style/(.*)|i",$loc, $matches )
|| preg_match( "|^/wiki/(.*)|i",$loc, $matches )
|| preg_match("|^/w/(.*)|i",$loc, $matches )
|| preg_match( "|^/extensions/(.*)|i",$loc, $matches )
) {
$title = htmlspecialchars( $matches[1] );
$details = "To check for \"$title\" on
Wikipedia, see:

//en.wikipedia.org/wiki/$title";
} else {
$target = $prot . $serv . "/wiki" . $loc;
$encTarget = htmlspecialchars( $target );
header( "Refresh: 5; url=$encTarget" );
$details="Did you mean to type $encTarget?
  You will be automatically redirected there in five seconds.";
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54357] 404 page is wrong on sister projects when path starts with /w/

2013-09-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54357

--- Comment #1 from Sam Reed (reedy)  ---
Incase you have a desire to fix it...
https://git.wikimedia.org/blob/operations%2Fmediawiki-config.git/7e6de7255d6d0c6f6e515b1ea4ee9fad17c2bc0c/w%2F404.php

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54357] 404 page is wrong on sister projects when path starts with /w/

2013-09-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54357

Sam Reed (reedy)  changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
   Severity|normal  |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l