[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 Alex Monk kren...@wikimedia.org changed: What|Removed |Added Keywords|patch-need-review |patch-reviewed CC||kren...@wikimedia.org --- Comment #11 from Alex Monk kren...@wikimedia.org --- This JavaScript 'fix' is basically the equivalent of fixing a MediaWiki core bug with a default-on gadget. It's not a patch for the software itself. It could also be a lot simpler than it currently is. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 --- Comment #12 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com --- (In reply to Alex Monk from comment #11) This JavaScript 'fix' is basically the equivalent of fixing a MediaWiki core bug with a default-on gadget. It's not a patch for the software itself. It could also be a lot simpler than it currently is. First, I don't know JS that well, and put this together by just messing with my browser console. Please improve it :D Second, I agree with your analogy. But in this case, I'm not sure this is totally a bad thing. I think we should evaluate it based on: a) How important is this feature for OTRS agents (https://otrs-wiki.wikimedia.org/wiki/Talk:Upgrade_issues#Can.27t_get_rid_of_spam_as_quickly). b) How likely we're going to be able to get someone (who??) to write this properly as an OTRS extension (if those exist??). RD or another OTRS admin can probably answer a), I don't know who would be able to answer b). Occasionally, we do hotfix hacks in site-wide JS/CSS which really should be done server-side, but the caveat is that those are promptly fixed in a proper manner. If we do deploy this JS script, it's even more unlikely it would ever get a proper fix. But being realistic, I doubt anyone is ever going to fix this properly to begin with. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 Alex Monk kren...@wikimedia.org changed: What|Removed |Added Keywords|patch-reviewed | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 Alex Monk kren...@wikimedia.org changed: What|Removed |Added Attachment #13876|0 |1 is obsolete|| --- Comment #13 from Alex Monk kren...@wikimedia.org --- Created attachment 16667 -- https://bugzilla.wikimedia.org/attachment.cgi?id=16667action=edit OTRS 1 click spam button JS gadget -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 Nemo federicol...@tiscali.it changed: What|Removed |Added CC||federicol...@tiscali.it --- Comment #10 from Nemo federicol...@tiscali.it --- FWIW, in OTRS I usually use bulk actions after mass-checking the spam mails with an extension like https://addons.mozilla.org/firefox/addon/checkfox/ (Probably obvious to many but not to all and I don't know where else to post it. Originally suggested to me by Frieda many years ago.) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 --- Comment #9 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com --- (In reply to Andre Klapper from comment #8) legoktm: Could you put that patch into Gerrit against http://git.wikimedia.org/blob/operations%2Fsoftware%2Fotrs.git/HEAD/ patches%2F50-one-click-spam.patch ? Well, it's not really a patch to the software, so I'm not sure that makes sense. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 --- Comment #8 from Andre Klapper aklap...@wikimedia.org --- (In reply to Kunal Mehta (Legoktm) from comment #3) Created attachment 13876 [details] New patch sends the request asynchronously and hides the ticket after success rather than reloading the page. legoktm: Could you put that patch into Gerrit against http://git.wikimedia.org/blob/operations%2Fsoftware%2Fotrs.git/HEAD/patches%2F50-one-click-spam.patch ? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 Bug 54755 depends on bug 60271, which changed state. Bug 60271 Summary: Upgrade OTRS to the latest 3.2.x version https://bugzilla.wikimedia.org/show_bug.cgi?id=60271 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 Sam Reed (reedy) s...@reedyboy.net changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 Philippe Beaudette phili...@wikimedia.org changed: What|Removed |Added CC||phili...@wikimedia.org --- Comment #7 from Philippe Beaudette phili...@wikimedia.org --- Sure, you can add me as the PM, but I don't think I can actually do much here. As I understand it, we're looking for someone who can add the patch - that's not me. And I have no control over the engineering resources. :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 MZMcBride b...@mzmcbride.com changed: What|Removed |Added Depends on||60271 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 MZMcBride b...@mzmcbride.com changed: What|Removed |Added CC||aklap...@wikimedia.org --- Comment #5 from MZMcBride b...@mzmcbride.com --- Andre: who should be assigned to this bug report? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 --- Comment #6 from Andre Klapper aklap...@wikimedia.org --- (In reply to comment #5) Andre: who should be assigned to this bug report? Jeff Green is already CC'ed (who sometimes helps out with OTRS patches); Philippe would be the PM here, kind of. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 --- Comment #4 from Ryan (Rjd0060) rjd0060.w...@gmail.com --- I have tested the proposed patch and found no issues. It works great. For reference, my UA is as follows: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0 I would support enabling this as soon as possible, of course pending further confirmation/testing and review. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added Attachment #13856|0 |1 is obsolete|| --- Comment #3 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com --- Created attachment 13876 -- https://bugzilla.wikimedia.org/attachment.cgi?id=13876action=edit v2 New patch sends the request asynchronously and hides the ticket after success rather than reloading the page. Also it loads better. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Keywords||patch-need-review -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 --- Comment #1 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com --- Created attachment 13856 -- https://bugzilla.wikimedia.org/attachment.cgi?id=13856action=edit one click spam button JavaScript that adds a button which says SPAM, and implements the one-click-spam functionality in QueueView. Note that it looks a bit weird in Firefox (top is cut off), but fine in Chromium using OSX 10.9. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 Bug 54755 depends on bug 35720, which changed state. Bug 35720 Summary: Second button for Junk (non-spam) queue https://bugzilla.wikimedia.org/show_bug.cgi?id=35720 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 Ryan (Rjd0060) rjd0060.w...@gmail.com changed: What|Removed |Added Depends on||35720 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54755] Create OTRS patch for 1-click spam disposal
https://bugzilla.wikimedia.org/show_bug.cgi?id=54755 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
