[Bug 55272] redirectRegex throws type error

2014-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55272

Amir Ladsgroup ladsgr...@gmail.com changed:

   What|Removed |Added

   Priority|Unprioritized   |Low
 CC||ladsgr...@gmail.com

--- Comment #8 from Amir Ladsgroup ladsgr...@gmail.com ---
The patch has been applied yet so It's still reproducible (I haven't checked
though) since it's compat bug I mark it as low priority

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55272] redirectRegex throws type error

2014-06-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55272

xqt i...@gno.de changed:

   What|Removed |Added

Version|unspecified |compat (1.0)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55272] redirectRegex throws type error

2013-12-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55272

xqt i...@gno.de changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC||i...@gno.de

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55272] redirectRegex throws type error

2013-10-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55272

--- Comment #1 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
Thanks a lot for analyzing it and these details. I'll fix it tomorrow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55272] redirectRegex throws type error

2013-10-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55272

Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:

   What|Removed |Added

   See Also||https://sourceforge.net/p/p
   ||ywikipediabot/bugs/1201

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55272] redirectRegex throws type error

2013-10-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55272

--- Comment #3 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
fixed in r8329

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55272] redirectRegex throws type error

2013-10-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55272

--- Comment #7 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
patch against r8333 to fix the bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55272] redirectRegex throws type error

2013-10-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55272

--- Comment #2 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
- **assigned_to**: nobody -- xqt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55272] redirectRegex throws type error

2013-10-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55272

--- Comment #6 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
The bug fix in r8329 doesn't correct the problem. This is perhaps because I
mis-analyzed the problem. In fact the try ... except block in siteinfo
accomplishes nothing, since the KeyError occurs outside its scope. So, what
really happens is the exception occurs and propagates. However, the value
returned on an exception is None. So, it propagates through getmagicwords to
redirectRegex. For some reason I don't understand, it is not caught by the
except clause there before the pattern statement executes \(causing the type
error\).

The solution \(which I have tested\) is to put a try ... except block in
getmagicwords and return None when a KeyError occurs. This consumes the
KeyError exception and allows the change in r8333 to redirectRegex to work
properly. In addition, it makes no sense to have the try ... except block in
siteinfo, since it isn't possible for a KeyError to occur as the result of
either of the two return statements.

I will attach a patch against r8333 that fixes the problem.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55272] redirectRegex throws type error

2013-10-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55272

--- Comment #4 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
- **status**: open -- closed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55272] redirectRegex throws type error

2013-10-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55272

--- Comment #5 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
- **status**: closed -- open

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l