[Bug 55589] Installer's interface is unstyled

2013-10-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55589

Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com

--- Comment #7 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
*** Bug 55954 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55589] Installer's interface is unstyled

2013-10-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55589

Kevin Israel (PleaseStand) pleasest...@live.com changed:

   What|Removed |Added

   Severity|normal  |blocker

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55589] Installer's interface is unstyled

2013-10-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55589

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55589] Installer's interface is unstyled

2013-10-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55589

--- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 89610 had a related patch set uploaded by PleaseStand:
Installer: Run the LESS compiler for screen.less

https://gerrit.wikimedia.org/r/89610

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55589] Installer's interface is unstyled

2013-10-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55589

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

   Priority|Unprioritized   |High

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55589] Installer's interface is unstyled

2013-10-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55589

--- Comment #4 from Mark A. Hershberger m...@everybody.org ---
instead of fixing the less/css problem, it may only be necessary to duplicate
the styles into skins/common/config.css

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55589] Installer's interface is unstyled

2013-10-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55589

--- Comment #5 from Mark A. Hershberger m...@everybody.org ---
(In reply to comment #4)
 instead of fixing the less/css problem, it may only be necessary to duplicate
 the styles into skins/common/config.css

I think that would be sufficient for the 1.22 release, at least.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55589] Installer's interface is unstyled

2013-10-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55589

--- Comment #1 from Jon jrob...@wikimedia.org ---
Could you elaborate on what you mean by the installer and what it didn't
account for?

I am unfamiliar with the installer and what needs to be fixed. Does it
reference screen.css as the css file output has not changed in any significant
way...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55589] Installer's interface is unstyled

2013-10-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55589

--- Comment #2 from Jon jrob...@wikimedia.org ---
Ok, so it seems the file  includes/installer/WebInstallerOutput.php references
screen.css - this is bad as they are two distinctly separate things.

The getCSS function should probably return the styles property of the module it
belongs too and there should be a test added to ensure this works as expected
and this doesn't break in future.

If this can't use RL it will also need to access and run the LESS compiler

Is there any reason this file doesn't use ResourceLoader (I assume this code
predates it)?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55589] Installer's interface is unstyled

2013-10-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55589

Bryan Tong Minh bryan.tongm...@gmail.com changed:

   What|Removed |Added

 CC||bryan.tongm...@gmail.com

--- Comment #3 from Bryan Tong Minh bryan.tongm...@gmail.com ---
load.php is not yet available because there is not LocalSettings.php yet.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l