[Bug 55826] PHP Fatal error: Only variables can be passed by reference in includes/api/ApiBrowse.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=55826 MWJames changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55826] PHP Fatal error: Only variables can be passed by reference in includes/api/ApiBrowse.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=55826 --- Comment #11 from Gerrit Notification Bot --- Change 90389 merged by jenkins-bot: (Bug 55826) Fix ApiBrowse unit test failure https://gerrit.wikimedia.org/r/90389 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55826] PHP Fatal error: Only variables can be passed by reference in includes/api/ApiBrowse.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=55826 --- Comment #10 from Gerrit Notification Bot --- Change 90389 had a related patch set uploaded by Mwjames: (#bug 55826) Force ApiBrowse unit test to fail https://gerrit.wikimedia.org/r/90389 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55826] PHP Fatal error: Only variables can be passed by reference in includes/api/ApiBrowse.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=55826 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55826] PHP Fatal error: Only variables can be passed by reference in includes/api/ApiBrowse.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=55826 --- Comment #9 from MWJames --- After looking into it, two issue came into play as to way the unit tests didn't catch the issue. The first issue was caused by PHP 5.3 (I used and old 5.3.8 to verify the issue) which handles pass-by-reference for empty arrays differently and secondly $this->getResult()->setIndexedTagName() (responsible to add '_element' for XML output) applies internally a check whether getIsRawMode() is true/false which in case of the current unit test returns false and therefore will not engage in any array manipulation. By setting $this->getResult()->setRawMode() in the unit test the error is caught which means I'll have to adjust the unit test in order to incorporate the setRawMode() option before fixing the issue which is doing an additional is_array() check. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55826] PHP Fatal error: Only variables can be passed by reference in includes/api/ApiBrowse.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=55826 --- Comment #8 from MWJames --- The following [1] should do the trick but I'd like to have the tests failing first before making any attempt on fixing this. $tag =& $serialized['data'][ $key ]['dataitem']; $this->getResult()->setIndexedTagName( $tag, 'value' ); -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55826] PHP Fatal error: Only variables can be passed by reference in includes/api/ApiBrowse.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=55826 --- Comment #7 from Niklas Laxström --- Not sure if this helps (missing params) but pasting anyway: [17-Oct-2013 13:36:01 UTC] ApiBrowse.php line 122 calls wfBacktrace() ApiBrowse.php line 97 calls SMW\ApiBrowse->addIndexTags() ApiBrowse.php line 28 calls SMW\ApiBrowse->runFormatter() ApiMain.php line 834 calls SMW\ApiBrowse->execute() ApiMain.php line 380 calls ApiMain->executeAction() ApiMain.php line 351 calls ApiMain->executeActionWithErrorHandling() api.php line 73 calls ApiMain->execute() -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55826] PHP Fatal error: Only variables can be passed by reference in includes/api/ApiBrowse.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=55826 --- Comment #6 from Nemo --- (In reply to comment #3) > I tr[ied] using [1]. > > [1] https://translatewiki.net/w/api.php?action=browse&subject=Main_Page Yes, that produces it. :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55826] PHP Fatal error: Only variables can be passed by reference in includes/api/ApiBrowse.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=55826 --- Comment #5 from MWJames --- While fixing the issue shouldn't be the issue here, I'm more interested into why the unit tests didn't raise a flag on both CI's (Jenkins and Travis). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55826] PHP Fatal error: Only variables can be passed by reference in includes/api/ApiBrowse.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=55826 --- Comment #4 from MWJames --- (In reply to comment #3) > I try using [1]. > > [1] https://translatewiki.net/w/api.php?action=browse&subject=Main_Page I'm already asleep. Of course, I meant "I tried". -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55826] PHP Fatal error: Only variables can be passed by reference in includes/api/ApiBrowse.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=55826 --- Comment #3 from MWJames --- I try using [1]. [1] https://translatewiki.net/w/api.php?action=browse&subject=Main_Page -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55826] PHP Fatal error: Only variables can be passed by reference in includes/api/ApiBrowse.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=55826 Niklas Laxström changed: What|Removed |Added CC||niklas.laxst...@gmail.com --- Comment #2 from Niklas Laxström --- I don't. And I do not know how to reliable reproduce this, so it is difficult to get one. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55826] PHP Fatal error: Only variables can be passed by reference in includes/api/ApiBrowse.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=55826 --- Comment #1 from MWJames --- This is strange, neither Jenkins nor Travis kicked in since this part is covered [1]. Do you have the full stack trace? [1] https://coveralls.io/files/68365996 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
