[Bug 56409] Internal error with Modern and Monobook on specific pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56409 Bartosz Dziewoński changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #12 from Bartosz Dziewoński --- Offending code has been removed, this should fix itself on TWN when the new version is deployed there. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56409] Internal error with Modern and Monobook on specific pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56409 --- Comment #11 from Gerrit Notification Bot --- Change 93176 merged by jenkins-bot: Fix fatal error in non-Vector skins by removing nav tabs https://gerrit.wikimedia.org/r/93176 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56409] Internal error with Modern and Monobook on specific pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56409 --- Comment #10 from Bartosz Dziewoński --- I suppose Nike just removed the live hack. I wouldn't be surprised if the effect of a PHP fatal during skin rendering when all debug logging is turned off would be a rendered page that is simply "cut off" at one point. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56409] Internal error with Modern and Monobook on specific pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56409 --- Comment #9 from Nemo --- Created attachment 13676 --> https://bugzilla.wikimedia.org/attachment.cgi?id=13676&action=edit Empty monobook Now most of the page content disappears in MediaWiki namespace on monobook; same thing or different? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56409] Internal error with Modern and Monobook on specific pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56409 Niklas Laxström changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |niklas.laxst...@gmail.com |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56409] Internal error with Modern and Monobook on specific pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56409 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56409] Internal error with Modern and Monobook on specific pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56409 --- Comment #8 from Gerrit Notification Bot --- Change 93176 had a related patch set uploaded by Nikerabbit: Fix fatal error in non-Vector skins by removing nav tabs https://gerrit.wikimedia.org/r/93176 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56409] Internal error with Modern and Monobook on specific pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56409 --- Comment #7 from Bartosz Dziewoński --- He's probably trying to debug this very issue. I'm almost certain that the addTab() function splices the array wrong per comment 3. It would nice great if you could apply another live hack as described there. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56409] Internal error with Modern and Monobook on specific pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56409
Siebrand Mazeland changed:
What|Removed |Added
CC|alolita.sha...@gmail.com, |
|asha...@wikimedia.org, |
|kartik.mis...@gmail.com,|
|krinklem...@gmail.com, |
|run...@gmail.com, |
|santhosh.thottingal@gmail.c |
|om |
--- Comment #6 from Siebrand Mazeland ---
This is a live hack by Niklas.
siebrand@v220131064414794:/www/translatewiki.net/w$ git diff
diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php
index e5b8872..d9b4340 100644
--- a/includes/SkinTemplate.php
+++ b/includes/SkinTemplate.php
@@ -1825,6 +1825,9 @@ abstract class BaseTemplate extends QuickTemplate {
* @return string
*/
function makeListItem( $key, $item, $options = array() ) {
+ if ( !is_array( $item ) ) {
+ throw new MWException( "Who is eating my carrots?" );
+ }
if ( isset( $item['links'] ) ) {
$html = '';
foreach ( $item['links'] as $linkKey => $link ) {
I don't know what he's trying to debug.
Removed some people from CC.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56409] Internal error with Modern and Monobook on specific pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56409 Bartosz Dziewoński changed: What|Removed |Added CC||alolita.sha...@gmail.com, ||asha...@wikimedia.org, ||kartik.mis...@gmail.com, ||niklas.laxst...@gmail.com, ||run...@gmail.com, ||s.mazel...@xs4all.nl, ||santhosh.thottingal@gmail.c ||om Component|Skin and page rendering |Translate Version|unspecified |master Product|MediaWiki |MediaWiki extensions --- Comment #5 from Bartosz Dziewoński --- (Moving to Translate until my gut feeling above is proven wrong.) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56409] Internal error with Modern and Monobook on specific pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56409 --- Comment #4 from Bartosz Dziewoński --- (That function is in TranslateEditAddons.php.) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56409] Internal error with Modern and Monobook on specific pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56409
--- Comment #3 from Bartosz Dziewoński ---
Cursory debugging points me to the following function in Translate:
protected static function addTab( $skin, &$tabs, $name, $data, &$index ) {
// SkinChihuahua is an exception for userbase.kde.org.
if ( $skin instanceof SkinVector || $skin instanceof SkinChihuahua ) {
$data['class'] = false; // These skins need it for some reason
$tabs['namespaces'][$name] = $data;
} else {
array_splice( $tabs, $index++, 0, array( $name => $data ) );
}
}
This is very messy, but my gut feeling is that it should say:
array_splice( $tabs, $index++, 0, array( array( $name => $data ) )
);
This also explains not being broken on Vector (because it's iffed out…) and on
CologneBlue (because it does its own weird things with the navigation and by
chance seems to ignore these entries – that might be a bug).
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56409] Internal error with Modern and Monobook on specific pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56409
--- Comment #2 from Bartosz Dziewoński ---
The interesting part is:
> BaseTemplate->makeListItem('text', 'c<<')
The second argument should be an array. The code doesn't check for that
anywhere, though, and apparently something fails badly if it's not.
The two parameters are keys and values from $this->data['content_actions']
associative array, something must be messing with it in an unpleasant way.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56409] Internal error with Modern and Monobook on specific pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=56409 Bartosz Dziewoński changed: What|Removed |Added Summary|Internal error with modern |Internal error with Modern |skin|and Monobook on specific ||pages -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
