[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 --- Comment #18 from Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org --- I'm fine with this change, but the one thing we lose is the correlation between the error and the email associated with it. Can we change the text to Your email address, $emailaddress is not yet confirmed. You will not receive email notification until you confirm this address. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 --- Comment #19 from Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org --- Small correction Your email address, $emailaddress is not yet confirmed. You will not receive email notifications until you confirm this address. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 --- Comment #17 from roopak mailsto...@gmail.com --- Created attachment 14338 -- https://bugzilla.wikimedia.org/attachment.cgi?id=14338action=edit Screenshot of proposed change Screenshot of the proposed change that shows that only email not authenticated option should be highlighted red as an error. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 --- Comment #13 from roopak mailsto...@gmail.com --- p858snake: I have considered your suggestion and submitted my new patch. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added CC||jared.zimmerman@wikimedia.o ||rg, mflasc...@wikimedia.org --- Comment #14 from Matthew Flaschen mflasc...@wikimedia.org --- I'm not really convinced red (actually pinkish) is bad here. This is only for non-authenticated emails. We *want* to catch their attention. They lose important functionality, including password reset, if they don't confirm their email. CCing Jared for UX feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 --- Comment #15 from Matthew Flaschen mflasc...@wikimedia.org --- Actually, if I'm reading the code right, you don't need to confirm your email for password reset. However, if it's not confirmed, you might have mistyped it, in which case you still effectively won't be able to reset. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 --- Comment #16 from Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org --- Can someone upload a screenshot of the proposed change, rather than just the code changed. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 Dereckson dereck...@espace-win.org changed: What|Removed |Added CC||dereck...@espace-win.org --- Comment #12 from Dereckson dereck...@espace-win.org --- See also : https://gerrit.wikimedia.org/r/#/c/94117/ -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 --- Comment #8 from Andre Klapper aklap...@wikimedia.org --- Please upload updated patches to Gerrit if possible. Please see http://www.mediawiki.org/wiki/Gerrit/Tutorial for how to do so. We do not use Bugzilla to review patches at all. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 94117 had a related patch set uploaded by Gerrit Patch Uploader: Changed the red boxed email and email confirmation options https://gerrit.wikimedia.org/r/94117 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 p858snake p858sn...@gmail.com changed: What|Removed |Added CC||p858sn...@gmail.com --- Comment #10 from p858snake p858sn...@gmail.com --- The second box (Email conformation section) is display when its half done (email entered but not confirmed) so it should probably still be countered as a error and displayed as such. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 --- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 93981 abandoned by Bartosz Dziewoński: Changed the red boxed email and email confirmation options Reason: Superseded by https://gerrit.wikimedia.org/r/94117 . You should submit new patchsets to existing changesets instead of new ones. https://gerrit.wikimedia.org/r/93981 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |mailsto...@gmail.com |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 --- Comment #4 from roopak mailsto...@gmail.com --- Created attachment 13714 -- https://bugzilla.wikimedia.org/attachment.cgi?id=13714action=edit Changed the red boxed email and email confirmation options In MW preferences, email and email confirmation options were given in red boxes indicating error message.In this attachment the red color is removed and the outline color is also changed from red. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 roopak mailsto...@gmail.com changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 roopak mailsto...@gmail.com changed: What|Removed |Added Attachment #13714|0 |1 is obsolete|| --- Comment #5 from roopak mailsto...@gmail.com --- Created attachment 13715 -- https://bugzilla.wikimedia.org/attachment.cgi?id=13715action=edit Changed the red boxed email and email confirmation options In MW preferences, email and email confirmation options were given in red boxes indicating error message.In this attachment the red color is removed and the outline color is also changed from red. //The last patch was incomplete. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 93981 had a related patch set uploaded by Gerrit Patch Uploader: Changed the red boxed email and email confirmation options https://gerrit.wikimedia.org/r/93981 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 roopak mailsto...@gmail.com changed: What|Removed |Added Attachment #13715|0 |1 is obsolete|| --- Comment #7 from roopak mailsto...@gmail.com --- Created attachment 13718 -- https://bugzilla.wikimedia.org/attachment.cgi?id=13718action=edit Changed the red boxed email and email confirmation options In MW preferences, email and email confirmation options were given in red boxes indicating error message.In this attachment the red color is removed and the outline color is also changed from red. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 Tony Thomas 01tonytho...@gmail.com changed: What|Removed |Added CC||01tonytho...@gmail.com --- Comment #1 from Tony Thomas 01tonytho...@gmail.com --- The Email conformation box is ok to be in red, but the email input box need not be. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Low CC||krinklem...@gmail.com, ||matma@gmail.com Component|General/Unknown |Skin and page rendering Version|unspecified |1.23-git -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Keywords||easy --- Comment #2 from Bartosz Dziewoński matma@gmail.com --- The classes which set those colors are .mw-email-not-authenticated and .mw-email-none. This will probably require some simple, but careful adjustments in their definitions in mediawiki.special.preferences.css and/or where they're added to the page in Preferences.php. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56611] Email and Email confirmation options in Preferences should not use red boxes .
https://bugzilla.wikimedia.org/show_bug.cgi?id=56611 roopak mailsto...@gmail.com changed: What|Removed |Added CC||mailsto...@gmail.com --- Comment #3 from roopak mailsto...@gmail.com --- I plan to work on this bug. Kindly do assign me this bug. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
