[Bug 56988] page links in Flow are parsed as relative hrefs, so they break in permalink, history and other views

2013-11-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56988

--- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 96189 merged by jenkins-bot:
Workaround for relative links in /w/index.php

https://gerrit.wikimedia.org/r/96189

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56988] page links in Flow are parsed as relative hrefs, so they break in permalink, history and other views

2013-11-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56988

Erik Bernhardson ebernhard...@wikimedia.org changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56988] page links in Flow are parsed as relative hrefs, so they break in permalink, history and other views

2013-11-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56988

sp...@wikimedia.org changed:

   What|Removed |Added

 CC||b...@mzmcbride.com

--- Comment #4 from sp...@wikimedia.org ---
*** Bug 57161 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56988] page links in Flow are parsed as relative hrefs, so they break in permalink, history and other views

2013-11-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56988

--- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 96189 had a related patch set uploaded by EBernhardson:
Workaround for relative links in /w/index.php

https://gerrit.wikimedia.org/r/96189

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56988] page links in Flow are parsed as relative hrefs, so they break in permalink, history and other views

2013-11-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56988

--- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 95563 abandoned by EBernhardson:
Hackish method of respecting parsoid base href

Reason:
Going a different direction for the temporary fix,
https://gerrit.wikimedia.org/r/96189

https://gerrit.wikimedia.org/r/95563

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56988] page links in Flow are parsed as relative hrefs, so they break in permalink, history and other views

2013-11-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56988

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56988] page links in Flow are parsed as relative hrefs, so they break in permalink, history and other views

2013-11-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56988

--- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 95563 had a related patch set uploaded by EBernhardson:
Hackish method of respecting parsoid base href

https://gerrit.wikimedia.org/r/95563

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56988] page links in Flow are parsed as relative hrefs, so they break in permalink, history and other views

2013-11-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56988

--- Comment #2 from sp...@wikimedia.org ---
On ee-flow labs instance, invoking Parsoid with
   $ curl localhost:8000/localhost/ -d wt='[[Pagename]] here'
produces

...
base href=http://ee-flow.wmflabs.org/wiki/Main Page/
/head
body data-parsoid='{dsr:[0,318,0,0]}'
  p data-parsoid='{dsr:[0,318,0,0]}'
a rel=mw:WikiLink href=./Pagename
data-parsoid='{stx:simple,a:{href:./Pagename},sa:{href:Pagename},dsr:[0,313,2,2]}'Pagename/a
here
  /p
...

Note the base href, which will make the href have the right /wiki/ prefix
regardless of the current URL.
But Flow's parsing of the HTML returned by Parsoid ignores the base href, and
it doesn't set base href in its own HTML HEAD.  Flow could do this (assuming
the base href will be the same for all items in the Flow board),
, or it could parse the HTML, or the the Parsoid API could have an option to
generate full paths.

The HTML for [[Pagename]] on a regular wiki page is an absolute path --
href=/wiki/Pagename , so Parsoid's behavior is different.

Note that some day a user's My active threads Flow board might show
conversations from multiple wikis, so absolute URLs might be useful, some day.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56988] page links in Flow are parsed as relative hrefs, so they break in permalink, history and other views

2013-11-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56988

--- Comment #1 from sp...@wikimedia.org ---
The WMF core features team tracks this bug on Mingle card
https://mingle.corp.wikimedia.org/projects/flow/cards/457, but people from the
community are welcome to contribute here and in Gerrit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l