https://bugzilla.wikimedia.org/show_bug.cgi?id=57731
Web browser: ---
Bug ID: 57731
Summary: Is it a bug? Request for comments/Clarification
request: make SpecialChangePassword form text
depending on login status of $wgUser
Product: MediaWiki
Version: 1.23-git
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: User login and signup
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: m...@tgries.de
CC: swall...@wikimedia.org
Classification: Unclassified
Mobile Platform: ---
make SpecialChangePassword form text depending on login status of $wgUser
During development of Extension:OpenID I found, that I have to apply a small
patch to ChangePassword for the case that I want the pre-login user to enter
their temporary password.
During development of E:OpenID, I found that the SpecialChangePassword shows
the "Temporary password" text only if I apply this patch.
https://gerrit.wikimedia.org/r/#/c/96651/
I suppose, but I am not sure, that this was a design mistake (in the old
version of ChangePassword) to check against the passed parameter $user instead
of (new version) to check against $wgUser.
This is a request for comments.
Chris answered on Patch Set 4: Code-Review-1:
> This seems like the wrong way to accomplish this, and seems like it relies on
> another bug that might disappear.
> I'd rather see this use a parameter to showForm(), or use a flag in the class
> to indicate what wording you want, and then have your code set that.
I still think, that originally $wgUser was meant, perhaps you can ask around.
For my extension OpenID, which calls under certain conditions ChangePassword,
an additional parameter would be fine, in order to trigger the correct label
text "temporary password".
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
