[Bug 58467] Wrong smart keyword on Wikidata
https://bugzilla.wikimedia.org/show_bug.cgi?id=58467 --- Comment #3 from Fomafix foma...@googlemail.com --- There is not bug in Firefox. It converts the inputs in the form to a query string like in HTML. The reason are the two inputs. Why are there two inputs? They seams to be redundant. The implementation on mediawiki.org works with one input. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58467] Wrong smart keyword on Wikidata
https://bugzilla.wikimedia.org/show_bug.cgi?id=58467 --- Comment #4 from Thiemo Mättig thiemo.maet...@wikimedia.de --- Turning an unnamed input into index.php?=%s is clearly a bug in Firefox. I'm not aware of a server side language that supports unnames GET variables. In PHP that would be $_GET['']. I just tried that just to be sure and no, PHP doesn't support this. Again, this doesn't mean we should not work around this issue. See my patch. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58467] Wrong smart keyword on Wikidata
https://bugzilla.wikimedia.org/show_bug.cgi?id=58467 --- Comment #5 from Fomafix foma...@googlemail.com --- Ok, an input without name is ignored in the normal transformation from a form to a query string. Here has the input for which the smart keyword is requested no name. When this input get omitted the query string for the smart keyword would have no %s. ?=%s is a comprehensible query string for the smart keyword on a input without a name. Generating two inputs with the same name is a bad solution for this problem. The right solution is to combine the two inputs to one input. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58467] Wrong smart keyword on Wikidata
https://bugzilla.wikimedia.org/show_bug.cgi?id=58467 --- Comment #1 from Thiemo Mättig thiemo.maet...@wikimedia.de --- Oh, wow. This is clearly a bug in Firefox. You know that, right? Not that we shouldn't work around it. We should. I had two ideas: 1.) Switch the order of the two input, the named hidden input first, our unnamed input after. Result: .../index.php?search==%stitle=Spezial%3ASuche 2.) Give both input the same name=search. Result: .../index.php?search=%ssearch=title=Spezial%3ASuche Dang, this overrides the user's input with an empty string. 3.) Do both. Works. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58467] Wrong smart keyword on Wikidata
https://bugzilla.wikimedia.org/show_bug.cgi?id=58467 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58467] Wrong smart keyword on Wikidata
https://bugzilla.wikimedia.org/show_bug.cgi?id=58467 Lydia Pintscher lydia.pintsc...@wikimedia.de changed: What|Removed |Added Priority|Unprioritized |Normal CC||henning.sna...@wikimedia.de ||, ||lydia.pintscher@wikimedia.d ||e Component|DataValues |WikidataClient Assignee|wikibugs-l@lists.wikimedia. |wikidata-bugs@lists.wikimed |org |ia.org Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
