[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 --- Comment #17 from Krinkle krinklem...@gmail.com --- *** Bug 58364 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 ryasm...@wikimedia.org changed: What|Removed |Added CC||ritu_ree...@yahoo.com --- Comment #16 from ryasm...@wikimedia.org --- *** Bug 68059 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 Alex Monk kren...@wikimedia.org changed: What|Removed |Added Assignee|kren...@wikimedia.org |krinklem...@gmail.com Target Milestone|VE-deploy-2014-06-19|--- -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED Target Milestone|--- |VE-deploy-2014-06-19 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 --- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 140044 merged by jenkins-bot: Media search dialog: Only try to abort request if possible https://gerrit.wikimedia.org/r/140044 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 Krinkle krinklem...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #13 from Krinkle krinklem...@gmail.com --- That patch, as far as I can see, did nothing. And if it did, it would actually have caused a regression. The TypeError thrown is caused by the JSONP script tag request finishing and trying to invoke a temporary global function that jQuery exposed, but has revoked since because the consumer of $.ajax, VisualEditor in this case, has aborted the request. All jqXHR objects have an abort method. Duck-typing it is useless because it is always there. And while JSON-P doesn't have a native abort mechanism, jQuery does a good job of emulating it (it will do a best effort approach to cancel the http request for efficiency reasons, and in case it still makes it, it will make sure it reaches a dead end and not cause our application code to process its data[1]). As I mentioned before, the dead end results in a Uncaught TypeError which sounds bad, but isn't, because it's in an asynchronous and independent call stack that has no influence on either our or jQuery's cod execution. [1] Even if there was a way to not half-abort these requests, we wouldn't want that. We actually want these requests to reach a dead end. Otherwise we'd get race conditions where you type a, ab, abc and after ab is intended to be aborted, it might still arrive *after* abc and mess up our search results. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 Krinkle krinklem...@gmail.com changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |WONTFIX --- Comment #14 from Krinkle krinklem...@gmail.com --- As such, please don't waste any more time on this. This is harmless errors that we can't do anything about and are side-effects of behaviour that is very much intended and wanted by us. Just another one the category of browsers being ugly and/or minor issues upstream. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 --- Comment #15 from Krinkle krinklem...@gmail.com --- Also: * Upstream jQuery: http://bugs.jquery.com/ticket/8744 (status: cantfix) * Closely related upstream Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=707154 (status: NEW) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 Alex Monk kren...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #10 from Alex Monk kren...@wikimedia.org --- I already had InstantCommons enabled, but couldn't reproduce it before. Looks like I can now. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 --- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 140044 had a related patch set uploaded by Alex Monk: Media search dialog: Only try to abort request if possible. https://gerrit.wikimedia.org/r/140044 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 --- Comment #9 from Krinkle krinklem...@gmail.com --- This can be reproduced when using the input field for the Media insertion dialog. E.g. on https://www.mediawiki.org/wiki/VisualEditor/Basic_example_worksheet?veaction=edit It might not throw the error on your local wiki if your wiki is not configured to use a separate wiki, e.g. Wikimedia Commons, as extra file repository. Enable wgUseInstantCommons if you haven't already. https://www.mediawiki.org/wiki/Manual:$wgUseInstantCommons -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 --- Comment #6 from Alex Monk kren...@wikimedia.org --- (In reply to Krinkle from comment #5) This doesn't affect our callstack in any way, and from our perspective it works as expected (after the request is aborted, our callback must not fire). This last part is a jQuery internal implementation detail that might change in the future, but either way, it is out of our hands, doesn't affect anything, and nothing we can do anything about. I'm tempted to wontfix this, but apparently people are complaining that VE is broken because of it. I guess we'll just have to suppress the error. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 --- Comment #7 from Alex Monk kren...@wikimedia.org --- Although I can't actually reproduce this error. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #8 from James Forrester jforres...@wikimedia.org --- Looks like we fixed this – possibly by resetting the search on open? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Assignee|jforrester+veteambztickets@ |kren...@wikimedia.org |wikimedia.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Assignee|krinklem...@gmail.com |jforrester+veteambztickets@ ||wikimedia.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Status|REOPENED|ASSIGNED Assignee|jforres...@wikimedia.org|krinklem...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 Krinkle krinklem...@gmail.com changed: What|Removed |Added Severity|minor |enhancement -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59604] VisualEditor: Console shows TypeError: jQuery_xxxxx is not a function when cross-domain ajax request is aborted
https://bugzilla.wikimedia.org/show_bug.cgi?id=59604 Krinkle krinklem...@gmail.com changed: What|Removed |Added Priority|Unprioritized |Lowest Summary|VisualEditor:TypeError:|VisualEditor: Console shows |jQuery1830683983782510787_1 |TypeError: jQuery_x is |38843220 is not a |not a function when |function appears while |cross-domain ajax request |searching for an image to |is aborted |add in an article | Severity|normal |minor --- Comment #5 from Krinkle krinklem...@gmail.com --- Lowering priority as this is merely a console notice. It doesn't affect anything in any way, it is in fact expected behaviour by jQuery due to there not being another way to do what it does. What it does is cancel a cross-domain ajax request. Short of CORS/XHR, there isn't actually such thing as a cross-domain ajax request. What it really does (and we rely on this) is JSON-P, which is a script tag to the api.php entry point with a temporary function as callback (this is a sort-of standard method called JSON-P which MediaWiki actively supports, it's not a VE intention or a hack beyond what it is). As with many ajax-based content population requests (e.g. search suggestions, auto completion etc.) we abort pending requests when we fire off the next. When interacting with the local API, we use regular XHR which has an abort method. When interacting with a foreign API, jQuery gives us an XHR-like interface but really underneath it is JSON-P, which means there isn't a way to actually abort the request. Instead, jQuery deletes the callback and does a best-effort approach to cancel the request. When the request does come back, it will try to invoke a callback that has already been revoked, which results in a TypeError in the asynchronous callstack of the ajax request. This doesn't affect our callstack in any way, and from our perspective it works as expected (after the request is aborted, our callback must not fire). This last part is a jQuery internal implementation detail that might change in the future, but either way, it is out of our hands, doesn't affect anything, and nothing we can do anything about. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
