[Bug 60078] Logo change between zh-hans, zh-hant, zh-hk... in Wikivoyage Chinese

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60078

Gabriel Chi Hong Lee chihonglee...@gmail.com changed:

   What|Removed |Added

URL||https://zh.wikivoyage.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60078] Logo change between zh-hans, zh-hant, zh-hk... in Wikivoyage Chinese

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60078

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

   Keywords||shell
 CC||aklap...@wikimedia.org,
   ||benap...@gmail.com,
   ||bugzilla+org.wikimedia@tuxm
   ||achine.com,
   ||dereck...@espace-win.org,
   ||g...@wikimedia.org,
   ||tom...@twkozlowski.net,
   ||wikimedia.b...@snowolf.eu
  Component|General/Unknown |Site requests
Product|MediaWiki   |Wikimedia

--- Comment #1 from Andre Klapper aklap...@wikimedia.org ---
[Moving to Wikimedia product as this request is about settings /
configuration of the website, not about the codebase of MediaWiki itself.]

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60078] Logo change between zh-hans, zh-hant, zh-hk... in Wikivoyage Chinese

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60078

Tomasz W. Kozlowski tom...@twkozlowski.net changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Tomasz W. Kozlowski tom...@twkozlowski.net ---
I don't think this is a Bugzilla bug; the Chinese Wikipedia appears to be using
some sort of JavaScript to present different logos per different language
variants.

I haven't been able to find anything in [[zh:MediaWiki:Common.js]], so I think
it's cleverly hidden in some gadget; please contact the Chinese Wikipedia
community for help.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60078] Logo change between zh-hans, zh-hant, zh-hk... in Wikivoyage Chinese

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60078

Byfserag john_k...@sina.cn changed:

   What|Removed |Added

 CC||john_k...@sina.cn

--- Comment #3 from Byfserag john_k...@sina.cn ---
(In reply to comment #2)
 I don't think this is a Bugzilla bug; the Chinese Wikipedia appears to be
 using
 some sort of JavaScript to present different logos per different language
 variants.
 
 I haven't been able to find anything in [[zh:MediaWiki:Common.js]], so I
 think
 it's cleverly hidden in some gadget; please contact the Chinese Wikipedia
 community for help.

No,it isn't.
https://git.wikimedia.org/blob/operations%2Fmediawiki-config/9c822a18d0382d8943691fe76405d8bc7f292161/wmf-config%2FInitialiseSettings.php#L637
 

https://git.wikimedia.org/blob/operations%2Fmediawiki-config/9c822a18d0382d8943691fe76405d8bc7f292161/wmf-config%2FInitialiseSettings.php#L920

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60078] Logo change between zh-hans, zh-hant, zh-hk... in Wikivoyage Chinese

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60078

Tomasz W. Kozlowski tom...@twkozlowski.net changed:

   What|Removed |Added

 Status|RESOLVED|PATCH_TO_REVIEW
 Resolution|INVALID |---
 Ever confirmed|0   |1

--- Comment #4 from Tomasz W. Kozlowski tom...@twkozlowski.net ---
True; we'd need to change the logo to $stdlogo first. Thanks for catching this!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60078] Logo change between zh-hans, zh-hant, zh-hk... in Wikivoyage Chinese

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60078

--- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 107566 had a related patch set uploaded by Odder:
Enable setting logo per language variant on zh.voy

https://gerrit.wikimedia.org/r/107566

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60078] Logo change between zh-hans, zh-hant, zh-hk... in Wikivoyage Chinese

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60078

Tomasz W. Kozlowski tom...@twkozlowski.net changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
   Assignee|wikibugs-l@lists.wikimedia. |tom...@twkozlowski.net
   |org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60078] Logo change between zh-hans, zh-hant, zh-hk... in Wikivoyage Chinese

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60078

--- Comment #8 from Liangent liang...@gmail.com ---
(In reply to comment #7)
 No shit.

What?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60078] Logo change between zh-hans, zh-hant, zh-hk... in Wikivoyage Chinese

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60078

Liangent liang...@gmail.com changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 CC||liang...@gmail.com
 Resolution|--- |INVALID

--- Comment #6 from Liangent liang...@gmail.com ---
This can't be done in PHP. $stdlogo refers to Wiki.png on site. Ctrl+F for
#p-logo in zhwiki's MediaWiki:Common.css.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60078] Logo change between zh-hans, zh-hant, zh-hk... in Wikivoyage Chinese

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60078

Tomasz W. Kozlowski tom...@twkozlowski.net changed:

   What|Removed |Added

 Status|RESOLVED|PATCH_TO_REVIEW
 Resolution|INVALID |---

--- Comment #7 from Tomasz W. Kozlowski tom...@twkozlowski.net ---
No shit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60078] Logo change between zh-hans, zh-hant, zh-hk... in Wikivoyage Chinese

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60078

--- Comment #9 from Liangent liang...@gmail.com ---
To clarify, that patch doesn't do what it claims by enable the community to
set different logos per language variant (zh-hans, zh-hant, etc.). This is not
required by the hack used on zhwiki. If using $stdlogo is expected for easier
logo change in the future, that patch works.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60078] Logo change between zh-hans, zh-hant, zh-hk... in Wikivoyage Chinese

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60078

Tomasz W. Kozlowski tom...@twkozlowski.net changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #11 from Tomasz W. Kozlowski tom...@twkozlowski.net ---
Turns out they use CSS[1] for it, not JavaScript as I thought, so they can do
with a pre-defined logo.

* [1] https://zh.wikipedia.org/wiki/MediaWiki:Common.css

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60078] Logo change between zh-hans, zh-hant, zh-hk... in Wikivoyage Chinese

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60078

--- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 107566 abandoned by Odder:
Enable setting logo per language variant on zh.voy

https://gerrit.wikimedia.org/r/107566

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l