[Bug 60660] Mediawiki.ui buttons: long text strings overflow button container
https://bugzilla.wikimedia.org/show_bug.cgi?id=60660 --- Comment #6 from Maryana Pinchuk mpinc...@wikimedia.org --- This disappeared for awhile in Flow, but it seems to have resurfaced on our Labs test wiki. See the first topic title here: http://ee-flow.wmflabs.org/wiki/User_talk:Maryana Not sure if the code there is out of date or if this bug is back. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60660] Mediawiki.ui buttons: long text strings overflow button container
https://bugzilla.wikimedia.org/show_bug.cgi?id=60660 --- Comment #7 from Matthew Flaschen mflasc...@wikimedia.org --- ee-flow is now on 1.23wmf12, which is no longer deployed to any WMF wiki. The fix is deployed to all WMF wikis. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60660] Mediawiki.ui buttons: long text strings overflow button container
https://bugzilla.wikimedia.org/show_bug.cgi?id=60660 --- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 110696 merged by jenkins-bot: mediawiki.ui: Remove white-space: nowrap; for buttons https://gerrit.wikimedia.org/r/110696 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60660] Mediawiki.ui buttons: long text strings overflow button container
https://bugzilla.wikimedia.org/show_bug.cgi?id=60660 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60660] Mediawiki.ui buttons: long text strings overflow button container
https://bugzilla.wikimedia.org/show_bug.cgi?id=60660 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|wikibugs-l@lists.wikimedia. |matma@gmail.com |org | Target Milestone|--- |1.23.0 release --- Comment #3 from Bartosz Dziewoński matma@gmail.com --- (In reply to comment #0) We're using the mediawiki.ui button class for the Flow topic header area (for now, anyway), and this is what happens when the topic title text is too long: https://www.mediawiki.org/w/index.php?title=Talk: Flowtopic%5BpostId%5D=050f54b98b3d662828ca90b11c28d444workflow=050f54b98b3d 662828ca90b11c28d444 This is truly an incredible abuse of the button class, and clearly a very bad idea given how many issues it causes (I've seen a few other mentions apart from this bug). Still, the white-space: nowrap is inappropriate. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60660] Mediawiki.ui buttons: long text strings overflow button container
https://bugzilla.wikimedia.org/show_bug.cgi?id=60660 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 110696 had a related patch set uploaded by Bartosz Dziewoński: mediawiki.ui: Remove white-space: nowrap; for buttons https://gerrit.wikimedia.org/r/110696 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60660] Mediawiki.ui buttons: long text strings overflow button container
https://bugzilla.wikimedia.org/show_bug.cgi?id=60660 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60660] Mediawiki.ui buttons: long text strings overflow button container
https://bugzilla.wikimedia.org/show_bug.cgi?id=60660 sp...@wikimedia.org changed: What|Removed |Added CC||sp...@wikimedia.org --- Comment #2 from sp...@wikimedia.org --- I thought perhaps white-space: nowrap is there to stop a mw-ui-button wrapping onto a new line, but in Firefox mw-ui-button's display:inline-block keeps that from happening without a white-space setting, even if you style a span: span class=mw-ui-buttonThis is a lot of text that should stay together/span If there's a reason for nowrap, please add a comment to buttons.less -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60660] Mediawiki.ui buttons: long text strings overflow button container
https://bugzilla.wikimedia.org/show_bug.cgi?id=60660 --- Comment #1 from Matthew Flaschen mflasc...@wikimedia.org --- This is because of the: white-space: nowrap; We also had to override this in GettingStarted (GettingStarted has overrides for other reasons, e.g. icons, but the buttons are still generally button-looking). I'm not sure if the 'nowrap' is necessary in other scenarios. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
