[Bug 62078] Infinite loop in MobileContext-toggleView('mobile')

2014-02-28 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=62078

--- Comment #1 from Bingle bingle-ad...@wikimedia.org ---
Prioritization and scheduling of this bug is tracked on Mingle card
https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1740

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 62078] Infinite loop in MobileContext-toggleView('mobile')

2014-02-28 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=62078

Max Semenik maxsem.w...@gmail.com changed:

   What|Removed |Added

   Priority|Unprioritized   |Immediate
   Severity|normal  |blocker

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 62078] Infinite loop in MobileContext-toggleView('mobile')

2014-02-28 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=62078

--- Comment #3 from Arthur Richards aricha...@wikimedia.org ---
I am not seeing the behavior on wikipedias. I believe this was introduced by
https://gerrit.wikimedia.org/r/#/c/114392/1

The scope of this problem theoretically ought to be small, since URLs that
trigger  this behavior are not being exposed anywhere (at least that I could
find). Bryan, do you have any way of confirming that the scope here is
relatively small?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 62078] Infinite loop in MobileContext-toggleView('mobile')

2014-02-28 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=62078

--- Comment #2 from Arthur Richards aricha...@wikimedia.org ---
Huh -
http://test2.wikipedia.org/w/index.php?title=Template:Orphanaction=editmo
bileaction=toggle_view_mobile is not a URL that should ever get exposed, and
from poking around I can't figure out where this would have come from. URLs
with 'mobileaction=toggle_view_mobile' should only ever appear on wikis that do
not have a mobile-specific subdomain configured. I wonder if someone created
this manually. Regardless, the infinite loop should not be happening and I
suspect it's happening because MobileFrontend does not expect to see
mobileaction=toggle_view_mobile on a wiki with a mobile-specific subdomain. I
am digging into it now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 62078] Infinite loop in MobileContext-toggleView('mobile')

2014-02-28 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=62078

--- Comment #4 from Bryan Davis bda...@wikimedia.org ---
It does not seem to be widespread yet, but the 1.23wmf16 branch is only on the
group 0 wikis at the moment.

fluorine:~
bd808$ fgrep toggle_view_mobile /a/mw-log/*.log
/a/mw-log/api.log:2014-02-28 17:08:28 mw1120 enwiki: API POST 10.64.32.73
10.64.32.73 T=52ms format=json action=parse
text=%3Csyntaxhighlight%20lang%3D%22javascript%22%3E%0A$(%27a%5Bhref$%3D%22toggle_view_mobile%22%5D%27).click(function()%7B%0A%20%20%20%20%20%20%20document.cookie%20%3D%20%27stopMobileRedirect%3Dfalse;%20domain%3D.wikipedia.org;%27%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%2B%20%27path%3D/;%20expires%3DThu,%2001-Jan-1970%2000:00:00%20GMT;%27;%0A%7D);%0A%3C/syntaxhigh[...]
disablepp=true
/a/mw-log/api.log:2014-02-28 17:08:28 mw1129 enwiki: API POST 10.64.32.73
10.64.32.73 T=79ms format=json action=parse
text=%3Csyntaxhighlight%20lang%3D%22javascript%22%3E%0A$(%27a%5Bhref$%3D%22toggle_view_mobile%22%5D%27).click(function()%7B%0A%20%20%20%20%20%20%20$.cookie(%27stopMobileRedirect%27,%27false%27,%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%7B%20domain:%20%27.wikipedia.org%27,%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20path:%20%27/%27,%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20expires:%20%27Thu,%2001-Jan-1970%2000:[...]
disablepp=true
/a/mw-log/fatal.log:URL:
http://test2.wikipedia.org/w/index.php?title=Template:Orphanaction=editmobileaction=toggle_view_mobile
/a/mw-log/fatal.log:URL:
http://test2.wikipedia.org/w/index.php?title=Bahrainaction=editmobileaction=toggle_view_mobile
/a/mw-log/fatal.log:URL:
http://test2.wikipedia.org/w/index.php?title=Kyrgyzstanaction=editmobileaction=toggle_view_mobile
/a/mw-log/fatal.log:URL:
http://test2.wikipedia.org/w/index.php?title=Talk:Nepalaction=editredlink=1mobileaction=toggle_view_mobile
/a/mw-log/fatal.log:URL:
http://test2.wikipedia.org/w/index.php?title=Ruleaction=editredlink=1mobileaction=toggle_view_mobile
/a/mw-log/fatal.log:URL:
http://test2.wikipedia.org/w/index.php?title=Bluebookaction=editredlink=1mobileaction=toggle_view_mobile
/a/mw-log/fatal.log:URL:
http://test2.wikipedia.org/w/index.php?title=User:RobLa-WMFmobileaction=toggle_view_mobile
/a/mw-log/fatal.log:URL:
http://test2.wikipedia.org/w/index.php?title=Justiceaction=editredlink=1mobileaction=toggle_view_mobile
/a/mw-log/fatal.log:URL:
http://test2.wikipedia.org/w/index.php?title=Template:Orphanaction=editmobileaction=toggle_view_mobile
/a/mw-log/fatal.log:URL:
http://www.mediawiki.org/w/index.php?title=Template:Orphanaction=editmobileaction=toggle_view_mobile
/a/mw-log/test2wiki.log:Start request GET
/w/index.php?title=Special:UserLogintype=signupreturnto=Chris+Montezreturntoquery=action%3Dedit%26redlink%3D1%26mobileaction%3Dtoggle_view_mobile
/a/mw-log/test2wiki.log:20140228084840  0.123  
/w/index.php?title=Special:UserLogintype=signupreturnto=Chris
Montezreturntoquery=action=editredlink=1mobileaction=toggle_view_mobile 
(proxied via 10.64.0.102 forwarded for 137.110.244.134, 10.128.0.116,
10.128.0.109) anon
/a/mw-log/test2wiki.log:Start request GET
/w/index.php?title=Template:Orphanaction=editmobileaction=toggle_view_mobile
/a/mw-log/test2wiki.log:Start request GET
/w/index.php?title=Special:UserLoginreturnto=Maggie+May+%28traditional+song%29returntoquery=action%3Dedit%26mobileaction%3Dtoggle_view_mobiletype=signup
/a/mw-log/test2wiki.log:20140228110135  0.154  
/w/index.php?title=Special:UserLoginreturnto=Maggie May (traditional
song)returntoquery=action=editmobileaction=toggle_view_mobiletype=signup
  (proxied via 10.64.32.107 forwarded for 137.110.244.139, 10.128.0.110,
10.128.0.108) anon
/a/mw-log/test2wiki.log:Start request GET
/w/index.php?title=Bahrainaction=editmobileaction=toggle_view_mobile
/a/mw-log/test2wiki.log:Start request GET
/w/index.php?title=Kyrgyzstanaction=editmobileaction=toggle_view_mobile
/a/mw-log/test2wiki.log:Start request GET
/w/index.php?title=Special:UserLoginreturnto=Talk%3AAlbumreturntoquery=action%3Dedit%26redlink%3D1%26mobileaction%3Dtoggle_view_mobiletype=signup
/a/mw-log/test2wiki.log:20140228122857  0.101  
/w/index.php?title=Special:UserLoginreturnto=Talk:Albumreturntoquery=action=editredlink=1mobileaction=toggle_view_mobiletype=signup
   (proxied via 10.64.0.103 forwarded for 137.110.244.139, 10.128.0.118,
10.128.0.110) anon
/a/mw-log/test2wiki.log:Start request GET
/w/index.php?title=Talk:Nepalaction=editredlink=1mobileaction=toggle_view_mobile
/a/mw-log/test2wiki.log:Start request GET
/w/index.php?title=Ruleaction=editredlink=1mobileaction=toggle_view_mobile
/a/mw-log/test2wiki.log:Start request GET
/w/index.php?title=Bluebookaction=editredlink=1mobileaction=toggle_view_mobile
/a/mw-log/test2wiki.log:Start request GET
/w/index.php?title=User:RobLa-WMFmobileaction=toggle_view_mobile
/a/mw-log/test2wiki.log:Start request GET

[Bug 62078] Infinite loop in MobileContext-toggleView('mobile')

2014-02-28 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=62078

--- Comment #5 from Arthur Richards aricha...@wikimedia.org ---
Alright, I can't gracefully fix this without some consultation from the Zero
team, so the change that introduced this bug is reverted (but not deployed):
https://gerrit.wikimedia.org/r/#/c/116174/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 62078] Infinite loop in MobileContext-toggleView('mobile')

2014-02-28 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=62078

Arthur Richards aricha...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Arthur Richards aricha...@wikimedia.org ---
Merged, deployed. All seems OK now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l