[Bug 62172] VisualEditor: [Regression pre-wmf17] Getting Your edit may have been corrupted – please review before saving message when page contains gallery/formula

2014-03-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62172

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|RESOLVED|PATCH_TO_REVIEW
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62172] VisualEditor: [Regression pre-wmf17] Getting Your edit may have been corrupted – please review before saving message when page contains gallery/formula

2014-03-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62172

--- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 117445 had a related patch set uploaded by Catrope:
Work around DOM corruption for default-sized images

https://gerrit.wikimedia.org/r/117445

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62172] VisualEditor: [Regression pre-wmf17] Getting Your edit may have been corrupted – please review before saving message when page contains gallery/formula

2014-03-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62172

--- Comment #6 from ryasm...@wikimedia.org ---
Verified the fix on betalabs  on this page:
http://en.wikipedia.beta.wmflabs.org/wiki/Editcorrupted

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62172] VisualEditor: [Regression pre-wmf17] Getting Your edit may have been corrupted – please review before saving message when page contains gallery/formula

2014-03-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62172

--- Comment #7 from ryasm...@wikimedia.org ---
verified the fix on test2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62172] VisualEditor: [Regression pre-wmf17] Getting Your edit may have been corrupted – please review before saving message when page contains gallery/formula

2014-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62172

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

   Priority|Unprioritized   |High
   Assignee|jforrester+veteambztickets@ |roan.katt...@gmail.com
   |wikimedia.org   |
Summary|VisualEditor: Getting   |VisualEditor: [Regression
   |Your edit may have been|pre-wmf17] Getting  Your
   |corrupted – please review   |edit may have been
   |before saving message  |corrupted – please review
   |frequently in Betalabs  |before saving message when
   ||page contains
   ||gallery/formula

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62172] VisualEditor: [Regression pre-wmf17] Getting Your edit may have been corrupted – please review before saving message when page contains gallery/formula

2014-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62172

Roan Kattouw roan.katt...@gmail.com changed:

   What|Removed |Added

 CC||roan.katt...@gmail.com

--- Comment #3 from Roan Kattouw roan.katt...@gmail.com ---
This is not because of galleries of formulas, but because of Moriel's fixes for
default images sizes in the DM. So it manifests only for images with default
size.

The corruption occurs because the default image size fixes overwrite Parsoid's
width/height (which is reasonable) but then also send the overwritten values
back to Parsoid (which is not reasonable). We should store the original values
and send those back in the HTML unless the user changed something.

Additionally, the default size fixes are causing us to incorrectly size images
whose original size is less than 220px. An 16x16px icon, for instance, is 16x16
even though the default bounding box is 220, because default sizing never grows
an image above its original size. In this case Parsoid's width/height are
actually correct, but we overwrite that with the default size, and so 16x16px
icons end up rendering as 220x220px in VE and look horribly pixelated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62172] VisualEditor: [Regression pre-wmf17] Getting Your edit may have been corrupted – please review before saving message when page contains gallery/formula

2014-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62172

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62172] VisualEditor: [Regression pre-wmf17] Getting Your edit may have been corrupted – please review before saving message when page contains gallery/formula

2014-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62172

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

   Target Milestone|--- |VE-deploy-2014-03-06

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62172] VisualEditor: [Regression pre-wmf17] Getting Your edit may have been corrupted – please review before saving message when page contains gallery/formula

2014-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62172

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|ASSIGNED|PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62172] VisualEditor: [Regression pre-wmf17] Getting Your edit may have been corrupted – please review before saving message when page contains gallery/formula

2014-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62172

--- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 117144 had a related patch set uploaded by Catrope:
Work around DOM corruption for default-sized images

https://gerrit.wikimedia.org/r/117144

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62172] VisualEditor: [Regression pre-wmf17] Getting Your edit may have been corrupted – please review before saving message when page contains gallery/formula

2014-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62172

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62172] VisualEditor: [Regression pre-wmf17] Getting Your edit may have been corrupted – please review before saving message when page contains gallery/formula

2014-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62172

--- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 117144 merged by jenkins-bot:
Work around DOM corruption for default-sized images

https://gerrit.wikimedia.org/r/117144

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l