[Bug 62469] MultimediaViewer should have img fallback if XMLHttpRequest fails

2014-03-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62469

--- Comment #1 from Tisza Gergő gti...@wikimedia.org ---
We do have an img fallback, but it sets img.crossOrigin = true on certain
browsers where the fallback would otherwise result in downloading the image
twice. Just to be sure that is really the cause of the problem, is there a
public wiki where this bug can be reproduced?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62469] MultimediaViewer should have img fallback if XMLHttpRequest fails

2014-03-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62469

--- Comment #2 from George Barnick george.barn...@brickcraft.me ---
(In reply to Tisza Gergő from comment #1)
 We do have an img fallback, but it sets img.crossOrigin = true on certain
 browsers where the fallback would otherwise result in downloading the image
 twice. Just to be sure that is really the cause of the problem, is there a
 public wiki where this bug can be reproduced?

Yes, here is an example: http://dev.brickimedia.org/wiki/VisualEditor You'll
have to make an account so you can enable it in Beta Features (I think) but
that only takes a minute or so.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62469] MultimediaViewer should have img fallback if XMLHttpRequest fails

2014-03-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62469

--- Comment #3 from Tisza Gergő gti...@wikimedia.org ---
Tracked in Mingle as
https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/295

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62469] MultimediaViewer should have img fallback if XMLHttpRequest fails

2014-03-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62469

Tisza Gergő gti...@wikimedia.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Severity|enhancement |major

--- Comment #4 from Tisza Gergő gti...@wikimedia.org ---
Contents of the console:

XMLHttpRequest cannot load http://images.brickimedia.org/7/7d/Goodship1.jpg. No
'Access-Control-Allow-Origin' header is present on the requested resource.
Origin 'http://dev.brickimedia.org' is therefore not allowed access. 

Uncaught TypeError: Cannot read property 'length' of null
mmv.provider.Image.js:93
Image.binaryToDataURI mmv.provider.Image.js:93
(anonymous function) mmv.provider.Image.js:73
(...)
request.onreadystatechange mmv.performance.js:71

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62469] MultimediaViewer should have img fallback if XMLHttpRequest fails

2014-03-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62469

--- Comment #5 from Tisza Gergő gti...@wikimedia.org ---
George: the MultimediaViewer version you use is outdated, the current version
loads images differently. Do you want to give a shot at updating to the current
version? (The tip of the 1.23wmf17 branch should be a safe choice.)

I expect it will still fail, but for an entirely different reason, and that
will be easy to fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62469] MultimediaViewer should have img fallback if XMLHttpRequest fails

2014-03-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62469

Tisza Gergő gti...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #6 from Tisza Gergő gti...@wikimedia.org ---
For now I am setting this back to unconfirmed, most of the image loading code
has been replaced since then.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62469] MultimediaViewer should have img fallback if XMLHttpRequest fails

2014-03-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62469

--- Comment #7 from George Barnick george.barn...@brickcraft.me ---
(In reply to Tisza Gergő from comment #5)
 George: the MultimediaViewer version you use is outdated, the current
 version loads images differently. Do you want to give a shot at updating to
 the current version? (The tip of the 1.23wmf17 branch should be a safe
 choice.)
 
 I expect it will still fail, but for an entirely different reason, and that
 will be easy to fix.

Alright, I updated the extension. It works and does have the fallback, but the
fallback also blurs the image a lot. I know why it's doing that, but maybe
should it not upscale the img tag bigger than the image's thumbnail was?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l