[Bug 62550] vagrant destroy && vagrant up doesn't trigger the needs_update field of mediawiki::extension

2014-07-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62550

--- Comment #3 from Gerrit Notification Bot  ---
Change 146002 merged by jenkins-bot:
Purge puppet created files on host when destroying

https://gerrit.wikimedia.org/r/146002

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62550] vagrant destroy && vagrant up doesn't trigger the needs_update field of mediawiki::extension

2014-07-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62550

Bryan Davis  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62550] vagrant destroy && vagrant up doesn't trigger the needs_update field of mediawiki::extension

2014-07-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62550

--- Comment #2 from Gerrit Notification Bot  ---
Change 146002 had a related patch set uploaded by BryanDavis:
Purge puppet created files on host when destroying

https://gerrit.wikimedia.org/r/146002

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62550] vagrant destroy && vagrant up doesn't trigger the needs_update field of mediawiki::extension

2014-07-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62550

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62550] vagrant destroy && vagrant up doesn't trigger the needs_update field of mediawiki::extension

2014-07-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62550

Bryan Davis  changed:

   What|Removed |Added

 CC||bda...@wikimedia.org

--- Comment #1 from Bryan Davis  ---
This happens because the Exec['update database'] puppet step only happens when
the contents of the extension specific settings file change. In the given
workflow, the puppet run triggered by the second `vagrant up` command will
check settings.d/puppet-managed/10-Flow.php and find that the current file on
disk has the correct sha1 and thus not fire the notify event that triggers the
database update.

It should be possible to use the vagrant plugin API's `action_hook` call as
part of the MediaWiki-Vagrant plugin to install a routine to run following
`vagrant destroy` that would clean up the various puppet-managed settings files
in settings.d. This would mimic the manual `rm` of the extension settings.

I have a `dist-clean.sh` script that I use to reset the Vagrant environment
that I use for testing pending gerrit commits which does something similar:

#!/usr/bin/env bash
set -e
vagrant destroy -f
rm settings.d/puppet-managed/*
git checkout -- settings.d/puppet-managed/README
rm -rf settings.d/multiwiki/
rm -rf puppet/manifests/manifests.d/vagrant-managed.pp
rm -rf .settings.yaml

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l