[Bug 63108] Declaration of NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beginRecentChangesList($res)
https://bugzilla.wikimedia.org/show_bug.cgi?id=63108 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from Bartosz Dziewoński matma@gmail.com --- This looks rather fixed to me, marking as such. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63108] Declaration of NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beginRecentChangesList($res)
https://bugzilla.wikimedia.org/show_bug.cgi?id=63108 Nemo federicol...@tiscali.it changed: What|Removed |Added Priority|Unprioritized |Highest CC||aude.w...@gmail.com, ||ebernhard...@wikimedia.org, ||matma@gmail.com --- Comment #1 from Nemo federicol...@tiscali.it --- Caused by I28d4e41437e485e518f2a23b6da00cdc430a8c23 There is https://gerrit.wikimedia.org/r/#/c/121046/ but I doubt it's appropriate to break compatibility like this, opinions? I left it in MediaWikiGeneral for now. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63108] Declaration of NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beginRecentChangesList($res)
https://bugzilla.wikimedia.org/show_bug.cgi?id=63108 --- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 121046 had a related patch set uploaded by Nemo bis: Update beginRecentChangesList to fix php strict standard notice https://gerrit.wikimedia.org/r/121046 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63108] Declaration of NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beginRecentChangesList($res)
https://bugzilla.wikimedia.org/show_bug.cgi?id=63108 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63108] Declaration of NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beginRecentChangesList($res)
https://bugzilla.wikimedia.org/show_bug.cgi?id=63108 Nemo federicol...@tiscali.it changed: What|Removed |Added Keywords||code-update-regression Target Milestone|--- |1.23.0 release -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63108] Declaration of NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beginRecentChangesList($res)
https://bugzilla.wikimedia.org/show_bug.cgi?id=63108 --- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 121046 abandoned by Aude: Update beginRecentChangesList to fix php strict standard notice https://gerrit.wikimedia.org/r/121046 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63108] Declaration of NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beginRecentChangesList($res)
https://bugzilla.wikimedia.org/show_bug.cgi?id=63108 Nemo federicol...@tiscali.it changed: What|Removed |Added Component|General/Unknown |Recent changes -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63108] Declaration of NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beginRecentChangesList($res)
https://bugzilla.wikimedia.org/show_bug.cgi?id=63108 Nemo federicol...@tiscali.it changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63108] Declaration of NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beginRecentChangesList($res)
https://bugzilla.wikimedia.org/show_bug.cgi?id=63108 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added CC||g...@wikimedia.org --- Comment #4 from Andre Klapper aklap...@wikimedia.org --- ebernhardson: Could you take a look at this please? Patch abandoned (considered wrong place); resetting bug status to NEW. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63108] Declaration of NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beginRecentChangesList($res)
https://bugzilla.wikimedia.org/show_bug.cgi?id=63108 --- Comment #5 from Nemo federicol...@tiscali.it --- Reverted: I1851e23e186ba7aaeb001ba212e56888657a3ae0 Technically fixed, can stay open until Erik and Matthias have a chance to comment on what other path they'll take. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63108] Declaration of NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beginRecentChangesList($res)
https://bugzilla.wikimedia.org/show_bug.cgi?id=63108 --- Comment #6 from Siebrand Mazeland siebr...@kitano.nl --- (In reply to Nemo from comment #5) Reverted: I1851e23e186ba7aaeb001ba212e56888657a3ae0 Technically fixed, can stay open until Erik and Matthias have a chance to comment on what other path they'll take. I'd suggest having working defaults when adding parameters to a function. AFAIK this is common practice. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63108] Declaration of NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beginRecentChangesList($res)
https://bugzilla.wikimedia.org/show_bug.cgi?id=63108 --- Comment #7 from Erik Bernhardson ebernhard...@wikimedia.org --- Taking another stab at this, next implementation is If74ae600ffba949364dd381dd3d466cbbaa27286 which shouldn't effect any existing implementations or consumers. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63108] Declaration of NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beginRecentChangesList($res)
https://bugzilla.wikimedia.org/show_bug.cgi?id=63108 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Highest |High -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l