[Bug 63119] WTS: 5 quotes
https://bugzilla.wikimedia.org/show_bug.cgi?id=63119 C. Scott Ananian canan...@wikimedia.org changed: What|Removed |Added Assignee|gwi...@wikimedia.org|ssas...@wikimedia.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63119] WTS: 5 quotes
https://bugzilla.wikimedia.org/show_bug.cgi?id=63119
--- Comment #1 from ssas...@wikimedia.org ---
This seems like a bug in the front-end tokenizer, not the serializer (which
serializes the html just fine).
[subbu@earth lib] echo pbi/i/b/p | node parse --html2wt | node
parse --trace peg-tokens
trace/peg-tokens : TOKS:
[',{type:SelfclosingTagTk,name:mw-quote,attribs:[],dataAttribs:{tsr:[5,10]},value:'}]
The first 5 quotes are tokenized as a plain string rather than as a mw-quote
token.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63119] WTS: 5 quotes
https://bugzilla.wikimedia.org/show_bug.cgi?id=63119 --- Comment #2 from C. Scott Ananian canan...@wikimedia.org --- Another case: $ echo ''foo' | tests/parse.js --normalize=parsoid bodypifoo/ib/b/p/body $ echo pifoo/ib/b/p | parse.js --html2html --normalize=parsoid bodypifoo'''/ib/b/p/body This is the Italics and bold: 2-quote opening sequence: (2,5+3) test case. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63119] WTS: 5 quotes
https://bugzilla.wikimedia.org/show_bug.cgi?id=63119 --- Comment #3 from ssas...@wikimedia.org --- I am not sure how much effort we should invest in preserving html2html for empty quote nodes as in these examples. But, that said, one way to fix bi/i/b is to insert a nowiki/ in the empty node to break the quote block. 'nowiki/'. This will still not preserve html2html exactly, but it will preserve semantics. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63119] WTS: 5 quotes
https://bugzilla.wikimedia.org/show_bug.cgi?id=63119 --- Comment #4 from C. Scott Ananian canan...@wikimedia.org --- In the case in comment 2: $ echo pifoo/ib/b/p | tests/parse.js --html2wt ''foo $ echo ''foo | tests/parse.js --normalize bodypifoo'''/ib/b/p/body $ echo ''foo | php maintenance/parse.php pifoo'''/i /p But: $ echo ''foo'nowiki/''' | tests/parse.js --normalize bodypifoo/ibmeta//b/p/body $ echo ''foo'nowiki/''' | php maintenance/parse.php pifoo/i /p So it does seem like our WTS should insert the nowiki/ node there to preserve the semantics of the HTML. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63119] WTS: 5 quotes
https://bugzilla.wikimedia.org/show_bug.cgi?id=63119 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63119] WTS: 5 quotes
https://bugzilla.wikimedia.org/show_bug.cgi?id=63119 C. Scott Ananian canan...@wikimedia.org changed: What|Removed |Added Assignee|ssas...@wikimedia.org |canan...@wikimedia.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63119] WTS: 5 quotes
https://bugzilla.wikimedia.org/show_bug.cgi?id=63119 --- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 121141 had a related patch set uploaded by Cscott: Fix WTS of empty quote nodes. https://gerrit.wikimedia.org/r/121141 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63119] WTS: 5 quotes
https://bugzilla.wikimedia.org/show_bug.cgi?id=63119 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 121141 merged by jenkins-bot: Fix WTS of empty quote nodes. https://gerrit.wikimedia.org/r/121141 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63119] WTS: 5 quotes
https://bugzilla.wikimedia.org/show_bug.cgi?id=63119 ssas...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
