[Bug 64525] MediaViewer fails in Internet Explorer 11 with error about localStorage.getItem being null

2014-05-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64525

se4598 se4...@se4598.eu changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64525] MediaViewer fails in Internet Explorer 11 with error about localStorage.getItem being null

2014-04-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64525

--- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 130230 merged by jenkins-bot:
Handle window.localStorage === null case correctly.

https://gerrit.wikimedia.org/r/130230

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64525] MediaViewer fails in Internet Explorer 11 with error about localStorage.getItem being null

2014-04-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64525

Gilles Dubuc gdu...@wikimedia.org changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 CC||gdu...@wikimedia.org
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64525] MediaViewer fails in Internet Explorer 11 with error about localStorage.getItem being null

2014-04-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64525

--- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 130494 had a related patch set uploaded by Gergő Tisza:
Handle window.localStorage === null case correctly.

https://gerrit.wikimedia.org/r/130494

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64525] MediaViewer fails in Internet Explorer 11 with error about localStorage.getItem being null

2014-04-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64525

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|RESOLVED|PATCH_TO_REVIEW
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64525] MediaViewer fails in Internet Explorer 11 with error about localStorage.getItem being null

2014-04-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64525

--- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 130493 had a related patch set uploaded by Gergő Tisza:
Handle window.localStorage === null case correctly.

https://gerrit.wikimedia.org/r/130493

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64525] MediaViewer fails in Internet Explorer 11 with error about localStorage.getItem being null

2014-04-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64525

--- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 130493 merged by jenkins-bot:
Handle window.localStorage === null case correctly.

https://gerrit.wikimedia.org/r/130493

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64525] MediaViewer fails in Internet Explorer 11 with error about localStorage.getItem being null

2014-04-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64525

--- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 130494 merged by jenkins-bot:
Handle window.localStorage === null case correctly.

https://gerrit.wikimedia.org/r/130494

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64525] MediaViewer fails in Internet Explorer 11 with error about localStorage.getItem being null

2014-04-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64525

Tisza Gergő gti...@wikimedia.org changed:

   What|Removed |Added

Summary|MediaViewer fails in|MediaViewer fails in
   |Internet Explorer 11 and|Internet Explorer 11 with
   |also doesn't degrade nicely |error about
   ||localStorage.getItem being
   ||null

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64525] MediaViewer fails in Internet Explorer 11 with error about localStorage.getItem being null

2014-04-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64525

--- Comment #3 from Tisza Gergő gti...@wikimedia.org ---
Apparently when localStorage is disabled (about:config dom.storage.enabled in
Firefox, don't know about IE), it is null, not undefined, so the test fails:
https://github.com/openstreetmap/iD/issues/591
We should just for truthiness instead.

Tracked as
https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/521

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64525] MediaViewer fails in Internet Explorer 11 with error about localStorage.getItem being null

2014-04-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64525

Umherirrender umherirrender_de...@web.de changed:

   What|Removed |Added

 CC||umherirrender_de...@web.de

--- Comment #4 from Umherirrender umherirrender_de...@web.de ---
Looks similar to gerrit 129245 (for CentralAuth)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64525] MediaViewer fails in Internet Explorer 11 with error about localStorage.getItem being null

2014-04-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64525

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64525] MediaViewer fails in Internet Explorer 11 with error about localStorage.getItem being null

2014-04-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64525

--- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 130230 had a related patch set uploaded by Gergő Tisza:
Handle window.localStorage === null case correctly

https://gerrit.wikimedia.org/r/130230

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l