[Bug 65454] Welcome Message contains an internal link in error
https://bugzilla.wikimedia.org/show_bug.cgi?id=65454 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65454] Welcome Message contains an internal link in error
https://bugzilla.wikimedia.org/show_bug.cgi?id=65454 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 155344 had a related patch set uploaded by Legoktm: Make helppage link relative https://gerrit.wikimedia.org/r/155344 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65454] Welcome Message contains an internal link in error
https://bugzilla.wikimedia.org/show_bug.cgi?id=65454 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 155344 merged by jenkins-bot: Make helppage link relative https://gerrit.wikimedia.org/r/155344 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65454] Welcome Message contains an internal link in error
https://bugzilla.wikimedia.org/show_bug.cgi?id=65454 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED CC||legoktm.wikipe...@gmail.com Resolution|--- |FIXED Flags|Backport_to_Stable? |Backport_to_Stable+ --- Comment #10 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com --- Backported to REL1_23. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65454] Welcome Message contains an internal link in error
https://bugzilla.wikimedia.org/show_bug.cgi?id=65454 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW --- Comment #7 from Bartosz Dziewoński matma@gmail.com --- Resolved? Not resolved? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65454] Welcome Message contains an internal link in error
https://bugzilla.wikimedia.org/show_bug.cgi?id=65454 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 134063 merged by Siebrand: Make helppage link relative https://gerrit.wikimedia.org/r/134063 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65454] Welcome Message contains an internal link in error
https://bugzilla.wikimedia.org/show_bug.cgi?id=65454 Siebrand Mazeland siebr...@kitano.nl changed: What|Removed |Added CC||siebr...@kitano.nl Flags||Backport_to_Stable? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65454] Welcome Message contains an internal link in error
https://bugzilla.wikimedia.org/show_bug.cgi?id=65454 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Keywords||easy Priority|Unprioritized |Normal CC||aklap...@wikimedia.org --- Comment #1 from Andre Klapper aklap...@wikimedia.org --- Hi Bill! Thanks for investigating and reporting this! Just in case you feel like fixing the code, you are welcome to use Developer access https://www.mediawiki.org/wiki/Developer_access to submit this as a Git branch directly into Gerrit: https://www.mediawiki.org/wiki/Git/Tutorial Putting your branch in Git makes it easier to review it quickly. If you don't want to set up Git/Gerrit, you can also use https://tools.wmflabs.org/gerrit-patch-uploader/ -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65454] Welcome Message contains an internal link in error
https://bugzilla.wikimedia.org/show_bug.cgi?id=65454 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added CC||federicol...@tiscali.it, ||matma@gmail.com --- Comment #2 from Bartosz Dziewoński matma@gmail.com --- MediaWiki:Helppage is allowed to be either an internal or external link. You should use Skin::makeInternalOrExternalUrl() to generate a correct one. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65454] Welcome Message contains an internal link in error
https://bugzilla.wikimedia.org/show_bug.cgi?id=65454 --- Comment #3 from Bill Traynor btray...@gmail.com --- That's great, but doesn't make sense to me. The link is to a MediaWiki.org help page, which would mean that it is only an internal link to the MediaWiki.org site. Given that, shouldn't it at least be an external link by default? And how would I or anyone else know to use Skin::makeInternalOrExternalUrl()? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65454] Welcome Message contains an internal link in error
https://bugzilla.wikimedia.org/show_bug.cgi?id=65454 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 134063 had a related patch set uploaded by Nemo bis: Make helppage link relative https://gerrit.wikimedia.org/r/134063 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65454] Welcome Message contains an internal link in error
https://bugzilla.wikimedia.org/show_bug.cgi?id=65454 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65454] Welcome Message contains an internal link in error
https://bugzilla.wikimedia.org/show_bug.cgi?id=65454 Nemo federicol...@tiscali.it changed: What|Removed |Added Target Milestone|--- |MW 1.23 version --- Comment #5 from Nemo federicol...@tiscali.it --- (In reply to Bill Traynor from comment #3) Given that, shouldn't it at least be an external link by default? Yes but it used to be the opposite before; there is an ongoing standardisation towards external https links. And how would I or anyone else know to use Skin::makeInternalOrExternalUrl()? That's something for the code, see patch linked above. For core we had added notes about the only case we noticed, sorry for this oversight. https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/RELEASE-NOTES-1.23#L44 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
