[Bug 65643] Deprecation warnings in JS console
https://bugzilla.wikimedia.org/show_bug.cgi?id=65643 --- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 138487 merged by jenkins-bot: Avoid JavaScript deprecation warnings in user module https://gerrit.wikimedia.org/r/138487 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65643] Deprecation warnings in JS console
https://bugzilla.wikimedia.org/show_bug.cgi?id=65643 Jon jrob...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65643] Deprecation warnings in JS console
https://bugzilla.wikimedia.org/show_bug.cgi?id=65643
Jon jrob...@wikimedia.org changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|WONTFIX |---
--- Comment #10 from Jon jrob...@wikimedia.org ---
Okay after talking to Juliusz we decided we should do some sort of shallow
clone without using extend
e.g
M.define( 'user', {
getName: mw.user.getName,
isAnon: mw.user.isAnon
} );
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65643] Deprecation warnings in JS console
https://bugzilla.wikimedia.org/show_bug.cgi?id=65643 --- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 138487 had a related patch set uploaded by Jdlrobson: Avoid JavaScript deprecation warnings in user module https://gerrit.wikimedia.org/r/138487 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65643] Deprecation warnings in JS console
https://bugzilla.wikimedia.org/show_bug.cgi?id=65643 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65643] Deprecation warnings in JS console
https://bugzilla.wikimedia.org/show_bug.cgi?id=65643 --- Comment #9 from Juliusz Gonera jgon...@wikimedia.org --- I think we should do something about it. One option is not to extend mw.user, but have something separate instead. We could also upstream what we have there into core. Leaving those warnings is bad because we'll get used to them, start ignoring them and in future we'll miss other warnings that might appear in the console. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65643] Deprecation warnings in JS console
https://bugzilla.wikimedia.org/show_bug.cgi?id=65643
Jon jrob...@wikimedia.org changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|--- |WONTFIX
--- Comment #8 from Jon jrob...@wikimedia.org ---
Juliusz feel free to disagree but I can't imagine we want to do anything here.
In theory we could do the following:
delete mw.user.name;
delete mw.user.anonymous;
user = $.extend( {}, mw.user, {
which suppresses the warnings - but that seems like a waste of time.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65643] Deprecation warnings in JS console
https://bugzilla.wikimedia.org/show_bug.cgi?id=65643 Juliusz Gonera jgon...@wikimedia.org changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Juliusz Gonera jgon...@wikimedia.org --- I can't see any deprecation warnings in desktop mode. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65643] Deprecation warnings in JS console
https://bugzilla.wikimedia.org/show_bug.cgi?id=65643 --- Comment #5 from Florian florian.schmidt.wel...@t-online.de --- I'm not sure, when mediawiki.user.js is loaded, but if i missed nothing i have searched all files of MobileFrontend and there is nowhere used the deprecated functions. I have deleted the lines from file i have linked in comment #2 and the messages are away, so i'm pretty sure, that we talk about these lines, which are both in core :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65643] Deprecation warnings in JS console
https://bugzilla.wikimedia.org/show_bug.cgi?id=65643
--- Comment #6 from Jon jrob...@wikimedia.org ---
I had a closer look and Juliusz is right.
Running this:
$.extend( {}, mw.user );
seems to be what causes the deprecation notices so I'm pretty sure there is
nothing we can do here and this bug is a WONTFIX/INVALID or something similar
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65643] Deprecation warnings in JS console
https://bugzilla.wikimedia.org/show_bug.cgi?id=65643 --- Comment #7 from Florian florian.schmidt.wel...@t-online.de --- Yeah, is right :) I think we missunderstand us. I meaned, that we can't do anything without change something in core :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65643] Deprecation warnings in JS console
https://bugzilla.wikimedia.org/show_bug.cgi?id=65643 Jon jrob...@wikimedia.org changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from Jon jrob...@wikimedia.org --- I think you are right here Florian... -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65643] Deprecation warnings in JS console
https://bugzilla.wikimedia.org/show_bug.cgi?id=65643 --- Comment #2 from Florian florian.schmidt.wel...@t-online.de --- But this isn't a bg of MobileFrontend, am i right? MobileFrontend uses getName and isAnon already. The deprecated message appears in mobileView and on desktop view, because it's generated every time mediawiki.user.js is included: https://github.com/wikimedia/mediawiki-core/blob/9f7e79ab6ba0fd3a0e4b002ca46b600a4a880a75/resources/src/mediawiki/mediawiki.user.js#L245 I think, for now we haven't to do anything :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 65643] Deprecation warnings in JS console
https://bugzilla.wikimedia.org/show_bug.cgi?id=65643 --- Comment #1 from Bingle bingle-ad...@wikimedia.org --- Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/BxpqQtzw -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
