[Bug 65698] Under HHVM: Call to a member function getGuid() on a non-object

2014-09-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=65698

Ori Livneh  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 65698] Under HHVM: Call to a member function getGuid() on a non-object

2014-09-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=65698

--- Comment #9 from Ori Livneh  ---
This doesn't appear in the last month's worth of logs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 65698] Under HHVM: Call to a member function getGuid() on a non-object

2014-08-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=65698

--- Comment #8 from Lydia Pintscher  ---
This needs to be checked in datamodel 0.8.2.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 65698] Under HHVM: Call to a member function getGuid() on a non-object

2014-08-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=65698

Aaron Schulz  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---
   Severity|normal  |major

--- Comment #7 from Aaron Schulz  ---
Reopening since this problem still occurs on production and spams the logs. The
change needs to go through the pipeline.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 65698] Under HHVM: Call to a member function getGuid() on a non-object

2014-07-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=65698

--- Comment #6 from Ori Livneh  ---
(In reply to Aaron Schulz from comment #5)
> Was this deployed on production yet? I still see this.

No, not yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 65698] Under HHVM: Call to a member function getGuid() on a non-object

2014-07-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=65698

Aaron Schulz  changed:

   What|Removed |Added

 CC||aschulz4...@gmail.com

--- Comment #5 from Aaron Schulz  ---
Was this deployed on production yet? I still see this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 65698] Under HHVM: Call to a member function getGuid() on a non-object

2014-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=65698

Ori Livneh  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Ori Livneh  ---
Upstream PR merged.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 65698] Under HHVM: Call to a member function getGuid() on a non-object

2014-06-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=65698

Ori Livneh  changed:

   What|Removed |Added

   Keywords||upstream

--- Comment #3 from Ori Livneh  ---
Upstream(?) PR: https://github.com/wmde/WikibaseDataModel/pull/120

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 65698] Under HHVM: Call to a member function getGuid() on a non-object

2014-06-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=65698

--- Comment #2 from Ori Livneh  ---
I don't think this is too mysterious. Claims.php has the following code
(L432-434):

assert( $oldClaim instanceof Claim );
assert( $newClaim instanceof Claim );
assert( $oldClaim->getGuid() === $newClaim->getGuid() );

The expectation was presumably that if either $oldClaim or $newClaim are null,
the final assert would never get executed. That isn't the case.

I do note that HHVM and PHP have somewhat different assert settings at the
moment:

PHP
~~~
option  ini_get()   assert_options()
**
assert.active   "1" 1
assert.warning  "1" 1
assert.bail "0" 0
assert.quiet_eval   "0" 0


HHVM

option  ini_get()   assert_options()
**
assert.active   ""  0
assert.warning  ""  0
assert.bail ""  0
assert.quiet_eval   ""  false


I'll see if I can get them to match.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 65698] Under HHVM: Call to a member function getGuid() on a non-object

2014-06-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=65698

Tim Starling  changed:

   What|Removed |Added

 CC||tstarl...@wikimedia.org

--- Comment #1 from Tim Starling  ---
We really need full job parameters if we're going to debug these job queue
failures effectively. Even correlated runJobs.log lines would not be enough in
this case, since the strings in the log lines are truncated at 1024 characters,
and changeIds is usually larger than that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 65698] Under HHVM: Call to a member function getGuid() on a non-object

2014-05-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=65698

Adrian Lang  changed:

   What|Removed |Added

 Blocks||64415

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 65698] Under HHVM: Call to a member function getGuid() on a non-object

2014-05-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=65698

Lydia Pintscher  changed:

   What|Removed |Added

   Keywords||need-volunteer
   Priority|Unprioritized   |Normal
 CC||adrian.l...@wikimedia.de,
   ||h...@online.de,
   ||lydia.pintscher@wikimedia.d
   ||e
 Whiteboard||u=dev c=backend p=0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 65698] Under HHVM: Call to a member function getGuid() on a non-object

2014-05-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=65698

Max Semenik  changed:

   What|Removed |Added

   Keywords||hiphop

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l