[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 --- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 142395 merged by jenkins-bot: Remove explicit isBlocked(), change permission ordering to match core https://gerrit.wikimedia.org/r/142395 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 --- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 142170 abandoned by EBernhardson: Remove explicit isBlocked(), change permission ordering to match core Reason: @matt I'll go ahead and take over this patch frontend-rewrite branch is closed, resubmitted against master as https://gerrit.wikimedia.org/r/142395 https://gerrit.wikimedia.org/r/142170 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 --- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 142395 had a related patch set uploaded by EBernhardson: Remove explicit isBlocked(), change permission ordering to match core https://gerrit.wikimedia.org/r/142395 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added CC||mflasc...@wikimedia.org Assignee|wikibugs-l@lists.wikimedia. |mflasc...@wikimedia.org |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 --- Comment #6 from Matthew Flaschen mflasc...@wikimedia.org --- If I understand the report, it's saying that AbuseFilter is blocking it, whereas you expect it to be blocked by Flow. Are there any edits that actually went all the way through when they were blocked at the edit-time? Otherwise, this could just be a hook registration order issue. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 --- Comment #7 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com --- Edit permissions should be being checked before it runs through the AbuseFilter. If the user can't edit the page, it shouldn't be wasting time running through the AbuseFilter/SpamBlacklist/etc. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 --- Comment #8 from Matthew Flaschen mflasc...@wikimedia.org --- (In reply to Kunal Mehta (Legoktm) from comment #7) Edit permissions should be being checked before it runs through the AbuseFilter. If the user can't edit the page, it shouldn't be wasting time running through the AbuseFilter/SpamBlacklist/etc. Yeah, I researched more closely after that, and they're different hooks anyway. AbuseFilter doesn't even use the getUserPermissionsErrorsExpensive/userCan hook -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 --- Comment #9 from Matthew Flaschen mflasc...@wikimedia.org --- In core, EditPage-edit calls EditPage-getEditPermissionErrors That calls Title-getUserPermissionsErrors with the default expensive true, which triggers hook checks Later EditPage-edit calls EditPage-attemptSave(), which calls EditPage-internalAttemptSave(). That then calls EditPage-runPostMergeFilters which does the EditFilterMergedContent, etc checks. --- Erik noted that in Flow, it's done in a different order. Specifically, WorkflowLoader calls Block-onSubmit early, which in turn calls Block-validate, which eventually checks the spam filters. Then, only later does it check blocking and userCan. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 --- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 142170 had a related patch set uploaded by Mattflaschen: Remove explicit isBlocked(), change permission ordering to match core https://gerrit.wikimedia.org/r/142170 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 --- Comment #2 from Jasper Deng jas...@jasperswebsite.com --- Same deal with https://www.mediawiki.org/wiki/Special:Contributions/94.23.251.211 and https://www.mediawiki.org/wiki/Special:Contributions/123.125.19.44 , the latter of which is a single global block, so it is not limited to just global rangeblocks. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 --- Comment #3 from Jasper Deng jas...@jasperswebsite.com --- Also https://www.mediawiki.org/wiki/Special:Contributions/37.187.0.0/16 I don't know why the check is failing, but chances are that these are being submitted through the API, in case that makes a difference. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 --- Comment #4 from Jasper Deng jas...@jasperswebsite.com --- This also doesn't look good. https://www.mediawiki.org/wiki/Special:Block/185.8.237.178 is a tor node, so it might not just be limited to global blocks. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 --- Comment #5 from Jasper Deng jas...@jasperswebsite.com --- https://www.mediawiki.org/wiki/Special:Block/172.245.142.156 is both! -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=60218 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added Priority|Unprioritized |High -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 66994] Global blocks do not stop flow spam
https://bugzilla.wikimedia.org/show_bug.cgi?id=66994 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added CC||legoktm.wikipe...@gmail.com --- Comment #1 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com --- Flow calls Title::userCan (https://github.com/wikimedia/mediawiki-extensions-Flow/blob/42e8d57fe5ff07d8c26b9d7add5e8749aecdd328/includes/WorkflowLoader.php#L249), which GlobalBlocking hooks into. Maybe something is bypassing that check? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
