[Bug 68802] File links with local project prefix cause images to be transcluded
https://bugzilla.wikimedia.org/show_bug.cgi?id=68802 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 150511 merged by jenkins-bot: Don't include images/categories when behind a local interwiki prefix https://gerrit.wikimedia.org/r/150511 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68802] File links with local project prefix cause images to be transcluded
https://bugzilla.wikimedia.org/show_bug.cgi?id=68802 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED Target Milestone|--- |1.24.0 release --- Comment #8 from Bartosz Dziewoński matma@gmail.com --- Should be fixed. Please verify on beta labs. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68802] File links with local project prefix cause images to be transcluded
https://bugzilla.wikimedia.org/show_bug.cgi?id=68802 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 150511 had a related patch set uploaded by TTO: Don't include images/categories when behind a local interwiki prefix https://gerrit.wikimedia.org/r/150511 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68802] File links with local project prefix cause images to be transcluded
https://bugzilla.wikimedia.org/show_bug.cgi?id=68802 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68802] File links with local project prefix cause images to be transcluded
https://bugzilla.wikimedia.org/show_bug.cgi?id=68802 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |High -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68802] File links with local project prefix cause images to be transcluded
https://bugzilla.wikimedia.org/show_bug.cgi?id=68802 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added CC||at.li...@live.com.au, ||matma@gmail.com See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=68085 --- Comment #1 from Bartosz Dziewoński matma@gmail.com --- This might be the same issue as bug 68085, which has been already fixed (but not yet deployed). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68802] File links with local project prefix cause images to be transcluded
https://bugzilla.wikimedia.org/show_bug.cgi?id=68802 --- Comment #2 from Erwin Dokter er...@darcoury.nl --- I can't tell if that will fix it. I will know as soon as it is deployed to enwiki. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68802] File links with local project prefix cause images to be transcluded
https://bugzilla.wikimedia.org/show_bug.cgi?id=68802 --- Comment #3 from This, that and the other (TTO) at.li...@live.com.au --- No, unfortunately that won't fix it. I don't think I'd be exaggerating too much if I said this behaviour has been present in MediaWiki for ten years. It's only becoming apparent now that the WMF local interwiki config has been set correctly. It's not immediately clear to me how this should be fixed. I'll give it a good think and submit a patch ASAP, as I see this is causing fair use violations on enwiki. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68802] File links with local project prefix cause images to be transcluded
https://bugzilla.wikimedia.org/show_bug.cgi?id=68802
--- Comment #4 from This, that and the other (TTO) at.li...@live.com.au ---
I don't have access to Git right now, but the correct fix would be to move the
substr_compare test, currently on line 2107 of Parser.php, up to the if
statement on line 2099:
if ( $noforce substr_compare( $this-getTargetLanguage()-lc( ltrim(
$origLink ) ), $iw, 0, strlen( $iw ) ) === 0 ) {
And obviously also move the corresponding comment, and change it to mention
both this bug and bug 68085. If someone could do that it'd be great.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68802] File links with local project prefix cause images to be transcluded
https://bugzilla.wikimedia.org/show_bug.cgi?id=68802 --- Comment #5 from This, that and the other (TTO) at.li...@live.com.au --- Actually don't know if that would work 100%... in any case it probably needs to be || rather than and !== instead of ===... I'll come back to it later when I have more time. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
