[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 Erik Moeller e...@wikimedia.org changed: What|Removed |Added CC||e...@wikimedia.org --- Comment #16 from Erik Moeller e...@wikimedia.org --- Confirmed fixed (tested in FF32 and Chrome35). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 --- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 160028 merged by jenkins-bot: Make sure event handlers are set up even if onready handler is lost https://gerrit.wikimedia.org/r/160028 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 --- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 160415 had a related patch set uploaded by Gergő Tisza: Make sure event handlers are set up even if onready handler is lost https://gerrit.wikimedia.org/r/160415 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 --- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 160413 had a related patch set uploaded by Gergő Tisza: Make sure event handlers are set up even if onready handler is lost https://gerrit.wikimedia.org/r/160413 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 --- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 160413 merged by jenkins-bot: Make sure event handlers are set up even if onready handler is lost https://gerrit.wikimedia.org/r/160413 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 --- Comment #14 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 160415 merged by jenkins-bot: Make sure event handlers are set up even if onready handler is lost https://gerrit.wikimedia.org/r/160415 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 Tisza Gergő gti...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #15 from Tisza Gergő gti...@wikimedia.org --- Works after pushing out the patch via SWAT. The underlying issue (local site JS onready handlers throwing errors will prevent onready handlers of extensions from being called) is tracked as bug 70772. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 --- Comment #1 from Tisza Gergő gti...@wikimedia.org --- Weird... https://wikimediafoundation.org/wiki/Staff_and_contractors?showall=1 works but the template does not. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 --- Comment #2 from Tisza Gergő gti...@wikimedia.org --- Tracked in Mingle as https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/891 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 --- Comment #3 from Tisza Gergő gti...@wikimedia.org --- Same issue as https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/825 : the domready handler in mmv.bootstrap.autostart.js is never called, even though the $(document).ready(handler) call itself is executed. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 --- Comment #4 from Tisza Gergő gti...@wikimedia.org --- Well, not quite the same issue because that was Firefox-specific and this can be reproduced in Chrome. But the underlying issue is the same: something removes domready event handlers. Given that the error is specific to this page, it might be related to the script embedded in the template to show/hide departmental lists (which works on the staff page but errors out on the template page). I really don't see how though. The error can be reproduced in debug mode, so it can't be errors in one script affecting other scripts due to ResourceLoader concatenating them. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756
--- Comment #5 from Tisza Gergő gti...@wikimedia.org ---
It seems that fundamental jQuery behavior differs between the two pages. On
[[wmf:Staff and contractors]]:
$(document).ready( function() { console.log('!'); });
// !
On [[wmf:Template:Staff and contractors]]:
$(document).ready( function() { console.log('!'); });
// no output
so some script might be messing with jQuery internals.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 --- Comment #6 from Tisza Gergő gti...@wikimedia.org --- More specifically, $.ready.promise().done(cb) fires on the staff page but not the template page, even though $.ready.promise().state() returns -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 --- Comment #7 from Tisza Gergő gti...@wikimedia.org --- ... resolved on both pages. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 Tisza Gergő gti...@wikimedia.org changed: What|Removed |Added Depends on||70772 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 --- Comment #8 from Tisza Gergő gti...@wikimedia.org --- This is jQuery bug #10251 [1] (wontfixed). Basically, when a $(document).ready() handler has an error, all subsequent handlers fail to run. Given that gadgets are usually loaded before exceptions, this is bad and a generic solution is needed; but since that looks hard, and this issue affects MediaViewer in a rather severe way (a couple users complained about a BSOD - they were probably using broken user scripts which prevented the loading of the MediaViewer event handler which removes the black overlay), we should probably implement a local workaround. [1] http://bugs.jquery.com/ticket/10251 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 160028 had a related patch set uploaded by Gergő Tisza: Make sure event handlers are set up even if onready handler is lost https://gerrit.wikimedia.org/r/160028 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 70756] MediaViewer: Closing MediaViewer results in black, undismissable page
https://bugzilla.wikimedia.org/show_bug.cgi?id=70756 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
