[Bug 72666] Unify view-implementations in JS frontend
https://bugzilla.wikimedia.org/show_bug.cgi?id=72666 --- Comment #4 from Adrian Lang adrian.l...@wikimedia.de --- Another step I forgot: Write tests for all interfaces, run the tests against the widgets implementing an interface. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 72666] Unify view-implementations in JS frontend
https://bugzilla.wikimedia.org/show_bug.cgi?id=72666 Henning bugzilla.d...@gmail.com changed: What|Removed |Added CC||bugzilla.d...@gmail.com --- Comment #1 from Henning bugzilla.d...@gmail.com --- https://gerrit.wikimedia.org/r/#/c/172507/ -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 72666] Unify view-implementations in JS frontend
https://bugzilla.wikimedia.org/show_bug.cgi?id=72666 --- Comment #2 from Adrian Lang adrian.l...@wikimedia.de --- From my point of view, steps could be: * Make a list of interfaces and behaviours our widgets possess * Extract common interfaces (might not be code interfaces, since JS is not particularly good with them) * Unify implementations, document which widget implements which interface I'd strongly prefer to not increase code reusage through inheritance. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 72666] Unify view-implementations in JS frontend
https://bugzilla.wikimedia.org/show_bug.cgi?id=72666 --- Comment #3 from Adrian Lang adrian.l...@wikimedia.de --- Despite the last sentence in my previous comment I still think Henning's patch is an improvement and could be merged :) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 72666] Unify view-implementations in JS frontend
https://bugzilla.wikimedia.org/show_bug.cgi?id=72666 Lydia Pintscher lydia.pintsc...@wikimedia.de changed: What|Removed |Added CC||lydia.pintscher@wikimedia.d ||e Whiteboard|u=dev c=frontend p=0|u=dev c=frontend p=13 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 72666] Unify view-implementations in JS frontend
https://bugzilla.wikimedia.org/show_bug.cgi?id=72666 Adrian Lang adrian.l...@wikimedia.de changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=70337 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 72666] Unify view-implementations in JS frontend
https://bugzilla.wikimedia.org/show_bug.cgi?id=72666 tobias.gritschac...@wikimedia.de changed: What|Removed |Added Priority|Unprioritized |Normal Whiteboard||u=dev c=frontend p=0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
