[Bug 73281] Lua syntax highlighting doesn't recognize comments properly

2014-11-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73281

--- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 173104 merged by jenkins-bot:
Fix Lua comment blocks and string blocks.

https://gerrit.wikimedia.org/r/173104

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 73281] Lua syntax highlighting doesn't recognize comments properly

2014-11-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73281

Brad Jorsch bjor...@wikimedia.org changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Brad Jorsch bjor...@wikimedia.org ---
This should be deployed to WMF wikis with 1.25wmf9, see
https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap for the schedule.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 73281] Lua syntax highlighting doesn't recognize comments properly

2014-11-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73281

This, that and the other (TTO) at.li...@live.com.au changed:

   What|Removed |Added

 CC||hartman.w...@gmail.com
   See Also||https://github.com/GeSHi/ge
   ||shi-1.0/issues/32

--- Comment #3 from This, that and the other (TTO) at.li...@live.com.au ---
(In reply to Sam Reed (reedy) from comment #1)
 Needs filing/fixing upstream at https://github.com/GeSHi/geshi-1.0/issues

https://github.com/GeSHi/geshi-1.0/issues/32

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 73281] Lua syntax highlighting doesn't recognize comments properly

2014-11-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73281

--- Comment #4 from Brad Jorsch bjor...@wikimedia.org ---
(In reply to George Orwell III from comment #2)
 Any reason..
  
 --[=[
 Start of hidden comments
 . . .
 End of hidden comments
 ]=]
 
 ... provides the desired detection of the closing of hidden comments long
 brackets? Could there have been a change in syntax usage since last release
 was updated or something?

If you have two such blocks in a single module, it shows the same issue.
Basically, instead of finding the *first* close-comment after the open-comment,
it finds the *last* one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 73281] Lua syntax highlighting doesn't recognize comments properly

2014-11-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73281

--- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 173104 had a related patch set uploaded by TheDJ:
Fix Lua comment blocks and string blocks.

https://gerrit.wikimedia.org/r/173104

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 73281] Lua syntax highlighting doesn't recognize comments properly

2014-11-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73281

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 73281] Lua syntax highlighting doesn't recognize comments properly

2014-11-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73281

--- Comment #2 from George Orwell III george.orwell@outlook.com ---
Any reason..

--[=[
Start of hidden comments
. . .
End of hidden comments
]=]

... provides the desired detection of the closing of hidden comments long
brackets? Could there have been a change in syntax usage since last release was
updated or something?

Note: Also confirmed in  
https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Module_syntax_highlighting_broken_for_hidden_comments

 .

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 73281] Lua syntax highlighting doesn't recognize comments properly

2014-11-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73281

Brad Jorsch bjor...@wikimedia.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||s...@reedyboy.net,
   ||soxre...@gmail.com
  Component|Scribunto   |SyntaxHighlight (GeSHi)
Summary|Syntax highlighting doesn't |Lua syntax highlighting
   |recognize comments properly |doesn't recognize comments
   ||properly
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 73281] Lua syntax highlighting doesn't recognize comments properly

2014-11-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=73281

Sam Reed (reedy) s...@reedyboy.net changed:

   What|Removed |Added

   Keywords||upstream
   Priority|Unprioritized   |Normal

--- Comment #1 from Sam Reed (reedy) s...@reedyboy.net ---
Needs filing/fixing upstream at https://github.com/GeSHi/geshi-1.0/issues

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l