[Wikidata-bugs] [Maniphest] [Commented On] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 229741 had a related patch set uploaded (by JanZerebecki): Log when we fail unserializeInfo https://gerrit.wikimedia.org/r/229741 TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Addshore, daniel, JanZerebecki, Aklapper, hoo, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher
JanZerebecki added a comment. Perhaps make it LONGBLOB so that it can hold more than the entity that is stored in a MEDIUMBLOB. TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: gerritbot, Addshore, daniel, JanZerebecki, Aklapper, hoo, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher
JanZerebecki added a comment. From quickly skimming the relevant code, my estimate is that we don't need to increase rc_params, because we explicitly omit also adding the content of change_info into it. So that we know which items this affected: [wikidatawiki] select change_object_id, change_revision_id from wb_changes where change_id in (236998945, 236999268, 237059314, 237059627) ; +--++ | change_object_id | change_revision_id | +--++ | q18041912| 238873453 | | q18053093| 238873799 | | q18041912| 238934794 | | q18053093| 238935101 | +--++ 4 rows in set (0.01 sec) It seems https://www.wikidata.org/wiki/User:ProteinBoxBot is updating the retrieved date on all the references of an item without anything else: https://www.wikidata.org/w/index.php?title=Q18053093diff=prevoldid=238935101 TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: gerritbot, Addshore, daniel, JanZerebecki, Aklapper, hoo, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T108252: EntityAccessor::getEntity should fail gracefully on double redirects
hoo added a project: Wikimedia-log-errors. hoo set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T108252 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Sjoerddebruin, JanZerebecki, aude, daniel, Aklapper, hoo, Wikidata-bugs, Krenair, greg, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T105325: edit_diff_pst variable is broken on Wikidata
hoo triaged this task as Normal priority. TASK DETAIL https://phabricator.wikimedia.org/T105325 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: hoo, Addshore, Aklapper, Luke081515, matej_suchanek, Wikidata-bugs, aude, Se4598, Billinghurst, Jackmcbarn, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T108232: Banners in desktop skin should have a max width
Jdlrobson created this task.
Jdlrobson added a subscriber: Jdlrobson.
Jdlrobson added a project: Wikidata-Page-Banner.
Jdlrobson moved this task to July 19-August 10 on the Wikidata-Page-Banner
workboard.
Herald added a subscriber: Aklapper.
Herald added a project: Wikidata.
TASK DESCRIPTION
Set a page banner as Einstein_1921_by_F_Schmutzer_-_restoration.jpg
View in Vector skin
The banner should have a maximum height and the origin coordinates should be
applied in this skin just as they are on mobile.. otherwise the image will not
be clipped as well as it could be. These rules should only apply in the
situation when the banner is clipped.
{F648900}
Note when I shrink Vector skin layout it focuses on the area I told it to -
which is great :)
{F648922}
TASK DETAIL
https://phabricator.wikimedia.org/T108232
WORKBOARD
https://phabricator.wikimedia.org/project/board/1158/
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jdlrobson
Cc: Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T108231: Work on joint presentation with Blazegraph for SmatData conf
Smalyshev created this task. Smalyshev claimed this task. Smalyshev added a subscriber: Smalyshev. Smalyshev added projects: Wikidata-Query-Service, Discovery-Wikidata-Query-Service-Sprint, Discovery. Herald added a subscriber: Aklapper. Herald added a project: Wikidata. TASK DESCRIPTION Work on joint presentation with Blazegraph for SmatData conf: http://smartdata2015.dataversity.net/ TASK DETAIL https://phabricator.wikimedia.org/T108231 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev Cc: Aklapper, Smalyshev, jkroll, Wikidata-bugs, Jdouglas, aude, Manybubbles, JanZerebecki, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T108231: Work on joint presentation with Blazegraph for SmatData conf
Smalyshev moved this task to In progress on the Discovery-Wikidata-Query-Service-Sprint workboard. TASK DETAIL https://phabricator.wikimedia.org/T108231 WORKBOARD https://phabricator.wikimedia.org/project/board/1239/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev Cc: Aklapper, Smalyshev, jkroll, Wikidata-bugs, Jdouglas, aude, Manybubbles, JanZerebecki, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T108252: EntityAccessor::getEntity should fail gracefully on double redirects
JanZerebecki moved this task to consider for next sprint on the Wikidata workboard. TASK DETAIL https://phabricator.wikimedia.org/T108252 WORKBOARD https://phabricator.wikimedia.org/project/board/71/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: Sjoerddebruin, JanZerebecki, aude, daniel, Aklapper, hoo, Wikidata-bugs, Krenair, greg, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T108231: Work on joint presentation with Blazegraph for SmatData conf
JanZerebecki moved this task to monitoring on the Wikidata workboard. TASK DETAIL https://phabricator.wikimedia.org/T108231 WORKBOARD https://phabricator.wikimedia.org/project/board/71/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev, JanZerebecki Cc: Aklapper, Smalyshev, jkroll, Wikidata-bugs, Jdouglas, aude, Manybubbles, JanZerebecki, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T108252: EntityAccessor::getEntity should fail gracefully on double redirects
JanZerebecki added a comment. In this case it was the Q template referencing Q19859594. https://www.wikidata.org/w/index.php?title=Special:WhatLinksHere/Q16428906hidelinks=1 TASK DETAIL https://phabricator.wikimedia.org/T108252 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: Sjoerddebruin, JanZerebecki, aude, daniel, Aklapper, hoo, Wikidata-bugs, Krenair, greg, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T105033: Explore mobile specific banners
gerritbot added a comment. Change 228813 merged by jenkins-bot: WPB fake banner cropping for small screens https://gerrit.wikimedia.org/r/228813 TASK DETAIL https://phabricator.wikimedia.org/T105033 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Sumit, Nicolas_Raoul, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T87524: Merge with conflicting sitelinks is not rejected
hoo added a comment. Can anyone come up with a recent example for this? The handling of sitelinks during merges changed heavily with https://phabricator.wikimedia.org/rEWBA59a1d67aa40439027e9834d300a8b5c6aaa7b18e so this might no longer be a problem. TASK DETAIL https://phabricator.wikimedia.org/T87524 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: matej_suchanek, Ricordisamoa, Liuxinyu970226, aude, daniel, hoo, Addshore, petr.matas, Aklapper, Wikidata-bugs, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T108252: EntityAccessor::getEntity should fail gracefully on double redirects
hoo created this task.
hoo added subscribers: hoo, daniel, aude, JanZerebecki, Sjoerddebruin.
hoo added projects: Wikidata, MediaWiki-extensions-WikibaseClient.
Herald added a subscriber: Aklapper.
TASK DESCRIPTION
Example exception (slightly messed because logging is messed right now):
```
2015-08-06 21:40:47 mw1023 wikidatawiki exception ERROR: [0a95aa13]
/wiki/User_talk:ProteinBoxBot Wikibase\Lib\Store\UnresolvedRedirectException
from line 87 of
/srv/mediawiki/php-1.26wmf17/extensions/Wikidata/extensions/Wikibase/lib/includes/store/sql/WikiPageEntityRevisionLookup.php:
Unresolved redirect to Q16428906 {exception:[Exception
Wikibase\\Lib\\Store\\UnresolvedRedirectException]
(/srv/mediawiki/php-1.26wmf17/extensions/Wikidata/extensions/Wikibase/lib/includes/store/sql/WikiPageEntityRevisionLookup.php:87)
Unresolved redirect to Q16428906
[stacktrace]
#0
/srv/mediawiki/php-1.26wmf17/extensions/Wikidata/extensions/Wikibase/lib/includes/store/CachingEntityRevisionLookup.php(148):
Wikibase\\Lib\\Store\\WikiPageEntityRevisionLookup-getEntityRevision(Wikibase\\DataModel\\Entity\\ItemId,
string)
#1
/srv/mediawiki/php-1.26wmf17/extensions/Wikidata/extensions/Wikibase/lib/includes/store/CachingEntityRevisionLookup.php(131):
Wikibase\\Lib\\Store\\CachingEntityRevisionLookup-fetchEntityRevision(Wikibase\\DataModel\\Entity\\ItemId,
string)
#2
/srv/mediawiki/php-1.26wmf17/extensions/Wikidata/extensions/Wikibase/lib/includes/store/CachingEntityRevisionLookup.php(148):
Wikibase\\Lib\\Store\\CachingEntityRevisionLookup-getEntityRevision(Wikibase\\DataModel\\Entity\\ItemId,
string)
#3
/srv/mediawiki/php-1.26wmf17/extensions/Wikidata/extensions/Wikibase/lib/includes/store/CachingEntityRevisionLookup.php(131):
Wikibase\\Lib\\Store\\CachingEntityRevisionLookup-fetchEntityRevision(Wikibase\\DataModel\\Entity\\ItemId,
string)
#4
/srv/mediawiki/php-1.26wmf17/extensions/Wikidata/extensions/Wikibase/lib/includes/store/RevisionBasedEntityLookup.php(41):
Wikibase\\Lib\\Store\\CachingEntityRevisionLookup-getEntityRevision(Wikibase\\DataModel\\Entity\\ItemId)
#5 [internal function]:
Wikibase\\Lib\\Store\\RevisionBasedEntityLookup-getEntity(Wikibase\\DataModel\\Entity\\ItemId)
#6
/srv/mediawiki/php-1.26wmf17/extensions/Wikidata/extensions/Wikibase/lib/includes/store/EntityRedirectResolvingDecorator.php(79):
call_user_func_array(array, array)
#7
/srv/mediawiki/php-1.26wmf17/extensions/Wikidata/extensions/Wikibase/lib/includes/store/RedirectResolvingEntityLookup.php(50):
Wikibase\\Lib\\Store\\EntityRedirectResolvingDecorator-__call(string, array)
#8
/srv/mediawiki/php-1.26wmf17/extensions/Wikidata/extensions/Wikibase/client/includes/DataAccess/Scribunto/EntityAccessor.php(128):
Wikibase\\Lib\\Store\\RedirectResolvingEntityLookup-getEntity(Wikibase\\DataModel\\Entity\\ItemId)
#9
/srv/mediawiki/php-1.26wmf17/extensions/Wikidata/extensions/Wikibase/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibrary.php(260):
Wikibase\\Client\\DataAccess\\Scribunto\\EntityAccessor-getEntity(string)
#10
/srv/mediawiki/php-1.26wmf17/extensions/Scribunto/engines/LuaSandbox/Engine.php(384):
Wikibase\\Client\\DataAccess\\Scribunto\\Scribunto_LuaWikibaseLibrary-getEntity(string)
#11 [internal function]: Scribunto_LuaSandboxCallback-__call(string, array)
#12
/srv/mediawiki/php-1.26wmf17/extensions/Scribunto/engines/LuaSandbox/Engine.php(297):
LuaSandboxFunction-call(LuaSandboxFunction)
#13
/srv/mediawiki/php-1.26wmf17/extensions/Scribunto/engines/LuaCommon/LuaCommon.php(257):
Scribunto_LuaSandboxInterpreter-callFunction(LuaSandboxFunction,
LuaSandboxFunction)
#14
/srv/mediawiki/php-1.26wmf17/extensions/Scribunto/engines/LuaCommon/LuaCommon.php(873):
Scribunto_LuaEngine-executeFunctionChunk(LuaSandboxFunction,
PPTemplateFrame_Hash)
#15 /srv/mediawiki/php-1.26wmf17/extensions/Scribunto/common/Hooks.php(116):
Scribunto_LuaModule-invoke(string, PPTemplateFrame_Hash)
#16 /srv/mediawiki/php-1.26wmf17/includes/parser/Parser.php(3774):
ScribuntoHooks::invokeHook(Parser, PPTemplateFrame_Hash, array)
#17 /srv/mediawiki/php-1.26wmf17/includes/parser/Parser.php(3508):
Parser-callParserFunction(PPTemplateFrame_Hash, string, array)
#18 /srv/mediawiki/php-1.26wmf17/includes/parser/Preprocessor_Hash.php(1100):
Parser-braceSubstitution(array, PPTemplateFrame_Hash)
#19 /srv/mediawiki/php-1.26wmf17/includes/parser/Parser.php(3650):
PPFrame_Hash-expand(PPNode_Hash_Tree)
#20 /srv/mediawiki/php-1.26wmf17/includes/parser/Preprocessor_Hash.php(1100):
Parser-braceSubstitution(array, PPTemplateFrame_Hash)
#21
/srv/mediawiki/php-1.26wmf17/extensions/ParserFunctions/ParserFunctions_body.php(120):
PPFrame_Hash-expand(PPNode_Hash_Tree)
#22 /srv/mediawiki/php-1.26wmf17/includes/parser/Parser.php(3774):
ExtParserFunctions::ifeqObj(Parser, PPTemplateFrame_Hash, array)
#23 /srv/mediawiki/php-1.26wmf17/includes/parser/Parser.php(3508):
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T46117: API modules must make sure getContext()-getTitle() returns a Title object.
hoo added a comment. Herald added a subscriber: Aklapper. I guess this can be closed? TASK DETAIL https://phabricator.wikimedia.org/T46117 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Wikidata-bugs, thiemowmde, JanZerebecki, aude, Lydia_Pintscher, daniel, hoo, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T106772: WikidataPageBanner tests should run with Wikibase
Jdlrobson added a comment. The problem I'm seeing is there is no entry for Wikidata in integration/config.git/zuul/ext_dependencies.py and I always get confused about the differences between WikibaseClient/Lib/View I feel like it is more complicated then adding 'Wikibase': ['WikidataPageBanner'] to ext_dependencies.py or is it really that easy? (note: I don't have much experience with setting up QA infrastructure) TASK DETAIL https://phabricator.wikimedia.org/T106772 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: hashar, JanZerebecki, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, greg, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T90733: Deploy changes_subscription table
hoo closed this task as Resolved. hoo claimed this task. hoo added a comment. This has been done quite some time ago. TASK DETAIL https://phabricator.wikimedia.org/T90733 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: hoo, aude, daniel, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher
hoo removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: gerritbot, Addshore, daniel, JanZerebecki, Aklapper, hoo, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T98029: Deploy PageBanner extension on English Wikivoyage project
Legoktm added a comment. I submitted a few small patches for code quality things. I haven't tested it myself, but is image usage being tracked in the imagelinks/globalimagelinks (through GlobalUsage) table? TASK DETAIL https://phabricator.wikimedia.org/T98029 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, Legoktm Cc: greg, matmarex, ssastry, Legoktm, csteipp, kaldari, Ricordisamoa, Krenair, Sumit, Nicolas_Raoul, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Raised Priority] T108101: Isolate wikidata.org cookies and CORS policies
Smalyshev raised the priority of this task from Normal to High. TASK DETAIL https://phabricator.wikimedia.org/T108101 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev Cc: Matanya, Addshore, Laddo, bd808, MBlissett, Krenair, waldyrious, JeroenDeDauw, JanZerebecki, aude, Aklapper, RobLa-WMF, daniel, Joe, BBlack, Smalyshev, gerritbot, Legoktm, jcrespo, csteipp, Lydia_Pintscher, greg, GWicke, hoo, JohnLewis, jkroll, Wikidata-bugs, Jdouglas, Manybubbles, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T104922: Deadlock in EntityUsageTable::addUsages
hoo added a comment. This is still a problem: hoo@fluorine:/a/mw-log$ zgrep -c UsageTrackerException archive/exception.log-2015080* archive/exception.log-20150801.gz:10 archive/exception.log-20150802.gz:2 archive/exception.log-20150803.gz:0 archive/exception.log-20150804.gz:40 archive/exception.log-20150805.gz:2 archive/exception.log-20150806.gz:2 TASK DETAIL https://phabricator.wikimedia.org/T104922 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: daniel, Aklapper, hoo, Wikidata-bugs, aude, Krenair, greg, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher
JanZerebecki removed a blocking task: T108255: mariadb: overflow results in silent truncation. TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: gerritbot, Addshore, daniel, JanZerebecki, Aklapper, hoo, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T108003: wb-entity-spinner: Uncaught ReferenceError: $ is not defined
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T108003 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, thiemowmde, Jonas, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T90115: BlazeGraph Security Review
Joe added a comment. @MoritzMuehlenhoff kernel upgrades should be doable relatively easily. If we want to be stricter about what the blazegraph user can do on the system, we can look into it too. I don't think network segregation is what we need here either. Alas, I don't see a general way of protecting us against malicious users creating DDOS-like queries, if not using a query killer (a thing we already sort-of do if the query takes more than N seconds, if I got it right). TASK DETAIL https://phabricator.wikimedia.org/T90115 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: csteipp, Joe Cc: ksmith, JanZerebecki, Bene, MoritzMuehlenhoff, GWicke, Thompsonbry.systap, Smalyshev, Joe, Liuxinyu970226, csteipp, Beebs.systap, Haasepeter, Aklapper, Manybubbles, jkroll, Wikidata-bugs, Jdouglas, aude, Krenair, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T103907: Develop external hardening rules for WDQS
gerritbot added a comment. Change 229584 merged by Giuseppe Lavagetto: https://phabricator.wikimedia.org/T103907: restrict further passed URLs https://gerrit.wikimedia.org/r/229584 TASK DETAIL https://phabricator.wikimedia.org/T103907 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Lydia_Pintscher, Ricordisamoa, Smalyshev, Aklapper, Manybubbles, Joe, jkroll, Wikidata-bugs, Jdouglas, aude, JanZerebecki, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T101088: Missing links on ceb: Wikipedia
hoo closed this task as Resolved. hoo claimed this task. hoo added a comment. I can't see any problems with cebwiki right now. This was probably some kind of temporary infrastructure problem which has been solved since. Purging the pages (`action=purge`) should also work, you don't need to edit the Wikidata items. TASK DETAIL https://phabricator.wikimedia.org/T101088 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: hoo, Lydia_Pintscher, Bugreporter, Thibaut120094, Vargenau, Aklapper, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher
JanZerebecki moved this task to consider for next sprint on the Wikidata workboard. TASK DETAIL https://phabricator.wikimedia.org/T108130 WORKBOARD https://phabricator.wikimedia.org/project/board/71/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: gerritbot, Addshore, daniel, JanZerebecki, Aklapper, hoo, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T72728: Extract text for filters code from EntityContent and ensure test coverage for it
hoo closed this task as Resolved. hoo claimed this task. hoo added a comment. This has long since been extracted into an own class with tests. TASK DETAIL https://phabricator.wikimedia.org/T72728 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Wikidata-bugs, Bene, aude, Lydia_Pintscher, hoo, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T85499: wbEntity shouldn't be served on every page load
hoo added a comment. All usages except for AuthorityControl can probably be easily switched without having to worry much. In case of AuthorityControl we need to be more careful: It's enabled per default, thus needs to be handled with care regarding potential performance issues. TASK DETAIL https://phabricator.wikimedia.org/T85499 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Legoktm, thiemowmde, ori, adrianheine, aude, Snaterlicious, Ricordisamoa, Aklapper, Jdlrobson, hoo, Wikidata-bugs, GWicke, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T95685: Drop wb_entity_per_page table
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 230035 had a related patch set uploaded (by Hoo man): Introduce WikiPageEntityRedirectLookup https://gerrit.wikimedia.org/r/230035 TASK DETAIL https://phabricator.wikimedia.org/T95685 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, hoo, Aklapper, daniel, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T95685: Drop wb_entity_per_page table
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T95685 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, hoo, Aklapper, daniel, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T47839: Not all language links showing up, manual purge required
Bugreporter added a comment. Another: https://zh.wikipedia.org/wiki/Wikipedia:%E5%82%80%E5%84%A1%E8%B4%A6%E6%88%B7%E7%9A%84%E7%89%B9%E7%82%B9 https://archive.is/5HVg6 https://www.wikidata.org/wiki/Q11056804 TASK DETAIL https://phabricator.wikimedia.org/T47839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bugreporter Cc: hoo, Bugreporter, Aklapper, FriedhelmW, wikibugs-l-list, Wikidata-bugs, Abraham, Nemo_bis, Silvonen, aude, Lydia_Pintscher, Stryn, UV, Unknown Object (MLST), Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T87524: Merge with conflicting sitelinks is not rejected
matej_suchanek added a comment. @hoo See - https://www.wikidata.org/w/index.php?title=Q16434239action=history - both merges weren't completed (done by Wikidata Game) - https://www.wikidata.org/w/index.php?title=Q16432215action=history - same case TASK DETAIL https://phabricator.wikimedia.org/T87524 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek Cc: matej_suchanek, Ricordisamoa, Liuxinyu970226, aude, daniel, hoo, Addshore, petr.matas, Aklapper, Wikidata-bugs, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T95685: Drop wb_entity_per_page table
gerritbot added a comment. Change 230036 had a related patch set uploaded (by Hoo man): Remove EntityPerPageTable::getPageIdForEntityId https://gerrit.wikimedia.org/r/230036 TASK DETAIL https://phabricator.wikimedia.org/T95685 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, hoo, Aklapper, daniel, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T108252: EntityAccessor::getEntity should fail gracefully on double redirects
JanZerebecki moved this task to Done on the Wikidata-Sprint-2015-06-30 workboard. TASK DETAIL https://phabricator.wikimedia.org/T108252 WORKBOARD https://phabricator.wikimedia.org/project/board/1337/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: gerritbot, Sjoerddebruin, JanZerebecki, aude, daniel, Aklapper, hoo, Wikidata-bugs, Krenair, greg, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T93885: Implement a limit for entities accessed via arbitrary access features and mark as expensive
hoo added a blocking task: T106190: {{#property:…}} parser function should
enforce the parser's restricted function limit.
TASK DETAIL
https://phabricator.wikimedia.org/T93885
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: hoo
Cc: gerritbot, Anomie, hoo, Danmichaelo, daniel, Ltrlg, zhuyifei1999, Stryn,
MF-Warburg, Lydia_Pintscher, Laddo, Chmarkine, Ainali, Pietrodn, Florian,
Liuxinyu970226, Snipre, Multichill, Yann, geraki, Mvolz, Ash_Crow, Hkjacksonhk,
Aklapper, MZMcBride, Jarekt, Ricordisamoa, Aubrey, Cwek, matej_suchanek, Qgil,
aude, Micru, Denny, jayvdb, Bennylin, Filceolaire, ValterVB, Daniel_Mietchen,
He7d3r, mxn, Addshore, HenkvD, Jasper, JulesWinnfield-hu, Abraham, Kersti,
Rical, Wikidata-bugs, -jem-, RP88, jeremyb, Dr_Brains, Pengo, Reaper35,
Eloquence, adrianheine, Candalua, Rschen7754, Malyacko
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T106190: {{#property:…}} parser function should enforce the parser's restricted function limit
hoo added a blocked task: T93885: Implement a limit for entities accessed via arbitrary access features and mark as expensive. TASK DETAIL https://phabricator.wikimedia.org/T106190 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Ricordisamoa, Aklapper, Lydia_Pintscher, hoo, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T105432: Make wikibase:quantityUnit an URI
JanZerebecki moved this task to Done on the Wikidata-Sprint-2015-06-30 workboard. TASK DETAIL https://phabricator.wikimedia.org/T105432 WORKBOARD https://phabricator.wikimedia.org/project/board/1337/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev, JanZerebecki Cc: gerritbot, mkroetzsch, daniel, Aklapper, Smalyshev, jkroll, Wikidata-bugs, Jdouglas, aude, Manybubbles, JanZerebecki, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T106192: {{#property:…}} parser function should only increase the parser's restricted function limit once per entity
JanZerebecki moved this task to Review on the Wikidata-Sprint-2015-06-30 workboard. TASK DETAIL https://phabricator.wikimedia.org/T106192 WORKBOARD https://phabricator.wikimedia.org/project/board/1337/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: gerritbot, hoo, Lydia_Pintscher, Aklapper, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T106192: {{#property:…}} parser function should only increase the parser's restricted function limit once per entity
JanZerebecki added a project: Wikidata-Sprint-2015-06-30. JanZerebecki set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T106192 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: gerritbot, hoo, Lydia_Pintscher, Aklapper, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T108252: EntityAccessor::getEntity should fail gracefully on double redirects
gerritbot added a comment. Change 229992 merged by jenkins-bot: Fail gracefully when hitting double redirects in client DataAccess https://gerrit.wikimedia.org/r/229992 TASK DETAIL https://phabricator.wikimedia.org/T108252 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Sjoerddebruin, JanZerebecki, aude, daniel, Aklapper, hoo, Wikidata-bugs, Krenair, greg, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T98029: Deploy PageBanner extension on English Wikivoyage project
Jdlrobson added a comment. Good question @legoktm .. unless it happens automagically I suspect not. Can you open a task with instructions on how to check / implement that? Thanks for the patches - I will take a look! TASK DETAIL https://phabricator.wikimedia.org/T98029 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: greg, matmarex, ssastry, Legoktm, csteipp, kaldari, Ricordisamoa, Krenair, Sumit, Nicolas_Raoul, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T72127: Error messages for Special:GoToLinkedPage when requested target doesn't exist
JanZerebecki moved this task to Done on the Wikidata-Sprint-2015-06-30 workboard. TASK DETAIL https://phabricator.wikimedia.org/T72127 WORKBOARD https://phabricator.wikimedia.org/project/board/1337/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: gerritbot, Jonas, Aklapper, Legoktm, Wikidata-bugs, Bene, -jem-, JanZerebecki, Qgil, Lydia_Pintscher, aude, 01tonythomas, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T105824: Remove rdf:type wikibase:Value and leave only specific value class on values
JanZerebecki moved this task to Done on the Wikidata-Sprint-2015-06-30 workboard. TASK DETAIL https://phabricator.wikimedia.org/T105824 WORKBOARD https://phabricator.wikimedia.org/project/board/1337/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev, JanZerebecki Cc: gerritbot, daniel, mkroetzsch, Aklapper, Smalyshev, jkroll, Wikidata-bugs, Jdouglas, aude, Manybubbles, JanZerebecki, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Declined] T70377: Write migration script for schema changes to entity_per_page table
hoo added a subscriber: hoo. hoo closed this task as Declined. hoo claimed this task. hoo added a comment. No longer needed after https://phabricator.wikimedia.org/T95685 TASK DETAIL https://phabricator.wikimedia.org/T70377 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: hoo, Wikidata-bugs, Tobi_WMDE_SW, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T58712: Update entity_per_page table so it does not have a numeric entity id
hoo closed blocking task T70377: Write migration script for schema changes to entity_per_page table as Declined. Herald added a subscriber: Aklapper. TASK DETAIL https://phabricator.wikimedia.org/T58712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Wikidata-bugs, Tobi_WMDE_SW, Lydia_Pintscher, daniel, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Declined] T58712: Update entity_per_page table so it does not have a numeric entity id
hoo added a subscriber: hoo. hoo closed this task as Declined. hoo claimed this task. hoo added a comment. No longer needed after https://phabricator.wikimedia.org/T95685 TASK DETAIL https://phabricator.wikimedia.org/T58712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: hoo, Aklapper, Wikidata-bugs, Tobi_WMDE_SW, Lydia_Pintscher, daniel, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T108252: EntityAccessor::getEntity should fail gracefully on double redirects
JanZerebecki closed this task as Resolved. JanZerebecki added a project: Wikidata-Sprint-2015-06-30. TASK DETAIL https://phabricator.wikimedia.org/T108252 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: gerritbot, Sjoerddebruin, JanZerebecki, aude, daniel, Aklapper, hoo, Wikidata-bugs, Krenair, greg, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T104876: wbparsevalue should use datatype to identify parser
JanZerebecki moved this task to Done on the Wikidata-Sprint-2015-06-30 workboard. TASK DETAIL https://phabricator.wikimedia.org/T104876 WORKBOARD https://phabricator.wikimedia.org/project/board/1337/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, JanZerebecki Cc: Jc3s5h, Lydia_Pintscher, daniel, aude, thiemowmde, Aklapper, WMDE-Fisch, Tobi_WMDE_SW, gerritbot, Wikidata-bugs, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T108252: EntityAccessor::getEntity should fail gracefully on double redirects
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 229992 had a related patch set uploaded (by Hoo man): Fail gracefully when hitting double redirects in client DataAccess https://gerrit.wikimedia.org/r/229992 TASK DETAIL https://phabricator.wikimedia.org/T108252 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Sjoerddebruin, JanZerebecki, aude, daniel, Aklapper, hoo, Wikidata-bugs, Krenair, greg, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T96579: EPIC: Deploy Wikidata Query 0.1 Release in labs as official service
Liuxinyu970226 removed a subscriber: Liuxinyu970226. TASK DETAIL https://phabricator.wikimedia.org/T96579 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Deskana, Liuxinyu970226 Cc: Daniel_Mietchen, -jem-, phuedx, JKatzWMF, Deskana, ksmith, Smalyshev, Aklapper, Manybubbles, jkroll, Wikidata-bugs, Jdouglas, aude, JanZerebecki, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T77925: Wikidata PageBanner extension
Jdlrobson added a comment. @NiharikaKohli we're looking to get this deployed on Wikivoyage.org next week. Potentially this could be a good project to feature in your post. @sumit has done a great job, and hopefully the deploy will go well without too many hiccups and there will be a happy community benefiting from it. You can see a sneak preview on: http://pagebanner.wmflabs.org/wiki/Agra TASK DETAIL https://phabricator.wikimedia.org/T77925 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Jdlrobson Cc: Liuxinyu970226, Wrh2, Bene, Nastoshka, zhuyifei1999, Sushrutsg, Andyrom75, Danapit, Glaisher, NiharikaKohli, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, LtPowers, Aklapper, Florian, Lydia_Pintscher, KLans_WMF, Jdlrobson, Imaculate, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T95685: Drop wb_entity_per_page table
hoo added a comment. I looked at this a bit today and this is quite doable, except for a few things which are really awry (eg fix `EntityPerPageTable::getEntitiesWithoutTerm` is not going to be super nice). We should start by (step by step) removing the usages of the table, announce that the table is going away (so that tool authors etc. can adopt their tools) and after a certain grace period stop updating the table and then drop it. TASK DETAIL https://phabricator.wikimedia.org/T95685 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: hoo, Aklapper, daniel, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T74907: move git repositories that are dependencies of wikidata to gerrit
JanZerebecki added a comment. In https://phabricator.wikimedia.org/T74907#1483021, @Tpt wrote: But I believe that if we move some of these libs out of GitHub we will maybe miss contributions of external users that may use this libs for other use cases than Wikibase itself and that may be not already users of Gerrit/Phabricator. They will continue to be mirrored to github, like all repos hosted on gerrit.w.o. They move to the wikimedia github organisation and possibly get a different name. github seems to leave behind redirects for each move/rename. So, I think that we should keep libs with external users (DataValues, WikibaseDataModel, Diff, Serialization...) on GitHub in a unified location. They are currently split over a few github organisations. Should we unify the location, for those repos that don't get moved to gerrit? TASK DETAIL https://phabricator.wikimedia.org/T74907 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: Tpt, Lazowik, Bene, Addshore, Liuxinyu970226, Ricordisamoa, chasemp, mmodell, Abraham, Aklapper, thiemowmde, Qgil, Snaterlicious, daniel, adrianheine, Tobi_WMDE_SW, GPHemsley, Legoktm, JeroenDeDauw, JanZerebecki, aude, MZMcBride, Lydia_Pintscher, Dereckson, hoo, Wikidata-bugs, greg, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T106192: {{#property:…}} parser function should only increase the parser's restricted function limit once per entity
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T106192 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, hoo, Lydia_Pintscher, Aklapper, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T106192: {{#property:…}} parser function should only increase the parser's restricted function limit once per entity
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 230015 had a related patch set uploaded (by Hoo man): Only increase the expensive parser function count once per entity https://gerrit.wikimedia.org/r/230015 TASK DETAIL https://phabricator.wikimedia.org/T106192 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, hoo, Lydia_Pintscher, Aklapper, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T108003: wb-entity-spinner: Uncaught ReferenceError: $ is not defined
hoo added a subscriber: hoo. hoo added a comment. Maybe we should just remove the spinner? It's a left over from back when we were basically re-building the whole DOM in JS. I don't think it serves much of a purpose now. TASK DETAIL https://phabricator.wikimedia.org/T108003 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: hoo, gerritbot, thiemowmde, Jonas, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T108003: wb-entity-spinner: Uncaught ReferenceError: $ is not defined
Jonas added a subscriber: Lydia_Pintscher. Jonas set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T108003 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas Cc: Lydia_Pintscher, hoo, gerritbot, thiemowmde, Jonas, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T72127: Error messages for Special:GoToLinkedPage when requested target doesn't exist
Jonas closed this task as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T72127 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas Cc: gerritbot, Jonas, Aklapper, Legoktm, Wikidata-bugs, Bene, -jem-, JanZerebecki, Qgil, Lydia_Pintscher, aude, 01tonythomas, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T72127: Error messages for Special:GoToLinkedPage when requested target doesn't exist
gerritbot added a comment. Change 228810 merged by jenkins-bot: Error message for Special:GoToLinkedPage https://gerrit.wikimedia.org/r/228810 TASK DETAIL https://phabricator.wikimedia.org/T72127 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Jonas, Aklapper, Legoktm, Wikidata-bugs, Bene, -jem-, JanZerebecki, Qgil, Lydia_Pintscher, aude, 01tonythomas, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it
brion added a comment. But yeah that code'll have to run on both. Feel free to ping me for review etc TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brion Cc: brion, gerritbot, Jdlrobson, Sumit, Aklapper, Wikidata-bugs, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T103907: Develop external hardening rules for WDQS
Smalyshev closed this task as Resolved. Smalyshev claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T103907 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev Cc: gerritbot, Lydia_Pintscher, Ricordisamoa, Smalyshev, Aklapper, Manybubbles, Joe, jkroll, Wikidata-bugs, Jdouglas, aude, JanZerebecki, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T85159: [EPIC] Deploy a Wikidata Query Service into production
Smalyshev closed blocking task T103907: Develop external hardening rules for WDQS as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T85159 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev Cc: Addshore, Laddo, bd808, MBlissett, Krenair, waldyrious, JeroenDeDauw, JanZerebecki, aude, Aklapper, RobLa-WMF, daniel, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, Manybubbles, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T96579: EPIC: Deploy Wikidata Query 0.1 Release in labs as official service
Deskana closed blocking task T102312: Figure out monitoring/alerting setup for labs as Declined. TASK DETAIL https://phabricator.wikimedia.org/T96579 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Deskana Cc: Daniel_Mietchen, -jem-, Liuxinyu970226, phuedx, JKatzWMF, Deskana, ksmith, Smalyshev, Aklapper, Manybubbles, jkroll, Wikidata-bugs, Jdouglas, aude, JanZerebecki, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T93885: Implement a limit for entities accessed via arbitrary access features and mark as expensive
daniel added a comment. With Change 225474 merged, we now report the number of entities loaded, but the limit we impose is INT_MAX. I suppose this should remain open until we have a configurable limited implemented and a good default defined. TASK DETAIL https://phabricator.wikimedia.org/T93885 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, daniel Cc: gerritbot, Anomie, hoo, Danmichaelo, daniel, Ltrlg, zhuyifei1999, Stryn, MF-Warburg, Lydia_Pintscher, Laddo, Chmarkine, Ainali, Pietrodn, Florian, Liuxinyu970226, Snipre, Multichill, Yann, geraki, Mvolz, Ash_Crow, Hkjacksonhk, Aklapper, MZMcBride, Jarekt, Ricordisamoa, Aubrey, Cwek, matej_suchanek, Qgil, aude, Micru, Denny, jayvdb, Bennylin, Filceolaire, ValterVB, Daniel_Mietchen, He7d3r, mxn, Addshore, HenkvD, Jasper, JulesWinnfield-hu, Abraham, Kersti, Rical, Wikidata-bugs, -jem-, RP88, jeremyb, Dr_Brains, Pengo, Reaper35, Eloquence, adrianheine, Candalua, Rschen7754, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it
brion added a comment. If http://caniuse.com/#feat=srcset is to be believed, the main problem browser on mobile is going to be Safari on iOS 8, since it supports native srcset but only for density switching, not for the size specifications. So if you use a customized polyfill, you can't rely on the basic test like img.srcset !== undefined... Probably ok to go ahead and use a customized polyfill for the banners; use data-srcset or something in place of the native srcset attribute so iOS 8 doesn't start downloading the giant image! I would probably recommend updating jquery.hidpi.js to support width/height specs rather than including a second polyfill. TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brion Cc: brion, gerritbot, Jdlrobson, Sumit, Aklapper, Wikidata-bugs, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it
Jdlrobson added a comment. This is desktop AND mobile so the impact is a little greater.. :-/ TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: brion, gerritbot, Jdlrobson, Sumit, Aklapper, Wikidata-bugs, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T108003: wb-entity-spinner: Uncaught ReferenceError: $ is not defined
Jonas closed this task as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T108003 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas Cc: Lydia_Pintscher, hoo, gerritbot, thiemowmde, Jonas, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T105638: RFC: Streamlining Composer usage
csteipp added a comment. 1 2 are probably related, so I'll add some comment here. Happy to move to another forum if needed. The threats I've seen laid out, and my (very rough) evaluation of their risk. Happy to be corrected if it seems like I have assumptions that are wrong, or you disagree with my likelihood/impact score. 1. **MITM between composer and packagist** - in my estimation, this has both High likelihood and High impact. It's a trivial technical attack to pull off without composer checking certificates, and allows the attacker to link their own, modified version of any library into the composed codebase. 1. Risk: (using high = 3, med = 2, low = 1, and risk = likelihood x impact ), then 3 x 3 = 9 2. Mitigation: Currently none (adding https certificate checking in composer and requiring all connections to be https shouldn't be too difficult to add and upstream) 2. **MITM between composer and packagist with valid packagist certificate** - In the event that composer start validating the https connection's certificate, is that enough? In my estimation, this is a fairly difficult attack to pull off, for a someone attacking the WMF's infrastructure, so I put the likelihood at Low. For normal developers running `composer update` on their laptop, this is still moderate, since buying an SSL MITM proxy that contains a code-signing certificate is fairly expensive still, so I'm going to say likelihood is Low to Medium. This has the same impact as #1. 1. Risk: Low-Medium (1.5) x High (3) = 4.5 2. Mitigation: Currently none (adding certificate pinning to composer would me moderately expensive, since it doesn't seem that composer would maintain that upstream) 3. **Github is compromised (the entire organization)** - in my estimation, compromising github would be a difficult. They have a security team that seems to be making reasonable choices currently. So I'd guess the likelihood is Low. The impact, aiui, would be High for normal composer usage (where just the tarball of a repo at a certain commit is downloaded, and does not appear to be integrity checked). If composer does get a checksum that it checks, or composer is setup to clone the repo and checkout a sha1-hash (which seems to be hard to forge), the the impact would be reduced. 1. Risk: Low (1) x High? (3) = 3? 2. Mitigation: Currently none (adding certificate pinning to composer would me moderately expensive, since it doesn't seem that composer would maintain that upstream) 4. **Packagist is compromised (the entire organization)** - Packagist concerns me a little more, since I don't know anything about their operational security. I'll do some quick research on that, or if anyone has a citation, happy to evaluate. The impact would again be High, because a attacker could add any code to any library by pointing to their own version of it. 1. Risk: ? x High (3) = ? 2. Mitigation: unknown 5. **Github repo is compromised by owner accepting hostile pull request** - The likelihood seems Low to me, since if we've determined the library is of sufficient quality to include in our codebase (A MediaWiki developer has decided this is a good library to include, and the library has passed security review by my team), then I (hope) it's unlikely they would accept a malicious pull request. If it did happen, impact would be High, however. 1. Risk: Low (1) x High (3) = 3 2. Mitigation: Vetting of libraries included in MediaWiki (developer review, security review), updates to vendor are code reviewed 6. **Github repo is compromised by owner having their password stolen** - Github mitigates this with things like mandatory https with HSTS, using OAuth to interact with other services, optional 2-factor authentication for accounts, review and expiration of potentially unsafe ssh keys. However, assuming may library owners are not going to take advantage of the optional security features, we can probably call the likelihood Medium, and the impact High, since it would allow the attacker to add any code to the repo. 1. Risk: Medium (2) x High (3) = 6 2. Mitigation: Updates to vendor are code reviewed TASK DETAIL https://phabricator.wikimedia.org/T105638 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, csteipp Cc: Spage, greg, tstarling, aude, hoo, daniel, zeljkofilipin, thcipriani, mmodell, bd808, csteipp, Legoktm, Krinkle, hashar, JanZerebecki, Aklapper, Lynhg, Wikidata-bugs, Malyacko, GWicke, Qgil, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T108214: Remove margin-top from .wpb-topbanner in mobile skin
Jdlrobson created this task.
Jdlrobson added a subscriber: Jdlrobson.
Jdlrobson added a project: Wikidata-Page-Banner.
Jdlrobson moved this task to July 19-August 10 on the Wikidata-Page-Banner
workboard.
Herald added a subscriber: Aklapper.
Herald added a project: Wikidata.
TASK DESCRIPTION
The banner is pushed too far down from the screen{F643837}
Remove the top margin on mobile skin.
TASK DETAIL
https://phabricator.wikimedia.org/T108214
WORKBOARD
https://phabricator.wikimedia.org/project/board/1158/
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jdlrobson
Cc: Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T93885: Implement a limit for entities accessed via arbitrary access features and mark as expensive
gerritbot added a comment. Change 225474 merged by jenkins-bot: Introduce a RestrictedEntityLookup for client DataAccess https://gerrit.wikimedia.org/r/225474 TASK DETAIL https://phabricator.wikimedia.org/T93885 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, gerritbot Cc: gerritbot, Anomie, hoo, Danmichaelo, daniel, Ltrlg, zhuyifei1999, Stryn, MF-Warburg, Lydia_Pintscher, Laddo, Chmarkine, Ainali, Pietrodn, Florian, Liuxinyu970226, Snipre, Multichill, Yann, geraki, Mvolz, Ash_Crow, Hkjacksonhk, Aklapper, MZMcBride, Jarekt, Ricordisamoa, Aubrey, Cwek, matej_suchanek, Qgil, aude, Micru, Denny, jayvdb, Bennylin, Filceolaire, ValterVB, Daniel_Mietchen, He7d3r, mxn, Addshore, HenkvD, Jasper, JulesWinnfield-hu, Abraham, Kersti, Rical, Wikidata-bugs, -jem-, RP88, jeremyb, Dr_Brains, Pengo, Reaper35, Eloquence, adrianheine, Candalua, Rschen7754, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T96029: Special:ItemByTitle does not show an error for invalid site id
gerritbot added a comment. Change 229129 merged by jenkins-bot: Special:ItemByTitle error messages https://gerrit.wikimedia.org/r/229129 TASK DETAIL https://phabricator.wikimedia.org/T96029 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, aude, Aklapper, Wikidata-bugs, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T102312: Figure out monitoring/alerting setup for labs
Smalyshev moved this task to Done on the Discovery-Wikidata-Query-Service-Sprint workboard. TASK DETAIL https://phabricator.wikimedia.org/T102312 WORKBOARD https://phabricator.wikimedia.org/project/board/1239/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Deskana, Smalyshev Cc: Deskana, yuvipanda, Aklapper, Smalyshev, jkroll, Wikidata-bugs, Jdouglas, aude, Manybubbles, JanZerebecki, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T108003: wb-entity-spinner: Uncaught ReferenceError: $ is not defined
gerritbot added a comment. Change 229680 merged by jenkins-bot: Moves entity spinner to entityViewinit https://gerrit.wikimedia.org/r/229680 TASK DETAIL https://phabricator.wikimedia.org/T108003 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Lydia_Pintscher, hoo, gerritbot, thiemowmde, Jonas, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Declined] T102312: Figure out monitoring/alerting setup for labs
Deskana closed this task as Declined. Deskana claimed this task. Deskana added a comment. I'm declining this, since we're focussing on getting the service into production instead. TASK DETAIL https://phabricator.wikimedia.org/T102312 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Deskana Cc: Deskana, yuvipanda, Aklapper, Smalyshev, jkroll, Wikidata-bugs, Jdouglas, aude, Manybubbles, JanZerebecki, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher
hoo added a comment. I poked at this some more and iterated over all changes currently in the DB using very similar code to what we use in Wikibase and the change ids mentioned above are the only ones failing. TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: gerritbot, Addshore, daniel, JanZerebecki, Aklapper, hoo, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T50684: Wikidata's Watchlist in wikipedia are like read Watchlist
MGChecker added a subscriber: MGChecker. Herald added a subscriber: Aklapper. TASK DETAIL https://phabricator.wikimedia.org/T50684 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: MGChecker Cc: Aklapper, MGChecker, Wikidata-bugs, thiemowmde, Yamaha5, Lucie, Lydia_Pintscher, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it
Jdlrobson added a comment. Thanks @brion for the quick response! You read correctly. Right now we're using srcset attribute to serve the best sized banner depending on the user's current browser window. The plan is to point the src attribute to the lowest res image but we're keen to use a nicer image in desktop/tablet browsers without srcset support. I think thus the 2 image downloads is not a big problem here. css is currently not a solution as the banners are all custom and generated via wikitext and served in an img tag. Do you think it's worth pulling in a poly fill this purpose? The other alternative is loading a larger higher quality image on non-mobile browsers that do not support srcset but that seems equally nasty :-/ TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: brion, gerritbot, Jdlrobson, Sumit, Aklapper, Wikidata-bugs, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher
hoo added a comment. In https://phabricator.wikimedia.org/T108130#1514967, @JanZerebecki wrote: Perhaps make it LONGBLOB so that it can hold more than the entity that is stored in a MEDIUMBLOB. Mh... maybe. Also, do we need to resize the rc_params field as well? TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: gerritbot, Addshore, daniel, JanZerebecki, Aklapper, hoo, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T103907: Develop external hardening rules for WDQS
Smalyshev moved this task to Done on the Discovery-Wikidata-Query-Service-Sprint workboard. TASK DETAIL https://phabricator.wikimedia.org/T103907 WORKBOARD https://phabricator.wikimedia.org/project/board/1239/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev Cc: gerritbot, Lydia_Pintscher, Ricordisamoa, Smalyshev, Aklapper, Manybubbles, Joe, jkroll, Wikidata-bugs, Jdouglas, aude, JanZerebecki, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T108207: Allow editors to define links to topics an icon refers to
Sumit created this task. Sumit added subscribers: Sumit, Jdlrobson. Sumit added a project: Wikidata-Page-Banner. Sumit moved this task to June 26-July 18 on the Wikidata-Page-Banner workboard. Herald added a subscriber: Aklapper. Herald added a project: Wikidata. TASK DESCRIPTION Allow defining links with icon names in the format icons=star[Star article] which would add a link to star icon to the Star article on the wiki. TASK DETAIL https://phabricator.wikimedia.org/T108207 WORKBOARD https://phabricator.wikimedia.org/project/board/1158/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit Cc: Jdlrobson, Sumit, Aklapper, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T108207: Allow editors to define links to topics an icon refers to
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 229759 had a related patch set uploaded (by Sumit): WikidataPageBanner add link to icons https://gerrit.wikimedia.org/r/229759 TASK DETAIL https://phabricator.wikimedia.org/T108207 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Jdlrobson, Sumit, Aklapper, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T108207: Allow editors to define links to topics an icon refers to
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T108207 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Jdlrobson, Sumit, Aklapper, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it
brion added a comment. Well, desktop isn't as big a worry since high-res screen usually means large screen (and you'll usually max out at 2, rather than the 3 that some phones like the iPhone 6plus reach)... :) So it should be safe there to load the 1x and then polyfill-load the native-density-except-on-small-screen. TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brion Cc: brion, gerritbot, Jdlrobson, Sumit, Aklapper, Wikidata-bugs, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher
gerritbot added a comment. Change 229741 merged by jenkins-bot: Log when we fail unserializeInfo https://gerrit.wikimedia.org/r/229741 TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Addshore, daniel, JanZerebecki, Aklapper, hoo, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T72209: Create a special page to query for badges
Jonas added a subscriber: Jonas. Herald added a subscriber: Aklapper. TASK DETAIL https://phabricator.wikimedia.org/T72209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, Jonas Cc: Jonas, Aklapper, Kopiersperre, jayvdb, Opraco, putnik, AlessioMela, Horcrux92, ValterVB, Rotpunkt, Bultro, Incola, Billinghurst, Magioladitis, Wikidata-bugs, Bene, He7d3r, Qgil, Ricordisamoa, Jbribeiro1, Ladsgroup, Liuxinyu970226, Lydia_Pintscher, Stryn, Ltrlg, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Merged] T107776: Error on saving change of label and description, violation of constraint
matej_suchanek closed this task as a duplicate of T106456: Editing label and description simultaneously conflicts with existing items which have the new label and old description. TASK DETAIL https://phabricator.wikimedia.org/T107776 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek Cc: Nikki, Addshore, jeblad, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T104806: hideanons=1 on Special:recentchanges hides all wikidata changes including edits done by registered users on wikidata
matej_suchanek added a blocked task: T90435: Wikidata watchlist integration (tracking). TASK DETAIL https://phabricator.wikimedia.org/T104806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek Cc: Merl, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T90435: Wikidata watchlist integration (tracking)
matej_suchanek added a blocking task: T104806: hideanons=1 on Special:recentchanges hides all wikidata changes including edits done by registered users on wikidata. TASK DETAIL https://phabricator.wikimedia.org/T90435 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek Cc: matej_suchanek, MGChecker, Sitic, JanZerebecki, Conny, Snaterlicious, Liuxinyu970226, Quiddity, Rschen7754, Ainali, MisterSynergy, Lydia_Pintscher, Aklapper, daniel, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T104806: hideanons=1 on Special:recentchanges hides all wikidata changes including edits done by registered users on wikidata
MGChecker added a subscriber: MGChecker. TASK DETAIL https://phabricator.wikimedia.org/T104806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: MGChecker Cc: MGChecker, Merl, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T105456: Deal with 'anchored' labels
matej_suchanek added a project: Wikidata.org. TASK DETAIL https://phabricator.wikimedia.org/T105456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, matej_suchanek Cc: Ladsgroup, matej_suchanek, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T106456: Editing label and description simultaneously conflicts with existing items which have the new label and old description
matej_suchanek added subscribers: Addshore, jeblad. matej_suchanek merged a task: T107776: Error on saving change of label and description, violation of constraint. TASK DETAIL https://phabricator.wikimedia.org/T106456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek Cc: jeblad, Addshore, Fomafix, Nikki, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T106456: Editing label and description simultaneously conflicts with existing items which have the new label and old description
matej_suchanek added a project: MediaWiki-extensions-WikibaseRepository. matej_suchanek set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T106456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek Cc: jeblad, Addshore, Fomafix, Nikki, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T101950: Goal: Establish a framework to engage with data engineers and open data organizations
DarTar added a subscriber: Daniel_Mietchen. TASK DETAIL https://phabricator.wikimedia.org/T101950 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Qgil, DarTar Cc: Daniel_Mietchen, ezachte, Rogol_Domedonfors, Ilario, Ricordisamoa, Hjfocs, Jane023, I9606, Scott_WUaS, Abraham, Susannaanas, Multichill, Smalyshev, Romaine, Wittylama, Sadads, Yair_rand, Lydia_Pintscher, SVentura, Qgil, Aklapper, Wikidata-bugs, aude, Gryllida, Rfarrand, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T90115: BlazeGraph Security Review
Smalyshev added a comment. Limit memory usage of queries yes Limit maximum duration of queries yes Parsing the AST of the query to filter malicious queries No. We have a capability of doing AST filter (we actually have one already implementing label service) but we don't have any query filter. The main reason is we don't know which queries would be malicious - i.e. right now we don't have any data on what we need to filter out. In theory, we know some queries make no sense and would only cause load, but in practice, we don't have (yet) any real examples of queries that might do harm. If we identify such queries, we can probably add filtering for them. It also seems useful to limit the number of parallel queries per IP. I think as it gets to the servers, we don't have much info on the originating IP, as we will be talking to Varnish frontends. So it may be needed to be implemented on Varnish side? Or Varnish passes us some info on that? We can implement a number of countermeasures to contain an attacker leveraging code injection inside BlazeGraph or through the JVM with the privileges What kind of measures do you propose? TASK DETAIL https://phabricator.wikimedia.org/T90115 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: csteipp, Smalyshev Cc: ksmith, JanZerebecki, Bene, MoritzMuehlenhoff, GWicke, Thompsonbry.systap, Smalyshev, Joe, Liuxinyu970226, csteipp, Beebs.systap, Haasepeter, Aklapper, Manybubbles, jkroll, Wikidata-bugs, Jdouglas, aude, Krenair, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T77925: Wikidata PageBanner extension
NiharikaKohli added a comment. Hello! End of GSoC is fast approaching. 17 August is Suggested pencils down deadline and 21 August is Firm pencils down deadline. It is expected that you don't dive into new features which might take longer than two weeks to complete and instead work on polishing up your project, testing thoroughly and getting your code merged into the main branch. I hope this project is almost complete so you can merge it and make it available to everyone as quickly as possible. :) A few questions (for both mentors and student): - Are you confident in completing the project on time? - By when do you think you can merge the code, if at all? - Are there any major blockers or important missing features? We are looking for projects which are (nearly) complete to feature on our post on Wikimedia and Google OSPO's blogs (for example: http://google-opensource.blogspot.in/2015/02/google-summer-of-code-wrap-up-processing.html). If you're interested in getting yours up there, hurry up and get this finished! The hard deadline on getting code merged is September. T101393: Goal: All completed GSoC and Outreachy projects have code merged and deployed by September https://phabricator.wikimedia.org/T101393 for details. We'll be asking the students to demo their projects towards the end of the program as well. Good luck! TASK DETAIL https://phabricator.wikimedia.org/T77925 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, NiharikaKohli Cc: Liuxinyu970226, Wrh2, Bene, Nastoshka, zhuyifei1999, Sushrutsg, Andyrom75, Danapit, Glaisher, NiharikaKohli, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, LtPowers, Aklapper, Florian, Lydia_Pintscher, KLans_WMF, Jdlrobson, Imaculate, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T107709: Disable Collection generation for non-wikitext content models
MGChecker added a subscriber: MGChecker. TASK DETAIL https://phabricator.wikimedia.org/T107709 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: MGChecker Cc: MGChecker, Addshore, cscott, hoo, Krenair, Aklapper, Matanya, Raymond, Wikidata-bugs, aude, Jackmcbarn, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher
JanZerebecki added a comment. [wikidatawiki] select length(change_info) from wb_changes where change_id in (236998945, 236999268, 237059314, 237059627) ; +-+ | length(change_info) | +-+ | 65535 | | 65535 | | 65535 | | 65535 | +-+ 4 rows in set (0.00 sec) A BLOB column with a maximum length of 65,535 (216 - 1) bytes - https://mariadb.com/kb/en/mariadb/blob/ At some point I checked what the then current MySQL does when you insert longer values, in default settings it gave no error and just cut it off. Seems that happened here. Fix our MariaDB settings or add checks everywhere for length? Move to MEDIUMBLOB? TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: Addshore, daniel, JanZerebecki, Aklapper, hoo, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Addshore, daniel, JanZerebecki, Aklapper, hoo, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T103070: find extensions using code directly from Wikibase and provide mechanism with a stable interface
JanZerebecki added a comment. What from that sentence is it that you don't understand? Do you have a question? This task is about people using code from Wikidata.git or mediawiki/vendor.git inapropriately: 1. People using a package private interface (e.g. something from Wikibase.git), then we change it and as people don't write tests their code breaks in production. 2. People using a library obtained via composer without depending on it. Their code breaking in production when we upgrade. TASK DETAIL https://phabricator.wikimedia.org/T103070 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: JeroenDeDauw, Legoktm, daniel, aude, Lydia_Pintscher, JanZerebecki, Aklapper, hoo, Wikidata-bugs, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
