[Wikidata-bugs] [Maniphest] [Commented On] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
Ladsgroup added a comment. In T164173#3413805, @Krinkle wrote: PageUpdater::purgeParserCache() -> foreach titles: Title::invalidateCache() My patch adds waitForReplication() to this. PageUpdater::purgeWebCache() -> foreach titles: Title::purgeSquid() I'm not sure about adding waitForReplication here, I checked the code and couldn't find any place that it changes database. Correct me if I'm wrong PageUpdater::scheduleRefreshLinks() -> foreach titles: JobQueueGroup->push( new RefreshLinksJob ) RefreshLinksJob has waitForReplication() already PageUpdater::injectRCRecords() -> foreach titles: Recentchange::save() My patch adds waitForReplication() to this.TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: gerritbot, Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Minhnv-2809, Zppix, Maathavan, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Minhnv-2809, Zppix, Maathavan, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
gerritbot added a comment. Change 364094 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/Wikibase@master] Wait for replication after macking changes in WikiPageUpdater https://gerrit.wikimedia.org/r/364094TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Minhnv-2809, Zppix, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
Ladsgroup claimed this task.Ladsgroup added projects: MediaWiki-extensions-WikibaseClient, Wikidata-Sprint.Herald added a project: User-Ladsgroup. TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Minhnv-2809, Zppix, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T125500: Index Wikidata labels and descriptions as separate fields in ElasticSearch
Ladsgroup added a comment. @daniel: Done. I also imported around 500 events (chemical elements are too heavy to import)TASK DETAILhttps://phabricator.wikimedia.org/T125500EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, LadsgroupCc: Ladsgroup, Sjoerddebruin, dcausse, Jonas, gerritbot, JanZerebecki, daniel, thiemowmde, Tobi_WMDE_SW, Smalyshev, Aklapper, StudiesWorld, Deskana, aude, Ricordisamoa, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, Avner, Lewizho99, Maathavan, debt, Gehel, Jdrewniak, FloNight, Izno, Wikidata-bugs, jayvdb, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T125500: Index Wikidata labels and descriptions as separate fields in ElasticSearch
daniel added a subscriber: Ladsgroup.daniel added a comment. Thanks for the fix @Smalyshev! @Ladsgroup can you update the elastic test site so it uses the latest master branch, so we can test this? Thanks!TASK DETAILhttps://phabricator.wikimedia.org/T125500EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, danielCc: Ladsgroup, Sjoerddebruin, dcausse, Jonas, gerritbot, JanZerebecki, daniel, thiemowmde, Tobi_WMDE_SW, Smalyshev, Aklapper, StudiesWorld, Deskana, aude, Ricordisamoa, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, Avner, Lewizho99, Maathavan, debt, Gehel, Jdrewniak, FloNight, Izno, Wikidata-bugs, jayvdb, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170039: Pages display Lua error in mw.wikibase.entity.lua
JohnBlackburne added a comment. It is not just one big red message. It is as many as there are uses of Wikidata on the page, sometimes showing the error message above, sometimes something else as it tries to use that as input to something, and it’s not uncommon to see two, sometimes more. Here is Alcantara, Cebu on en.wp, the worst example of it I’ve seen so far. F8658002: Screen Shot 2017-07-02 at 04.04.37.pngTASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JohnBlackburneCc: JohnBlackburne, Aklapper, Johnuniq, Cosine02, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T170039: Pages display Lua error in mw.wikibase.entity.lua
Johnuniq updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...There was a discussion at [[ https://en.wikipedia.org/wiki/Wikipedia_talk:Wikidata#Wikidata_script_errors | at enwiki ]].TASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JohnuniqCc: Aklapper, Johnuniq, Cosine02, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T170039: Pages display Lua error in mw.wikibase.entity.lua
Johnuniq created this task.Johnuniq added a project: Wikidata.Herald added subscribers: Cosine02, Aklapper. TASK DESCRIPTIONAn intermittent problem occurs when a Lua module executes entity = mw.wikibase.getEntity() or its equivalent entity = mw.wikibase.getEntityObject(). The symptom is that a rendered page shows a big red error message saying: Lua error in mw.wikibase.entity.lua at line 34: The entity data must be a table obtained via mw.wikibase.getEntityObject and the page is added to Category:Pages_with_script_errors (or local equivalent). The problem goes away when the page is purged so a link to a demonstration only works for a limited period. Currently, these pages show the error: enwiki zhwiki wikisource Using Special:Search for mw.wikibase.getEntityObject shows lots of cached examples: commons enwiki zhwiki Google search also shows examples. For example, search for one of the following then view Google's cache: "error in mw.wikibase.entity.lua" site:commons.wikimedia.org "error in mw.wikibase.entity.lua" site:en.wikipedia.org "error in mw.wikibase.entity.lua" site:zh.wikipedia.org The problem occurs when a Lua module uses Wikidata. That calls mw.wikibase.getEntity which calls php.getEntityId. I guess that sometimes times out when it tries to establish a network connection with the Wikidata database. There was a discussion at at enwiki.TASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JohnuniqCc: Aklapper, Johnuniq, Cosine02, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T170033: Temporarily Lift IP cap for account creation for Editathon in NYC - Saturday July 8th
Bugreporter added a project: Wikimedia-Site-requests. TASK DETAILhttps://phabricator.wikimedia.org/T170033EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BugreporterCc: Sjoerddebruin, aude, hoo, Ladsgroup, Pharos, Theredproject, Aklapper, GoranSMilovanovic, QZanden, DatGuy, Devwaker, Jseddon, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, Luke081515, biplabanand, Wikidata-bugs, Snowolf, Dcljr, revi, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T170033: Temporarily Lift IP cap for account creation for Editathon in NYC - Saturday July 8th
Lydia_Pintscher added subscribers: Ladsgroup, hoo, aude, Sjoerddebruin.Lydia_Pintscher added a project: Wikidata.org. TASK DETAILhttps://phabricator.wikimedia.org/T170033EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Sjoerddebruin, aude, hoo, Ladsgroup, Pharos, Theredproject, Aklapper, GoranSMilovanovic, QZanden, Jseddon, Izno, Wikidata-bugs, revi, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
