[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
thiemowmde added a comment. Feel free to pick this up too, but please create a separate ticket. I'm going to close this when all code bases relevant for Wikidata have this resolved. I did a quick search in my dev code base (which contains many more extensions) and found the following class names appear more than once in class_exists checks. Many of them are very obviously not checks for classes, but for enabled extensions. EchoEvent (18) BetaFeatures (15) CirrusSearch (15) CentralAuthUser (7) CentralAuthSpoofUser (6) EventLogging (6) LqtDispatch (6) GeoData (5) ResourceLoaderSchemaModule (4) SiteMatrix (4) AbuseFilter (3) AntiSpoofAuthenticationRequest (3) CommentStore (3) GuidedTourHooks (3) RenameuserSQL (3) ThanksHooks (3) WikiEditorHooks (3) ApiUsageException (2) AuthManager (2) Babel (2) EchoHooks (2) GlobalBlocking (2) Imagick (2) MobileContext (2) PageImages (2) PageProps (2) PHPUnit_Framework_TestCase (2) Scribunto_LuaEngineTestBase (2) tidy (2) TitleBlacklist (2) VisualEditorHooks (2) WikibaseClient (2) XMLReader (2) TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, CXuesong, Zoranzoki21, Lea_WMDE, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183100: Restrict the ability of users to choose enwiki Draft: namespace for Wikidata interwiki links
Liuxinyu970226 added a comment. Other Wikipedias too, I think.TASK DETAILhttps://phabricator.wikimedia.org/T183100EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Liuxinyu970226Cc: Liuxinyu970226, Agabi10, ChristianKl, Aklapper, Billinghurst, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T181319: Support external tabular datasets in WDQS
Yurik updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... SERVICE wikibase:tabular {
# Data location
bd:serviceParam wikibase:url {.
# CSVFormat constant, e.g. EXCEL, MYSQL, RFC4180, TDF. Default = 'DEFAULT'
bd:serviceParam wikibase:csvFormat 'DEFAULT' .
# If true, treat the first row as header. Default - depends on csvFormat
bd:serviceParam wikibase:firstRowIsHeader true .
# Some way of column parsing is TBD.# If true, use tabular:, Here we extract two otherwise use tabular: (1-based)
# The prefix for the first column could be something else# By default, this value is the same as firstRowIsHeader
bd:serviceParam wikibase:csvColumnByName true .
bd:Date bd:serviceParam ?date . # output to ?date# Parse columns into variables by their name
bd:D?date bd:serviceParamType tabular:Date 'date:-mm-dd' . # date parsing# parse as date
bd?dateStr tabular:Close bd:serviceParam ?close .'string' . # unparsed date value
bd?close tabular:Close bd:serviceParamType ''double' . # parse as double' .
}...| ?date | ?dateStr | ?close |
| 2017-11-24 | 2017-11-24 | 315.55 |TASK DETAILhttps://phabricator.wikimedia.org/T181319EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: YurikCc: Smalyshev, Aklapper, Yurik, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Reasno, Gehel, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, Base, aude, Tobias1984, Manybubbles, jayvdb, zhuyifei1999, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T183053: New Wikidata items appear in search with a delay
jhsoby renamed this task from "New Wikidata appear in search with a delay" to "New Wikidata items appear in search with a delay". TASK DETAILhttps://phabricator.wikimedia.org/T183053EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsobyCc: jhsoby, Lydia_Pintscher, EBernhardson, dcausse, Aklapper, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, Avner, Gehel, FloNight, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unassigned] T121863: [Story] Allow labels with diacritics to be found when searching using plain ascii
jhsoby removed jhsoby as the assignee of this task. TASK DETAILhttps://phabricator.wikimedia.org/T121863EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsobyCc: jhsoby, Liuxinyu970226, AmaryllisGardener, T.seppelt, Nikki, Agabi10, Lydia_Pintscher, Aklapper, StudiesWorld, daniel, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T121863: [Story] Allow labels with diacritics to be found when searching using plain ascii
jhsoby closed this task as "Resolved".jhsoby claimed this task.jhsoby added a comment. With the new search, this is how it works, so closing.TASK DETAILhttps://phabricator.wikimedia.org/T121863EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsobyCc: jhsoby, Liuxinyu970226, AmaryllisGardener, T.seppelt, Nikki, Agabi10, Lydia_Pintscher, Aklapper, StudiesWorld, daniel, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T46529: Wikidata search problems (tracking)
jhsoby closed subtask T121863: [Story] Allow labels with diacritics to be found when searching using plain ascii as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T46529EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsobyCc: Liuxinyu970226, PokestarFan, Smalyshev, Wikidata-bugs, Nemo_bis, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T179681: Add HDT dump of Wikidata
hoo added a parent task: T88991: improve Wikidata dumps [tracking]. TASK DETAILhttps://phabricator.wikimedia.org/T179681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Addshore, Smalyshev, Ladsgroup, Arkanosis, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T88991: improve Wikidata dumps [tracking]
hoo added a subtask: T179681: Add HDT dump of Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T88991EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: PokestarFan, Ricordisamoa, Denis.bykov, Jimkont, JanZerebecki, aude, Liuxinyu970226, Manybubbles, hoo, bd808, ArielGlenn, mark, Lydia_Pintscher, daniel, ezachte, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, Svick, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T46529: Wikidata search problems (tracking)
Smalyshev added a subtask: T183101: Items missing from Wikidata index. TASK DETAILhttps://phabricator.wikimedia.org/T46529EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Liuxinyu970226, PokestarFan, Smalyshev, Wikidata-bugs, Nemo_bis, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T183101: Items missing from Wikidata index
Smalyshev added a parent task: T46529: Wikidata search problems (tracking). TASK DETAILhttps://phabricator.wikimedia.org/T183101EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper, EBernhardson, dcausse, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T182800: Username beginning with asterisk renders as list in “restore”/“undo” edit summaries of Wikibase items
Bawolff added a comment. Fix for gender at https://gerrit.wikimedia.org/r/398772TASK DETAILhttps://phabricator.wikimedia.org/T182800EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BawolffCc: gerritbot, Bawolff, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, CXuesong, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T182800: Username beginning with asterisk renders as list in “restore”/“undo” edit summaries of Wikibase items
Bawolff added a comment.
I don’t think we can do that – {{GENDER}} needs the unescaped username. Otherwise we’ll address these users with the wrong gender. (I tried it out locally, {{GENDER:*asterisk|he|she|they}} produces “she” while {{GENDER:asterisk|he|she|they}} produces “they”.)
And weirdly enough, {{GENDER:User:asterisk|he|she|they}} produces she.TASK DETAILhttps://phabricator.wikimedia.org/T182800EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BawolffCc: gerritbot, Bawolff, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, CXuesong, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
Ebe123 removed a project: MediaWiki-extensions-Score. TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ebe123Cc: Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, CXuesong, Zoranzoki21, Lea_WMDE, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
Ebe123 added a project: MediaWiki-extensions-Score.Ebe123 added a comment. This is an issue that is found also with #mediawiki-extensions-score in respect to #timedmediahandler. In this area, the task attached is to formalize how TMH handles other extensions with providing players: T135501: Formalize how TMH provides a player for Score generated ogg/vorbis files.TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ebe123Cc: Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, CXuesong, Zoranzoki21, Lea_WMDE, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183100: Restrict the ability of users to choose enwiki Draft: namespace for Wikidata interwiki links
ChristianKl added a comment. From Lydia: I believe we can restrict links to specific namespaces in the config. I think that would be better than an abuse filter for performance reasons. Anyone up for creating a ticket? It might be useful to replace the existing abuse filters for user pages, template subpages and files as well with limits via config if that's good for performance reasons.TASK DETAILhttps://phabricator.wikimedia.org/T183100EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ChristianKlCc: ChristianKl, Aklapper, Billinghurst, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T183101: Items missing from Wikidata index
Smalyshev triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T183101EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper, EBernhardson, dcausse, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T183101: Items missing from Wikidata index
Smalyshev created this task.Smalyshev added projects: Wikidata, Discovery-Search.Herald added a subscriber: Aklapper. TASK DESCRIPTIONSome Wikidata entries do not seem to appear in ElasticSearch index, e.g.: https://www.wikidata.org/wiki/Q45825730, https://www.wikidata.org/wiki/Q45825742, https://www.wikidata.org/wiki/Q45825741, https://www.wikidata.org/wiki/Q45825750. cirrusDump returns empty for them. They are created recently, but not recently enough so the lag is the reason - a day or more has passed.TASK DETAILhttps://phabricator.wikimedia.org/T183101EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper, EBernhardson, dcausse, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T183100: Restrict the ability of users to choose enwiki Draft: namespace for Wikidata interwiki links
Billinghurst created this task.Billinghurst added a project: Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONWith wikidata interwikilinks it is possible to add enWP's Draft: namespace. Pages in that namespace are not considered articles and should not be available to be chosen. Where a page at enWP is moved from the main ns to the Draft: ns at Wikidata it should be treated with the same methodology as the link removal process. Wikidata Community discussionTASK DETAILhttps://phabricator.wikimedia.org/T183100EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BillinghurstCc: Aklapper, Billinghurst, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T180785: Wikidata does not support hif.wiktionary
aude added a comment. interwikis work now among hifwiktionary and other wiktionary projects: https://hif.wiktionary.org/wiki/Pahila_Panna and works to add site links for hif wiktionary project pages: e.g. https://www.wikidata.org/w/index.php?title=Q3938=revision=610340203=606635063 Interwiki links to hifwiktionary do not yet appear on other wikis, even after purge e.g. https://nl.wiktionary.org/wiki/paan There might be another step we need to do for Cognate. (it has some additional scripts populateCognateSites.php and populateCognatePages.php)TASK DETAILhttps://phabricator.wikimedia.org/T180785EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: audeCc: Lydia_Pintscher, Ladsgroup, hoo, aude, Reedy, JAnD, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, jberkel, Wikidata-bugs, GPHemsley, Shizhao, Nemo_bis, Darkdadaah, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T180785: Wikidata does not support hif.wiktionary
aude added a comment. (re)populated the sites table. site_identifiers table had data but sites table was mostly emptyTASK DETAILhttps://phabricator.wikimedia.org/T180785EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: audeCc: Lydia_Pintscher, Ladsgroup, hoo, aude, Reedy, JAnD, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, jberkel, Wikidata-bugs, GPHemsley, Shizhao, Nemo_bis, Darkdadaah, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T180785: Wikidata does not support hif.wiktionary
Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Lydia_Pintscher triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T180785WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lydia_Pintscher, Ladsgroup, hoo, aude, Reedy, JAnD, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, jberkel, Wikidata-bugs, GPHemsley, Shizhao, Nemo_bis, Darkdadaah, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T180785: Wikidata does not support hif.wiktionary
Lydia_Pintscher added a comment. @aude can you please have a look at this?TASK DETAILhttps://phabricator.wikimedia.org/T180785EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lydia_Pintscher, Ladsgroup, hoo, aude, Reedy, JAnD, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, jberkel, Wikidata-bugs, GPHemsley, Shizhao, Nemo_bis, Darkdadaah, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
thiemowmde triaged this task as "Normal" priority.thiemowmde moved this task from incoming to ready to go on the Wikidata board. TASK DETAILhttps://phabricator.wikimedia.org/T183096WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, CXuesong, Zoranzoki21, Lea_WMDE, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
thiemowmde created this task.thiemowmde added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, Technical-Debt, MediaWiki-extensions-WikibaseClient, Advanced-Search, Wikidata.org, Easy, User-thiemowmde.Herald added subscribers: TerraCodes, Aklapper.Herald added a project: TCB-Team.
TASK DESCRIPTIONSeveral Wikibase codebases use class_exists checks in tests as well as productive code to check if a specific extension is enabled:
if ( !class_exists( 'CheckUser' ) ) {
This binds against a full qualified class name in a super-problematic way that does not fail when the class is renamed or moved to an other namespace. This already caused many regressions in other (related and unrelated) codebases.
All these conditionals must be replaced with a proper check :
if ( !ExtensionRegistry::getInstance()->isLoaded( 'CheckUser' ) ) {
See https://gerrit.wikimedia.org/r/398511 for an example.TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, CXuesong, Zoranzoki21, Lea_WMDE, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T118463: [Story] Wikidata support for IFTTT
D3r1ck01 added a comment. Okay @Lydia_Pintscher, could you please put your mentor *hat* back on and ping @Slaporte so this can be expedited?TASK DETAILhttps://phabricator.wikimedia.org/T118463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: D3r1ck01Cc: Amit_gkp, Bene, Samtar, 01tonythomas, hoo, Lydia_Pintscher, D3r1ck01, Aklapper, Slaporte, Lahi, Gq86, GoranSMilovanovic, QZanden, srishakatux, Lethexie, Wikidata-bugs, aude, jayvdb, Mvolz, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T118463: [Story] Wikidata support for IFTTT
Lydia_Pintscher added a comment. Ok. Let's close this ticket then when that is done :)TASK DETAILhttps://phabricator.wikimedia.org/T118463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: D3r1ck01, Lydia_PintscherCc: Amit_gkp, Bene, Samtar, 01tonythomas, hoo, Lydia_Pintscher, D3r1ck01, Aklapper, Slaporte, Lahi, Gq86, GoranSMilovanovic, QZanden, srishakatux, Lethexie, Wikidata-bugs, aude, jayvdb, Mvolz, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T118463: [Story] Wikidata support for IFTTT
D3r1ck01 added a comment. @Lydia_Pintscher, it's okay! @Slaporte needs to review and work with the IFTTT team to deploy the new triggers to the IFTTT Wikipedia channel. Maybe he has some updates on it, no idea yet!TASK DETAILhttps://phabricator.wikimedia.org/T118463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: D3r1ck01Cc: Amit_gkp, Bene, Samtar, 01tonythomas, hoo, Lydia_Pintscher, D3r1ck01, Aklapper, Slaporte, Lahi, Gq86, GoranSMilovanovic, QZanden, srishakatux, Lethexie, Wikidata-bugs, aude, jayvdb, Mvolz, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T161367: Re-label the "Save" links to be "Publish" in structured data inline edit links on Wikidata.org
Lydia_Pintscher moved this task from needs discussion or investigation to consider for next sprint on the Wikidata board.Lydia_Pintscher added a project: Need-volunteer. TASK DETAILhttps://phabricator.wikimedia.org/T161367WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, Jan_Dittrich, Jdforrester-WMF, Aklapper, Lahi, Gq86, SandraF_WMF, GoranSMilovanovic, Ivana_Isadora, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, CXuesong, Zoranzoki21, Jseddon, FloNight, Johan, Trizek-WMF, Luke081515, Wikidata-bugs, Base, aude, Gryllida, TheDJ, Mbch331, Jay8g, Keegan, Elitre, Qgil___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T118463: [Story] Wikidata support for IFTTT
Lydia_Pintscher added a comment. Sorry I missed this. What is still needed for people other than us to use it?TASK DETAILhttps://phabricator.wikimedia.org/T118463EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: D3r1ck01, Lydia_PintscherCc: Amit_gkp, Bene, Samtar, 01tonythomas, hoo, Lydia_Pintscher, D3r1ck01, Aklapper, Slaporte, Lahi, Gq86, GoranSMilovanovic, QZanden, srishakatux, Lethexie, Wikidata-bugs, aude, jayvdb, Mvolz, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T182326: Make one group1 wiki a client of testwikidata (preferably a test wiki)
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T182326EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, demon, greg, Addshore, aude, Lydia_Pintscher, daniel, hoo, Aklapper, Ladsgroup, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Liudvikas, Luke081515, Wikidata-bugs, zeljkofilipin, Mbch331, Jay8g, Krenair, fgiunchedi, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T182326: Make one group1 wiki a client of testwikidata (preferably a test wiki)
gerritbot added a comment. Change 398704 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [operations/mediawiki-config@master] Move testwiki2 from group0 to group1 https://gerrit.wikimedia.org/r/398704TASK DETAILhttps://phabricator.wikimedia.org/T182326EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, demon, greg, Addshore, aude, Lydia_Pintscher, daniel, hoo, Aklapper, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, Liudvikas, Luke081515, Wikidata-bugs, zeljkofilipin, Mbch331, Jay8g, Krenair, fgiunchedi, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T183092: Make an obvious way of blacklisting a value for a property
matej_suchanek created this task.matej_suchanek added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints.Herald added a subscriber: Aklapper. TASK DESCRIPTIONProblem: I want to specify that a property should not use a value (eg. an item). Solution: Create a new constraint 'none of' (as opposed to 'one of'). Current workaround: Using 'conflicts with' and the same property. However, this only makes sense and works for mainsnak. I'd like to check qualifiers and references as well.TASK DETAILhttps://phabricator.wikimedia.org/T183092EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: matej_suchanek, Aklapper, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183053: New Wikidata appear in search with a delay
Lydia_Pintscher added a comment. The reason this is annoying because for heavy editors a common workflow is the following: go to item try to add statement that links to another item notice that other item does not exist yet create the other item go back to first item and make statement with newly created item If the new item does not show up in the item selector relatively quickly that is pretty annoying for them.TASK DETAILhttps://phabricator.wikimedia.org/T183053EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lydia_Pintscher, EBernhardson, dcausse, Aklapper, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, Avner, Gehel, FloNight, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T182333: WDCM Geo Dashboard
GoranSMilovanovic added a comment. SPARQL/HiveQL Engine (selection of items + ETL from the wdcm_maintable) completed; Updates synced across production/Labs; regular schedule on stat1005: every first of month; the Labs instance checks out for the updates every hour. Next step: WDCM GeoDashboard R/Shiny development.TASK DETAILhttps://phabricator.wikimedia.org/T182333EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GoranSMilovanovicCc: Jan_Dittrich, Tobi_WMDE_SW, Addshore, Lydia_Pintscher, GoranSMilovanovic, Aklapper, Lahi, Gq86, QZanden, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T183083: Phan did not catch missing use statement in Wikibase patch
Legoktm created this task.Legoktm added projects: MediaWiki-extensions-WikibaseClient, Continuous-Integration-Config.Herald added a subscriber: Aklapper.Herald added a project: Wikidata. TASK DESCRIPTIONhttps://gerrit.wikimedia.org/r/#/c/394044/ was missing a use statement, causing a class not found error in a unit test. Why wasn't this caught by phan?TASK DETAILhttps://phabricator.wikimedia.org/T183083EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: Addshore, Legoktm, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331, hashar___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T183082: Wikibase client tests are failing - EchoNotificationsHandlersTest::testWikibaseHandleChange
Legoktm created this task.Legoktm triaged this task as "Unbreak Now!" priority.Legoktm added a project: MediaWiki-extensions-WikibaseClient.Herald added subscribers: Liuxinyu970226, Jay8g, TerraCodes, Aklapper.Herald added a project: Wikidata. TASK DESCRIPTION13:26:06 1) Wikibase\Client\Tests\Hooks\EchoNotificationsHandlersTest::testWikibaseHandleChange 13:26:06 Failed asserting that 'Dummy2' does not create an event 13:26:06 Failed asserting that true is false. 13:26:06 13:26:06 /home/jenkins/workspace/mwext-Wikibase-client-tests-mysql-php55-jessie/src/extensions/Wikibase/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php:164 13:26:06 /home/jenkins/workspace/mwext-Wikibase-client-tests-mysql-php55-jessie/src/tests/phpunit/MediaWikiTestCase.php:416 13:26:06 /home/jenkins/workspace/mwext-Wikibase-client-tests-mysql-php55-jessie/src/maintenance/doMaintenance.php:94TASK DETAILhttps://phabricator.wikimedia.org/T183082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: Aklapper, TerraCodes, Jay8g, Legoktm, Liuxinyu970226, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T183081: Clean up mediawiki/extensions/Wikibase ACL
Legoktm created this task.Legoktm added projects: MediaWiki-extensions-WikibaseRepository, Wikidata, Gerrit.Herald added a subscriber: Aklapper. TASK DESCRIPTIONhttps://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/Wikibase,access There's some really weird stuff here, for example no one should have permissions to force push things. Additionally V+2 is only allowed to bots (good), and members of wikidata group (not great). In this case, a member of the wikidata group force merged, broke CI for other extensions, and when I went into force merge something to half-fix things, I wasn't able to. This is problematic - either all humans with +2 can also V+2 or *no* humans can V+2 (normal practice when taking away V+2 from humans in some repos).TASK DETAILhttps://phabricator.wikimedia.org/T183081EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: Aklapper, Legoktm, Lahi, Gq86, GoranSMilovanovic, QZanden, Luke081515, Wikidata-bugs, aude, jayvdb, Paladox, Mbch331, Jay8g, Krenair, QChris, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
