[Wikidata-bugs] [Maniphest] [Created] T201734: Wikidata tables overflow content area in Timeless

2018-08-10 Thread Evad37
Evad37 created this task.Evad37 added projects: Timeless, Wikidata.
TASK DESCRIPTIONIn desktop-large view, the tables on Wikidata items overflow the content area, covering up the right column.
F24789297: Wikidata overflow in Timeless.pngTASK DETAILhttps://phabricator.wikimedia.org/T201734EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Evad37Cc: Evad37, Chief_Mike, CycloneIsaac, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Framawiki, Izno, MGChecker, Feldo, Wong128hk, Luke081515, Unapersona, Wikidata-bugs, aude, waldyrious, RandomDSdevel, Isarra, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T199855: WikidataPageBanner breaks Vector page subtitle

2018-08-10 Thread Jdlrobson
Jdlrobson moved this task from Inbox to Blocked on the User-Jdlrobson board.Jdlrobson added a comment.
^ takes care of it, but as I'm the only maintainer I'm not sure if it will ever get reviewed :)TASK DETAILhttps://phabricator.wikimedia.org/T199855WORKBOARDhttps://phabricator.wikimedia.org/project/board/2985/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: gerritbot, Jdlrobson, Aklapper, Krinkle, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Jrbranaa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T199855: WikidataPageBanner breaks Vector page subtitle

2018-08-10 Thread gerritbot
gerritbot added a comment.
Change 452004 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/WikidataPageBanner@master] Only move/restyle subtitle for pages where banner is present

https://gerrit.wikimedia.org/r/452004TASK DETAILhttps://phabricator.wikimedia.org/T199855EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Jdlrobson, Aklapper, Krinkle, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, Jrbranaa, QZanden, LawExplorer, Winter, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T199855: WikidataPageBanner breaks Vector page subtitle

2018-08-10 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T199855EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Jdlrobson, Aklapper, Krinkle, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Jrbranaa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T163642: Index Wikidata strings in statements for fulltext search

2018-08-10 Thread Smalyshev
Smalyshev renamed this task from "Index Wikidata strings in statements for generic search" to "Index Wikidata strings in statements for fulltext search".
TASK DETAILhttps://phabricator.wikimedia.org/T163642EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Esc3300, ArthurPSmith, Stashbot, Lea_Lacroix_WMDE, gerritbot, Liuxinyu970226, Smalyshev, debt, aude, Lydia_Pintscher, Aklapper, Multichill, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, jayvdb, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T163642: Index Wikidata strings in statements for generic search

2018-08-10 Thread Smalyshev
Smalyshev renamed this task from "Index Wikidata strings in statements in the search engine" to "Index Wikidata strings in statements for generic search".Smalyshev updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONCurrently the search engine of WikidataWhile string properties are currently indexes all strings in labelsd for `haswbstatement` keyword, descriptions and aliasesthey are not locatable with regular search, but not in statements. Take for example https://www.wikidata.org/wiki/Q219831 /e.g. searching for "SK-C-5" (the inventory number) or "177124540" (the viaf id) won't return the item https://www.wikidata.org/w/index.php?title=Q219831="" . So searching for "SK-C-5" (the inventory number) or "177124540" (the viaf id) won't return the itemiki/Q219831.

As a user I want to be able to search for a string that is somewhere on the item and find the item.

This task is about putting it somewhere in the output. Probably just append all the strings to the text output and ignore the language (like is done right now for the labels/descriptions/aliases) and improve on it later 

We need to figure out the best place to index this string and how to make it match the item of generic search.TASK DETAILhttps://phabricator.wikimedia.org/T163642EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Esc3300, ArthurPSmith, Stashbot, Lea_Lacroix_WMDE, gerritbot, Liuxinyu970226, Smalyshev, debt, aude, Lydia_Pintscher, Aklapper, Multichill, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, jayvdb, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T200824: cirrussearch-haswbstatement-feature-no-valid-statements is missing

2018-08-10 Thread debt
debt closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T200824EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, debtCc: gerritbot, Aklapper, Smalyshev, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses

2018-08-10 Thread hoo
hoo added a comment.
Ok, so I just looked into this again and removing the redundant languages after the summary is not easily possible. These are needed as it's possible to add/remove/change several glosses at once and still be able to denote their respective languages.

If we want a nicer solution for that, this should probably be a separate tasks. The same limitations apply to form representation edit summaries, btw.TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Lucas_Werkmeister_WMDE, hoo, gerritbot, Lydia_Pintscher, WMDE-leszek, RazShuty, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unassigned] T201685: cucumber: "$ is not defined"

2018-08-10 Thread Pablo-WMDE
Pablo-WMDE removed Pablo-WMDE as the assignee of this task.
TASK DETAILhttps://phabricator.wikimedia.org/T201685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: gerritbot, Addshore, WMDE-leszek, Aklapper, Pablo-WMDE, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201337: Quibble & WikibaseLexeme: selenium, TypeError: Cannot read property 'value' of undefined

2018-08-10 Thread gerritbot
gerritbot added a comment.
Change 451327 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] NewLexemePage: lemma language in selenium test

https://gerrit.wikimedia.org/r/451327TASK DETAILhttps://phabricator.wikimedia.org/T201337EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Pablo-WMDE, hoo, gerritbot, Addshore, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201337: Quibble & WikibaseLexeme: selenium, TypeError: Cannot read property 'value' of undefined

2018-08-10 Thread gerritbot
gerritbot added a comment.
Change 451832 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] ComponentInteraction: set value on combobox

https://gerrit.wikimedia.org/r/451832TASK DETAILhttps://phabricator.wikimedia.org/T201337EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Pablo-WMDE, hoo, gerritbot, Addshore, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T201685: cucumber: "$ is not defined"

2018-08-10 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).
TASK DETAILhttps://phabricator.wikimedia.org/T201685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDE, ReleaseTaggerBotCc: gerritbot, Addshore, WMDE-leszek, Aklapper, Pablo-WMDE, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201685: cucumber: "$ is not defined"

2018-08-10 Thread gerritbot
gerritbot added a comment.
Change 451861 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] cucumber: check jquery through ResourceLoader

https://gerrit.wikimedia.org/r/451861TASK DETAILhttps://phabricator.wikimedia.org/T201685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDE, gerritbotCc: gerritbot, Addshore, WMDE-leszek, Aklapper, Pablo-WMDE, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201685: cucumber: "$ is not defined"

2018-08-10 Thread Pablo-WMDE
Pablo-WMDE added a comment.
Now in wikibase master - let's keep an eye on this if it creates stable improvement. (not closing just yet)TASK DETAILhttps://phabricator.wikimedia.org/T201685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: gerritbot, Addshore, WMDE-leszek, Aklapper, Pablo-WMDE, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T201685: cucumber: "$ is not defined"

2018-08-10 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration5.
TASK DETAILhttps://phabricator.wikimedia.org/T201685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: gerritbot, Addshore, WMDE-leszek, Aklapper, Pablo-WMDE, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T201685: cucumber: "$ is not defined"

2018-08-10 Thread Pablo-WMDE
Pablo-WMDE claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T201685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: gerritbot, Addshore, WMDE-leszek, Aklapper, Pablo-WMDE, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T201685: cucumber: "$ is not defined"

2018-08-10 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T201685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Addshore, WMDE-leszek, Aklapper, Pablo-WMDE, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201685: cucumber: "$ is not defined"

2018-08-10 Thread gerritbot
gerritbot added a comment.
Change 451861 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] cucumber: check jquery through ResourceLoader

https://gerrit.wikimedia.org/r/451861TASK DETAILhttps://phabricator.wikimedia.org/T201685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Addshore, WMDE-leszek, Aklapper, Pablo-WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T201685: cucumber: "$ is not defined"

2018-08-10 Thread Pablo-WMDE
Pablo-WMDE created this task.Pablo-WMDE added a project: Wikidata.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION13:09:24 Feature: Adding references to statements
...
13:09:35 And The copyright warning has been dismissed# features/step_definitions/entity_steps.rb:96
13:09:35   $ is not defined (Selenium::WebDriver::Error::_javascript_Error)
13:09:35   [remote server] http://localhost:9412/jenkins-mwext-mw-selenium-composer-jessie-11995/index.php/Item:Q8?setlang=en line 69 > Function:1:in `anonymous'
13:09:35   [remote server] http://localhost:9412/jenkins-mwext-mw-selenium-composer-jessie-11995/index.php/Item:Q8?setlang=en:69:in `handleEvaluateEvent'
13:09:35   ./features/support/modules/entity_module.rb:191:in `block in wait_until_cookie_loaded'
13:09:35   ./features/support/modules/entity_module.rb:190:in `wait_until_cookie_loaded'
13:09:35   ./features/support/modules/entity_module.rb:178:in `set_copyright_ack_cookie'
13:09:35   ./features/step_definitions/entity_steps.rb:97:in `/^The copyright warning has been dismissed$/'
13:09:35   features/reference.feature:18:in `And The copyright warning has been dismissed'

https://integration.wikimedia.org/ci/job/mwext-mw-selenium-composer-jessie/11995/consoleFull

This is likely related to the recent ResourceLoader changes (T192623)TASK DETAILhttps://phabricator.wikimedia.org/T201685WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Aklapper, Pablo-WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T199313: Implement LexemeMergeInteractor

2018-08-10 Thread gerritbot
gerritbot added a comment.
Change 451854 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] phpunit: polishing LexemeMergeInteractorTest

https://gerrit.wikimedia.org/r/451854TASK DETAILhttps://phabricator.wikimedia.org/T199313EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Lydia_Pintscher, Pablo-WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-08-10 Thread daniel
daniel added a comment.
SAX parsers would typically take the last and get confused

True, that's a risk - they would then be using the wrong slot.TASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlenn, danielCc: tstarling, awight, JAllemandou, hoo, pmiazga, Nemo_bis, brion, Tgr, Aklapper, Fjalapeno, ArielGlenn, daniel, kostajh, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, Lunewa, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, SBisson, gnosygnu, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, GWicke, jayvdb, Ricordisamoa, fbstj, Lydia_Pintscher, Fabrice_Florin, Raymond, santhosh, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-08-10 Thread Tgr
Tgr added a comment.

In T199121#4493904, @daniel wrote:
And I don't see how it's better than the multiple-text-tags-with-attributes approach.


How safe is the assumption that an XML parsing library that expects a tag to be unique will just ignore extra occurrences and return the first tag (as opposed to, say, returning the last one or raising an error)? I imagine DOM parsers would typically take the first and SAX parsers would typically take the last and get confused, and multi-gigabyte documents are more likely to be parsed in a SAX fashion.TASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlenn, TgrCc: tstarling, awight, JAllemandou, hoo, pmiazga, Nemo_bis, brion, Tgr, Aklapper, Fjalapeno, ArielGlenn, daniel, kostajh, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, Lunewa, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, SBisson, gnosygnu, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, GWicke, jayvdb, Ricordisamoa, fbstj, Lydia_Pintscher, Fabrice_Florin, Raymond, santhosh, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-08-10 Thread daniel
daniel added a comment.
CR-aware clients will maybe need very slightly less elegant parsing code, which does not seem like a bad trade-off.

It's an option, but it feels like we'd be shifting the paint to consumers, who have to maintain that duplicate logic forever. And I don't see how it's better than the multiple-text-tags-with-attributes approach.TASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlenn, danielCc: tstarling, awight, JAllemandou, hoo, pmiazga, Nemo_bis, brion, Tgr, Aklapper, Fjalapeno, ArielGlenn, daniel, kostajh, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, Lunewa, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, SBisson, gnosygnu, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, GWicke, jayvdb, Ricordisamoa, fbstj, Lydia_Pintscher, Fabrice_Florin, Raymond, santhosh, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-08-10 Thread Tgr
Tgr added a comment.
Or just drop the idea of a transitional format and keep the main slot one level higher forever (or at least until the next change that really needs to be a BC break). Old clients will not break, MCR-aware clients will maybe need very slightly less elegant parsing code, which does not seem like a bad trade-off.TASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlenn, TgrCc: tstarling, awight, JAllemandou, hoo, pmiazga, Nemo_bis, brion, Tgr, Aklapper, Fjalapeno, ArielGlenn, daniel, kostajh, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, Lunewa, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, SBisson, gnosygnu, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, GWicke, jayvdb, Ricordisamoa, fbstj, Lydia_Pintscher, Fabrice_Florin, Raymond, santhosh, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-08-10 Thread daniel
daniel added a comment.
Introducing a  tag that wraps a  tag and additional tags for meta-data looks nice and clean, but it's also completely incompatible with existing consumers.

Just generating multiple  tags, and addition any new info as attributes on them, would allow existing consumer code that follows the "grab the content of the (first) text tag" to continue functioning.TASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlenn, danielCc: tstarling, awight, JAllemandou, hoo, pmiazga, Nemo_bis, brion, Tgr, Aklapper, Fjalapeno, ArielGlenn, daniel, kostajh, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, Lunewa, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, SBisson, gnosygnu, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, GWicke, jayvdb, Ricordisamoa, fbstj, Lydia_Pintscher, Fabrice_Florin, Raymond, santhosh, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-08-10 Thread daniel
daniel added a comment.
I'm not sure the transitional format is useful. What client would use it, and what for? A client that wants to process the transitional format would need to implement handling for two different XML structures, and actually use both in parallel. A client that still relies on the old format doesn't benefit from the new tags begin present.

I see two ways for fully backwards compatible transition:


duplicate the contents of the main slot, using the old and the new format.
generate old-style and new-style dumps in parallel.


But both  are probably impractical, because they need too much space.

So, in practice, I suggest to make a hard breaking change  immediately, forcing clients that want to process new dumps to use the new structure. This could be made easier though, see my next comment.TASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlenn, danielCc: tstarling, awight, JAllemandou, hoo, pmiazga, Nemo_bis, brion, Tgr, Aklapper, Fjalapeno, ArielGlenn, daniel, kostajh, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, Lunewa, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, SBisson, gnosygnu, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, GWicke, jayvdb, Ricordisamoa, fbstj, Lydia_Pintscher, Fabrice_Florin, Raymond, santhosh, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-08-10 Thread daniel
daniel added a subscriber: tstarling.daniel added a comment.
@ArielGlenn Thanks for setting this up!

First thing I noticed: I think it would be a bad idea to expose the numeric IDs of content models and slot roles. These numeric IDs are strictly internal to the storage layer. They are not even to be used anywhere in the application logic. The numeric IDs are an implementation detail of a normalization mechanism in the storage layer, and should be in no way be part of any public interface.

In my opinion, the same should have been true for namespace IDs, btw.  Exposing their numeric IDs introduces incompatibilities between wikis that would otherwise simply not exist. I recall @tstarling also arguing in that direction.TASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlenn, danielCc: tstarling, awight, JAllemandou, hoo, pmiazga, Nemo_bis, brion, Tgr, Aklapper, Fjalapeno, ArielGlenn, daniel, kostajh, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, Lunewa, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, SBisson, gnosygnu, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, GWicke, jayvdb, Ricordisamoa, fbstj, Lydia_Pintscher, Fabrice_Florin, Raymond, santhosh, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-08-10 Thread ArielGlenn
ArielGlenn added a comment.
The draft at https://www.mediawiki.org/wiki/Requests_for_comment/Schema_update_for_multiple_content_objects_per_revision_(MCR)_in_XML_dumps is ready for a first round of comments by people on this ticket (or people just following along). Anything from 'that schema is wrong' to 'why did you use that color for diffs' to 'this wording is confusing', whatever you think is useful.TASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlennCc: awight, JAllemandou, hoo, pmiazga, Nemo_bis, brion, Tgr, Aklapper, Fjalapeno, ArielGlenn, daniel, kostajh, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, Lunewa, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, SBisson, gnosygnu, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, GWicke, jayvdb, Ricordisamoa, fbstj, Lydia_Pintscher, Fabrice_Florin, Raymond, santhosh, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T198301: Poke existing lexemes to be reflected on SpecialPage

2018-08-10 Thread Pablo-WMDE
Pablo-WMDE added a comment.
@Addshore Did this ever happen after prod was re-deployed?TASK DETAILhttps://phabricator.wikimedia.org/T198301EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, Pablo-WMDECc: Jakob_WMDE, Aklapper, Lucas_Werkmeister_WMDE, Lea_Lacroix_WMDE, JAnD, Esc3300, KaMan, Liuxinyu970226, VIGNERON, Pablo-WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unassigned] T201337: Quibble & WikibaseLexeme: selenium, TypeError: Cannot read property 'value' of undefined

2018-08-10 Thread Pablo-WMDE
Pablo-WMDE removed Pablo-WMDE as the assignee of this task.
TASK DETAILhttps://phabricator.wikimedia.org/T201337EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Pablo-WMDE, hoo, gerritbot, Addshore, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T201397: LexemeSpecialWhatLinksHereTest fails when run with --use-normal-tables

2018-08-10 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T201397EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: gerritbot, Pablo-WMDE, Addshore, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T195386: Provide useful HTML title for Lexemes

2018-08-10 Thread gerritbot
gerritbot added a comment.
Change 451833 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/WikibaseLexeme@master] Integration test for LexemeMetaTags

https://gerrit.wikimedia.org/r/451833TASK DETAILhttps://phabricator.wikimedia.org/T195386EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gerritbotCc: hoo, gerritbot, Aklapper, Lexicographical data, Lea_Lacroix_WMDE, KaMan, Ltrlg, Lucas_Werkmeister_WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201337: Quibble & WikibaseLexeme: selenium, TypeError: Cannot read property 'value' of undefined

2018-08-10 Thread gerritbot
gerritbot added a comment.
Change 451832 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] ComponentInteraction: set value on combobox

https://gerrit.wikimedia.org/r/451832TASK DETAILhttps://phabricator.wikimedia.org/T201337EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDE, gerritbotCc: Pablo-WMDE, hoo, gerritbot, Addshore, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T195315: Showing the Lemma(s) or Representation(s) when Lexemes or Forms are mentioned in constraint reports

2018-08-10 Thread Tarrow
Tarrow claimed this task.Tarrow moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration5 board.
TASK DETAILhttps://phabricator.wikimedia.org/T195315WORKBOARDhttps://phabricator.wikimedia.org/project/board/3518/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Jakob_WMDE, Lydia_Pintscher, Aklapper, Pablo-WMDE, WMDE-leszek, Lucas_Werkmeister_WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, merbst, LawExplorer, Agabi10, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs