[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used
Jdrewniak removed Jdrewniak as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T306744 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak Cc: Jdrewniak, Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, me, JCW555, hnijhuis, Nishu02, BeautifulBold, Suran38, Patafisik_WMF, Selby, Peteosx1x, NavinRizwi, Winter, Iniquity, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used
Jdrewniak moved this task from Incoming to Groomed on the Web-Team-Backlog board. Jdrewniak added a comment. It seems like this issue is still present. To summarize my understanding, there was a patch <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikidataPageBanner/+/802825> merged into PageBanner, but it didn't actually fix the issue. From @bwang's comment on that patch: > After some more investigating, there are two issues that need to be fixed for this task to work. > > 1. Ensure stickyHeader.js can query for a unique "heading" element on pages with page banners. Either by updating the selector used in Vector to be a class, or by adding code to the page banner extension that removes the original h1 element. > 2. The template data for the title is empty when page banner is used, still unsure if that's something that can be updated in page banner extension or can be handled in Vector. Additionally, the stickyHeader namespace logic is handled client-side with this this line <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/skins/Vector/+/refs/heads/master/resources/skins.vector.js/stickyHeader.js#530> const allowedNamespaceNumbers = [ 0, 2, 4, 10, 12, 14, 100, 828 ]; which doesn't include namespace 104, for pages like: https://eu.wikipedia.org/wiki/Txikipedia:Munduko_zazpi_mirariak. TASK DETAIL https://phabricator.wikimedia.org/T306744 WORKBOARD https://phabricator.wikimedia.org/project/board/67/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, me, JCW555, hnijhuis, Nishu02, BeautifulBold, Suran38, Patafisik_WMF, Selby, Peteosx1x, NavinRizwi, Winter, Iniquity, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled
Jdrewniak added a comment. Ok just a note here, given that the ULS doen't yet support the use-case where pages have no languages, and the Tools menu doesn't support icons yet (given the layout issues & multiple language bugs) I'll remove the icon from this link and leave it in the tools menu for now. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak Cc: Pginer-WMF, TheresNoTime, Patriccck, Urbanecm, jhsoby, GMikesell-WMF, Nux, Amire80, Zapipedia-WMF, Patafisik, RolandUnger, Iniquity, Raymond, ovasileva, alexhollender_WMF, Lucas_Werkmeister_WMDE, ItamarWMDE, Jdrewniak, Terasail, Aklapper, Jdlrobson, Themindcoder, Adamm71, JCW555, hnijhuis, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, Nishu02, 786, Biggs657, Patafisik_WMF, karapayneWMDE, Invadibot, Selby, Universal_Omega, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Demian, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled
Jdrewniak added a comment. Looks like I did miss a use-case with patches above (as Jon identified in code review) F36802081: Screen Shot 2023-02-07 at 3.51.57 PM.png <https://phabricator.wikimedia.org/F36802081> TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak Cc: alexhollender_WMF, Lucas_Werkmeister_WMDE, ItamarWMDE, Jdrewniak, Terasail, Aklapper, Jdlrobson, Themindcoder, Adamm71, JCW555, hnijhuis, Jersione, Hellket777, Mabualruz, LisafBia6531, Astuthiodit_1, 786, Biggs657, Patafisik_WMF, karapayneWMDE, Invadibot, Selby, Universal_Omega, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Demian, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, Iniquity, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled
Jdrewniak added a comment. @Jdlrobson this is what I'm seeing on beta without the wikibase patch. I see the icon is not aligned with the edge of the text and the color is off, is this what you're seeing? F3676: Screen Shot 2023-02-06 at 10.54.25 AM.png <https://phabricator.wikimedia.org/F3676> TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak Cc: Jdrewniak, Terasail, Aklapper, Jdlrobson, Themindcoder, Adamm71, JCW555, hnijhuis, Jersione, Hellket777, Mabualruz, LisafBia6531, Astuthiodit_1, 786, Biggs657, Patafisik_WMF, karapayneWMDE, Invadibot, Selby, Universal_Omega, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Demian, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, Iniquity, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled
Jdrewniak added a project: MediaWiki-extensions-WikibaseClient. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak Cc: Jdrewniak, Terasail, Aklapper, Jdlrobson, Themindcoder, Adamm71, JCW555, hnijhuis, Jersione, Hellket777, Mabualruz, LisafBia6531, 786, Biggs657, Patafisik_WMF, Selby, Universal_Omega, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Demian, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, JJMC89, Maathavan, Iniquity, Agabi10, Neuronton, Volker_E, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T263633: Mobile Special:EditWatchlist displays item IDs instead of labels
Jdrewniak added a comment. @Bouzinac Although this is certainly a bug, given that switching to "advanced" mode is a workable solution, this isn't likely to be given high priority. TASK DETAIL https://phabricator.wikimedia.org/T263633 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak Cc: Jdrewniak, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Mohammed_Sadat_WMDE, Bouzinac, Aklapper, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, mojoaxel, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, Jdlrobson, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T263633: Mobile Special:EditWatchlist displays item IDs instead of labels
Jdrewniak renamed this task from "Mobile watchlist of Wikidata shows opaque names for Q items" to "Mobile Special:EditWatchlist displays item IDs instead of labels". Jdrewniak added projects: MinervaNeue, MobileFrontend. Jdrewniak updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T263633 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak Cc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, Mohammed_Sadat_WMDE, Bouzinac, Aklapper, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, mojoaxel, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, Jdlrobson, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T215890: Catch up with minerva header changes (id & star)
Jdrewniak added a comment. @Pablo-WMDE thanks for your interest here. As you probably guessed, the reason `downloadPageAction` and others do not use an official Minerva API, is because there is none! We are considering this as a feature, but we haven't prioritized or written it up yet. We're in the progress of adding further modifications to the page-actions menu (adding an addition "overflow" menu T216418 <https://phabricator.wikimedia.org/T216418> ) and I think whatever public API we create should take this additional menu into account, so I don't think we'll get around to it until that menu is done. That being said, we're only aware of one external consumer who would use such an API (the MobileMaps <https://en.wikipedia.org/wiki/MediaWiki:Gadget-mobilemaps.js> gadget) would Wikidata also use this feature? TASK DETAIL https://phabricator.wikimedia.org/T215890 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak Cc: Jdrewniak, Tarrow, Hanna_Petruschat_WMDE, gerritbot, Jakob_WMDE, Aklapper, Lea_WMDE, Pablo-WMDE, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T215890: Catch up with minerva header changes (id & star)
Jdrewniak added a comment. @Pablo-WMDE Good point! Adding ID's on the `li` level seems useful and cleans up that :nth-child in the jQuery, and probably make the CSS more resilient too. This shouldn't be too difficult to add, I'll try to get something out soon. TASK DETAIL https://phabricator.wikimedia.org/T215890 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak Cc: Jdrewniak, Tarrow, Hanna_Petruschat_WMDE, gerritbot, Jakob_WMDE, Aklapper, Lea_WMDE, Pablo-WMDE, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T198946: Add Schema property 'sameAs' pointing to Wikidata entries
Jdrewniak added a comment. An update (I love to nerd out on this stuff). We're not the only ones to run into this problem. There are long-standing discussions between the relation of schema.org and Wikidata. Reading through this https://www.wikidata.org/wiki/Wikidata:Schema.org led me to this monster GitHub issue, https://github.com/schemaorg/schemaorg/issues/280 where I noticed the use of equivalentClass property. Turns out, for many entities, the equivalentClass property exists and actually points to a schema.org entity, see https://www.wikidata.org/wiki/Q5398426 . I think where that property exists, we could so something like "get instanceof, and then get equivalentClass of that instanceof", and that might give us the valid schema.org @type for that entity.TASK DETAILhttps://phabricator.wikimedia.org/T198946EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Niedzielski, JdrewniakCc: Jdrewniak, Mholloway, gerritbot, Denny, ovasileva, Tbayer, Elitre, CKoerner_WMF, Jdlrobson, Niedzielski, phuedx, dr0ptp4kt, Imarlier, cscott, Krenair, Aklapper, Deskana, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Chicocvenancio, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T198946: Add Schema property 'sameAs' pointing to Wikidata entries
Jdrewniak added a comment. @Niedzielski @type is tricky. The @context key refers to the vocabulary used to define the structured data. The problem is that http://schema.org and http://wikidata.org are different vocabularies, so a @type defined by Wikidata may be different than one defined by schema.org. Where schema.org defined "TVSeries", Wikidata defines "Q5398426" (television series). I don't think many search-engines recognize the http://wikidata.org vocabulary, so "@context": "http://wikidata.org", is invalid. Omitting the @context key does validate the markup, but I'm not sure there's much value without it.TASK DETAILhttps://phabricator.wikimedia.org/T198946EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Niedzielski, JdrewniakCc: Jdrewniak, Mholloway, gerritbot, Denny, ovasileva, Tbayer, Elitre, CKoerner_WMF, Jdlrobson, Niedzielski, phuedx, dr0ptp4kt, Imarlier, cscott, Krenair, Aklapper, Deskana, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Chicocvenancio, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T204698: cloudvps: wikidata-page-banner project trusty deprecation
Jdrewniak added a project: Readers-Web-Backlog. TASK DETAILhttps://phabricator.wikimedia.org/T204698EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdrewniakCc: aborrero, Jdlrobson, Sumit, Aklapper, JKSTNK, AndyTan, Zylc, 1978Gage2001, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, Tbscho, LawExplorer, Winter, JJMC89, srodlund, Wikidata-bugs, aude, Gryllida, Lydia_Pintscher, scfc, Mbch331, Jay8g, Krenair, chasemp___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
