[Wikidata-bugs] [Maniphest] [Declined] T92397: PHP fatal errors are not visible in jenkins output in mwext-Wikibase-client-tests job
Krinkle closed this task as "Declined". Krinkle claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T92397 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Addshore, Legoktm, aude, Aklapper, daniel, Wikidata-bugs, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T101076: Fix warning "OutputPage::getModuleStyles : module should define its position explicitly: jquery.wikibase.toolbar"
Krinkle created this task. Krinkle added a subscriber: Krinkle. Krinkle added projects: Wikimedia-log-errors, Wikidata, MediaWiki-extensions-WikibaseClient. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION > OutputPage::getModuleStyles: style module should define its position explicitly: jquery.wikibase.toolbar ResourceLoaderFileModule This module is loaded in the top using getModuleStyles() but does not have a `position => top` declared (defaulting to position => bottom as such). This hybrid position mismatch is deprecated. TASK DETAIL https://phabricator.wikimedia.org/T101076 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, Wikidata-bugs, aude, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T101076: Fix warning "OutputPage::getModuleStyles : module should define its position explicitly: jquery.wikibase.toolbar"
Krinkle edited the task description. Krinkle added a subscriber: aude. Krinkle edited projects, added MediaWiki-extensions-WikibaseRepository; removed MediaWiki-extensions-WikibaseClient. Krinkle set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T101076 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: aude, Krinkle, Aklapper, Wikidata-bugs, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Declined] T46097: make bits.wikimedia.org work with second level domains / A records.
Krinkle added a subscriber: Krinkle. Krinkle closed this task as "Declined". Krinkle claimed this task. Krinkle added a comment. This is no longer relevant to todays operation. These restrictions are no longer in place and the rewriting of paths no longer works that way. TASK DETAIL https://phabricator.wikimedia.org/T46097 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, liangent, Wikidata-bugs, Tobi_WMDE_SW, MZMcBride, daniel, PleaseStand, Krenair, wikibugs-l ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T43847: Wikidata should use wikidata.org as a domain (not www.wikidata.org)
Krinkle closed blocking task T46097: make bits.wikimedia.org work with second level domains / A records. as "Declined". TASK DETAIL https://phabricator.wikimedia.org/T43847 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: liangent, Wikidata-bugs, jeblad, Krinkle, ori, Petrb, Denny, aude, Hazard-SJ, MZMcBride, tomasz, Snowolf, Dzahn, Lydia_Pintscher, Reedy, daniel, Dereckson, Krenair, wikibugs-l ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T69781: Add UserMerge support to WikibaseClient
Krinkle removed a blocked task: T49918: Rename of global (attached) users to existing global usernames. TASK DETAIL https://phabricator.wikimedia.org/T69781 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Wikidata-bugs, Legoktm, Lydia_Pintscher, Reedy, hoo, wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T69780: Add UserMerge support to WikibaseRepo
Krinkle removed a blocked task: T49918: Rename of global (attached) users to existing global usernames. TASK DETAIL https://phabricator.wikimedia.org/T69780 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Wikidata-bugs, Legoktm, Lydia_Pintscher, Reedy, hoo, wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T69781: Add UserMerge support to WikibaseClient
Krinkle removed a blocked task: T49918: Rename of global (attached) users to existing global usernames. TASK DETAIL https://phabricator.wikimedia.org/T69781 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Wikidata-bugs, Legoktm, Lydia_Pintscher, Reedy, hoo, wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T69780: Add UserMerge support to WikibaseRepo
Krinkle removed a blocked task: T49918: Rename of global (attached) users to existing global usernames. TASK DETAIL https://phabricator.wikimedia.org/T69780 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Wikidata-bugs, Legoktm, Lydia_Pintscher, Reedy, hoo, wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T93871: add HHVM versions of Jenkins jobs for Wikibase extension
Krinkle edited projects, added Continuous-Integration-Config; removed Continuous-Integration-Infrastructure. Krinkle set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T93871 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lydia_Pintscher, JanZerebecki, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T93404: run phpunit ResourcesTest from core for wikibase
Krinkle edited projects, added Continuous-Integration-Config; removed Continuous-Integration-Infrastructure. Krinkle set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T93404 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lydia_Pintscher, gerritbot, JanZerebecki, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T95897: the changed job configuration extension-unittests -> extension-unittests-generic for Wikidata.git makes it not run all tests and fail
Krinkle edited projects, added Continuous-Integration-Config; removed Continuous-Integration-Infrastructure. TASK DETAIL https://phabricator.wikimedia.org/T95897 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: hashar, Legoktm, JanZerebecki, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T96264: Add Wikidata to Jenkins job mediawiki-extensions-hhvm
Krinkle edited projects, added Continuous-Integration-Config; removed Continuous-Integration-Infrastructure. TASK DETAIL https://phabricator.wikimedia.org/T96264 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: JanZerebecki, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T95230: Run Wikibase tests on Jenkins with hhvm
Krinkle moved this task to Done on the Continuous-Integration workboard. TASK DETAIL https://phabricator.wikimedia.org/T95230 WORKBOARD https://phabricator.wikimedia.org/project/board/401/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Legoktm, Krinkle Cc: gerritbot, aude, Aklapper, Wikidata-bugs, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T42656: Test coverage of JavaScript QUnit tests
Krinkle added a subscriber: Krinkle. Krinkle added a comment. The direction for QUnit testing forward is Karma. Karma has an official coverage plugin <https://github.com/karma-runner/karma-coverage> powered by istanbul-js <http://istanbul-js.org/>. Several projects are already using this. Published at https://integration.wikimedia.org/cover/. However for tests that are not standalone but depend on MediaWiki core, this doesn't work yet since we need to map things back to the file system from the proxied MediaWiki PHP requests. Whether that is feasible in the short term I'm not sure. I suspect bypassing it by solving https://phabricator.wikimedia.org/T89433 is probably more feasible. And would also improve the quality of our code. TASK DETAIL https://phabricator.wikimedia.org/T42656 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Wikidata-bugs, Tobi_WMDE_SW, Denny, JeroenDeDauw, adrianheine, Lydia_Pintscher, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T93404: run phpunit ResourcesTest from core for wikibase
Krinkle moved this task to Backlog on the Continuous-Integration workboard. TASK DETAIL https://phabricator.wikimedia.org/T93404 WORKBOARD https://phabricator.wikimedia.org/project/board/401/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lydia_Pintscher, gerritbot, JanZerebecki, Aklapper, Wikidata-bugs, aude, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T95897: the changed job configuration extension-unittests -> extension-unittests-generic for Wikidata.git makes it not run all tests and fail
Krinkle moved this task to Backlog on the Continuous-Integration workboard. TASK DETAIL https://phabricator.wikimedia.org/T95897 WORKBOARD https://phabricator.wikimedia.org/project/board/401/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Legoktm, JanZerebecki, Aklapper, Wikidata-bugs, aude, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Assigned] T95230: Run Wikibase tests on Jenkins with hhvm
Krinkle triaged this task as "Normal" priority. Krinkle assigned this task to Legoktm. Krinkle set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T95230 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Legoktm, Krinkle Cc: gerritbot, aude, Aklapper, Wikidata-bugs, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T93871: add HHVM versions of Jenkins jobs for Wikibase extension
Krinkle moved this task to Backlog on the Continuous-Integration workboard. TASK DETAIL https://phabricator.wikimedia.org/T93871 WORKBOARD https://phabricator.wikimedia.org/project/board/401/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lydia_Pintscher, JanZerebecki, Aklapper, Wikidata-bugs, aude, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T95897: the changed job configuration extension-unittests -> extension-unittests-generic for Wikidata.git makes it not run all tests and fail
Krinkle moved this task to In-progress on the Continuous-Integration workboard. TASK DETAIL https://phabricator.wikimedia.org/T95897 WORKBOARD https://phabricator.wikimedia.org/project/board/401/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Legoktm, JanZerebecki, Aklapper, Wikidata-bugs, aude, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T88435: generate patch code coverage on gerrit patch-set upload for wikibase.git
Krinkle moved this task to Backlog on the Continuous-Integration workboard. TASK DETAIL https://phabricator.wikimedia.org/T88435 WORKBOARD https://phabricator.wikimedia.org/project/board/401/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lydia_Pintscher, Aklapper, JanZerebecki, Wikidata-bugs, aude, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T88434: jenkins job to generate wikibase.git coverage
Krinkle moved this task to Backlog on the Continuous-Integration workboard. TASK DETAIL https://phabricator.wikimedia.org/T88434 WORKBOARD https://phabricator.wikimedia.org/project/board/401/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: hashar, JanZerebecki, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T72250: Allow tests to specify what extensions and or what order things are loaded in
Krinkle moved this task to Backlog on the Continuous-Integration workboard. TASK DETAIL https://phabricator.wikimedia.org/T72250 WORKBOARD https://phabricator.wikimedia.org/project/board/401/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Wikidata-bugs, greg, Addshore, Krinkle, hashar, adrianheine, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T86538: Enable PHP_CodeSniffer for Wikibase
Krinkle moved this task to Backlog on the Continuous-Integration workboard. TASK DETAIL https://phabricator.wikimedia.org/T86538 WORKBOARD https://phabricator.wikimedia.org/project/board/401/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Addshore, thiemowmde, Tobi_WMDE_SW, JeroenDeDauw, JanZerebecki, Aklapper, Wikidata-bugs, aude, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T92397: PHP fatal errors are not visible in jenkins output in mwext-Wikibase-client-tests job
Krinkle added a subscriber: Krinkle. Krinkle added a comment. Is this still an issue? This might be related to https://phabricator.wikimedia.org/T85799 / https://phabricator.wikimedia.org/rEWBA0a35ec5d1f370cee4ebb9be0c386978d6cfcaabb. TASK DETAIL https://phabricator.wikimedia.org/T92397 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Addshore, Legoktm, aude, Aklapper, daniel, Wikidata-bugs, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T94393: Switch wikidata qunit jobs from qunit to qunit-karma
Krinkle added a blocked task: T74063: Jenkins: Convert mediawiki qunit from grunt-contrib-qunit (PhantomJS) to grunt-karma (Chromium). TASK DETAIL https://phabricator.wikimedia.org/T94393 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine, Krinkle Cc: JanZerebecki, Tobi_WMDE_SW, Lydia_Pintscher, gerritbot, Aklapper, Wikidata-bugs, aude, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T94589: Fix "Unknown dependency: jquery.ui.EditableTemplatedWidget" error
Krinkle created this task. Krinkle added a subscriber: Krinkle. Krinkle added projects: Wikidata, MediaWiki-extensions-WikibaseClient. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION When installing Wikibase as client (e.g. on test2.wikipedia.org) it doesn't register this module (which is fine) but it does register the test suite for it. This is making is causing initialisation failures on [Special:JavaScriptTest/qunit](https://test2.wikipedia.org/wiki/Special:JavaScriptTest/qunit/plain). TASK DETAIL https://phabricator.wikimedia.org/T94589 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T94589: Fix "Unknown dependency: jquery.ui.EditableTemplatedWidget" error
Krinkle edited the task description. Krinkle set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T94589 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T70917: Refactor Wikibase API tests to avoid database access
Krinkle changed the title from "Refactor API tests to avoid database access" to "Refactor Wikibase API tests to avoid database access". Krinkle edited the task description. Krinkle set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T70917 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Wikidata-bugs, Lydia_Pintscher, daniel, JohnLewis, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T92397: PHP fatal errors are not visible in jenkins output in mwext-Wikibase-client-tests job
Krinkle removed a project: Jenkins. TASK DETAIL https://phabricator.wikimedia.org/T92397 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Addshore, Legoktm, aude, Aklapper, daniel, Wikidata-bugs, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T92397: PHP fatal errors are not visible in jenkins output in mwext-Wikibase-client-tests job
Krinkle moved this task to Next on the Continuous-Integration workboard. TASK DETAIL https://phabricator.wikimedia.org/T92397 WORKBOARD https://phabricator.wikimedia.org/project/board/401/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Addshore, Legoktm, aude, Aklapper, daniel, Wikidata-bugs, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T92946: Make mwext-Wikibase-qunit voting
Krinkle moved this task to Done on the Continuous-Integration workboard. TASK DETAIL https://phabricator.wikimedia.org/T92946 WORKBOARD https://phabricator.wikimedia.org/project/board/401/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar, Krinkle Cc: hashar, gerritbot, hoo, JanZerebecki, adrianheine, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T86176: Fix Job for running WBJSAPI QUnit tests on Jenkins
Krinkle edited blocking tasks, added: T90303: Fetch dependencies using composer instead of cloning mediawiki/vendor repository for non-WMF deployment branches; removed: T88436: Add data-values/javascript 0.6.0 to mediawiki/vendor. TASK DETAIL https://phabricator.wikimedia.org/T86176 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine, Krinkle Cc: Lydia_Pintscher, Tobi_WMDE_SW, Krinkle, hashar, adrianheine, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T88436: Add data-values/javascript 0.6.0 to mediawiki/vendor
Krinkle removed a blocked task: T86176: Fix Job for running WBJSAPI QUnit tests on Jenkins. TASK DETAIL https://phabricator.wikimedia.org/T88436 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lydia_Pintscher, Krinkle, aude, Legoktm, bd808, JanZerebecki, adrianheine, JeroenDeDauw, hashar, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit
Krinkle added a comment. In https://phabricator.wikimedia.org/T74184#1061699, @adrianheine wrote: > In https://phabricator.wikimedia.org/T74184#1060104, @JanZerebecki wrote: > > > […] Probably should add the apache error log to the build artifacts to be > > able to find out why. > > > Who is going to do that? No need. As of recent, MediaWiki collects PHP notices and warnings (with stack traces, unlike the default stderr sent to apache error log) and exceptions and writes these to log files. (See also https://phabricator.wikimedia.org/T50002 and https://phabricator.wikimedia.org/T45086.) If these logs fail to be created or if they are misconfigured, then this error is in the build output, or in the few logs that did succeed. Previously, Wikibase was wrongly overwriting Jenkins' MediaWiki base settings (Fixed in https://phabricator.wikimedia.org/rEWBA0a35ec5d1f370cee4ebb9be0c386978d6cfcaabb). As such it failed to write to the log file. The failure to write to this file was exposed in mwext-Wikibase job's debug log from the beginning. But since the name of the file was too similar to the default one, we didn't realise it was actually the wrong path. It seemed like an infrastructure issue in Jenkins of not having the right permissions, but really Wikibase had tampered with the destination file path. https://integration.wikimedia.org/ci/job/mwext-Wikibase-qunit/ collects build artefacts. If any mw-errors.log, exceptions and debug were created during the build, they are viewable there for 30 days. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Tobi_WMDE_SW, Snaterlicious, WMDE-Fisch, Wikidata-bugs, greg, Krinkle, hashar, JanZerebecki, adrianheine, Lydia_Pintscher, JohnLewis, hoo, Jdouglas, aude, wikibugs-l ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T90453: qunit test broken without explicitly setting $wgResourceLoaderMaxQueryLength
Krinkle added a comment. This change (Ic416def846f361425c46f7b <https://gerrit.wikimedia.org/r/#/c/193130/>) in general seems fine. However I'd like to see further evidence that the QUnit jenkins job is indeed failing because of this. And as a general practice it seems to me that requesting so many modules in one request means one of two things: - The relevant software is incorrectly using the ResourceLoader module system. (E.g. using it as a complete class registry.) This has all kinds of scalability impacts and semantic "fragileness" to it that warrants addressing. Take an example after VisualEditor where class and file count is very high, but module count is low. - Software is using overly long module names. It is definitely too naive for ResourceLoader not have a limit by default. However I argue this limit should never be reached. If this limit is reached, we're talking about failure mode / error handling / graceful degradation, not normal modus operandi. I suppose the test is slightly different in that it requests everything at once in a way production never would. A quick check to verify that is the case would be nice. We may want to add a logged check to mediawiki.js asserting the request is shorter. It'd be tolerated in tests (until we find a better way to deal with that). TASK DETAIL https://phabricator.wikimedia.org/T90453 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, Krinkle Cc: hashar, Tobi_WMDE_SW, Krinkle, gerritbot, JanZerebecki, Aklapper, Wikidata-bugs, Jdouglas, aude, Jdforrester-WMF, jeremyb-phone, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T88436: Add data-values/javascript 0.6.0 to mediawiki/vendor
Krinkle added a comment. Jobs will no longer use mediawiki/vendor in the near future. But until we're there, if the relevant extension here is Wikimedia-deployed and needs data-values/javascript at run-time in production, then it not only can be added but must be added. TASK DETAIL https://phabricator.wikimedia.org/T88436 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lydia_Pintscher, Krinkle, aude, Legoktm, bd808, JanZerebecki, adrianheine, JeroenDeDauw, hashar, Aklapper, Wikidata-bugs, Jdouglas ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T88436: Add data-values/javascript 0.6.0 to mediawiki/vendor
Krinkle added a comment. In https://phabricator.wikimedia.org/T88436#1025775, @JanZerebecki wrote: > Should we run composer for master branches (i.e. not the wmf deployment ones) > during CI instead of relying on mediawiki-vendor? Yes. Both to simplify day-to-day maintenance (e.g. atomic changes that bump dependencies and update calling code) for production dependencies. As well as for the ability to use devDependencies for e.g. phpcs and phpunit. Which is already used by projects not tied to MediaWiki. TASK DETAIL https://phabricator.wikimedia.org/T88436 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lydia_Pintscher, Krinkle, aude, Legoktm, bd808, JanZerebecki, adrianheine, JeroenDeDauw, hashar, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T88436: Add data-values/javascript 0.6.0 to mediawiki/vendor
Krinkle added a comment. I propose we stop using mediawiki-vendor for the majority of MediaWiki core and extension repositories Jenkins jobs (master and release branches). In the wmf-branches (of MediaWiki core and extensions) we'd use mediawiki-vendor instead of composer. (And the same for the master branch of mediawiki-vendor itself). The commits that create or modify wmf branches will then run with mediawiki-vendor and thus ensure (before deployment!) that everything is in order. This means that (if someone forgets to make a commit to mediawiki-vendor) issues are caught a bit later. I think that's worth the reduced overall complexity and gained flexibility for non-wmf extensions. It also makes it a lot easier to write commits against mediawiki/core that update composer.json. It'll enable developers to test these commits in Jenkins – without having to orchestrate inter-dependent commits and merge them before testing. This also in light of the recent issue with update.php verifying the composer dependencies. See T88211: Unable to update libraries in MediaWiki core and vendor due to version mismatch and circular dependencies <https://phabricator.wikimedia.org/T88211>. TASK DETAIL https://phabricator.wikimedia.org/T88436 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, aude, Legoktm, bd808, JanZerebecki, adrianheine, JeroenDeDauw, hashar, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed CC] T72250: Allow tests to specify what extensions and or what order things are loaded in
Krinkle removed a subscriber: wikibugs-l. Krinkle set Security to none. TASK DETAIL https://phabricator.wikimedia.org/T72250 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: greg, Addshore, hashar, Krinkle, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T72250: Allow tests to specify what extensions and or what order things are loaded in
Krinkle added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T72250 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: greg, Addshore, hashar, Krinkle, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T72250: Allow tests to specify what extensions and or what order things are loaded in
Krinkle added a comment. I see a lot of proposals for implementation but no specific use cases or issues it would solve. Would the following not work? - Include extension in LocalSettings.php. - Run phpunit tests. Tests set wg-config variables in their PHPUnit test setUp method. And it either doesn't depend on other classes, or takes the instance as passed parameter from during the test. Please provide specific cases where this doesn't work. TASK DETAIL https://phabricator.wikimedia.org/T72250 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: wikibugs-l, greg, Addshore, hashar, Krinkle, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T86161: Project association requires autocompletion and autocompletion has failed sorting algorythm
Krinkle created this task. Krinkle added a subscriber: Krinkle. Krinkle added projects: Phabricator.org, Phabricator, Wikidata. TASK DESCRIPTION 1. Edit or create a task 2. Try to associate it to #Wikidata Expected: Typing "Wikidata" should have the exact match appear on top of the list. And if not, it should at least be included in the suggestions. Especially because the interface requires the user to select an autocomplete item. It cannot be entered manually or directly. Actual: Only other projects appear, and the list is limited to 5 results. Other: I tried working around it by adding the unrelated projects first and perhaps removing them later, but the already added project still appear in the autocomplete list, so there's no way around it that I can see. (Short of working around the entire interface by leaving a comment mentioning it, since that associated it as well). {F26980} {F26982} TASK DETAIL https://phabricator.wikimedia.org/T86161 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Krinkle, Wikidata-bugs, aude, scfc, jeremyb, Qgil ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit
Krinkle added a comment. Filed: - T73058: [Regression] Jenkins: SQLite database is often locked causing queries to fail <https://phabricator.wikimedia.org/T73058> - T85799: mw-debug.log missing in Jenkins jobs (Failed to be created "Permission denied") <https://phabricator.wikimedia.org/T85799> TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: wikibugs-l, greg, adrianlang, JohnLewis, JanZerebecki, hoo, Lydia_Pintscher, hashar, Krinkle, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed CC] T802: Phabricator projects for Wikimedia sister projects
Krinkle removed a subscriber: Krinkle. TASK DETAIL https://phabricator.wikimedia.org/T802 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Aklapper, Krinkle Cc: Qgil, Tpt, Aklapper, Micru, Ricordisamoa, Rdicerb, He7d3r, Carlb, Quiddity, Krenair, Glaisher, Reedy, Nemo_bis, MZMcBride, MarkAHershberger, Vriullop, Toniher, Arnaugir, GPHemsley, jayvdb, Darkdadaah, Gryllida, scfc, marcoil, Rillke, Steinsplitter, Billinghurst, Praveenp, Aubrey, Wikidata-bugs, aude, Jdforrester-WMF, Keegan, wikibugs-l ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed CC] T66176: Patrol link is misplaced when content contains uncleared floating elements
Krinkle removed a subscriber: Krinkle. TASK DETAIL https://phabricator.wikimedia.org/T66176 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Fomafix, Krinkle Cc: Sjoerddebruin, Lydia_Pintscher, Wikidata-bugs, Fomafix ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T66176: Patrol link is misplaced when content contains uncleared floating elements
Krinkle edited the task description. Krinkle set Security to none. TASK DETAIL https://phabricator.wikimedia.org/T66176 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Fomafix, Krinkle Cc: Sjoerddebruin, Lydia_Pintscher, Krinkle, Wikidata-bugs, Fomafix ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T85004: Use CSS instead of jQuery for wb-claim-name position animation
Krinkle created this task. Krinkle added a subscriber: Krinkle. Krinkle added projects: Performance, MediaWiki-extensions-WikibaseRepository. Krinkle changed Security from none to none. TASK DESCRIPTION Currently a jQuery animation (aka "forced browser repaints in rapid succession") is used for the animating of the `.wb-claim-name` position when scrolling down. E.g. the "located in the administrative territorial entity" label on https://www.wikidata.org/wiki/Q70 Can by done by adding a transition declaration in the stylesheet, and updating the callback to set pure css() values instead of animate(). Also, it seems that when scrolling back up the value is not restored correctly (may be an upstream bug in jQuery UI). It ends with: ``` position: relative; top: 0.0117645263670028px; left: 0px; ``` TASK DETAIL https://phabricator.wikimedia.org/T85004 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Krinkle, Wikidata-bugs, GWicke ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T84838: Slow rendering pages display content outside the container
Krinkle created this task. Krinkle added a subscriber: Krinkle. Krinkle added a project: Wikidata. Krinkle changed Security from none to none. TASK DESCRIPTION Pages shouldn't be as slow as they are in the first place, but that's a reality (average wikidata page with a few properties takes like 0.5 to 2.5s to generate when logged-in). Either way, the container seems to be lagging behind for a significant amount of time while loading the page. Affects Chrome 39 (current stable) and Chrome 41 (current Canary). Firefox doesn't seem to be affected for me, but could be related to other factors. Example url: https://www.wikidata.org/wiki/Q535 Screenshot of what the lag looks like: {F22336} TASK DETAIL https://phabricator.wikimedia.org/T84838 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Krinkle, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T44510: Code coverage extremely low - technical debt
Krinkle added a project: TechnicalDebt. Krinkle set Security to none. TASK DETAIL https://phabricator.wikimedia.org/T44510 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: Krinkle Cc: JanZerebecki, Lydia_Pintscher, Tobi_WMDE_SW, JeroenDeDauw, Wikidata-bugs, aude, Elitre ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T44507: ExternalChangesLine technical debt
Krinkle added a project: Technical-Debt. Krinkle set Security to none. TASK DETAIL https://phabricator.wikimedia.org/T44507 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: Krinkle Cc: Lydia_Pintscher, daniel, aude, JeroenDeDauw, Wikidata-bugs, Elitre ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T45295: Keyword 'use' inconsistency for php namespaces
Krinkle added a project: TechnicalDebt. Krinkle set Security to none. TASK DETAIL https://phabricator.wikimedia.org/T45295 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: Krinkle Cc: Lydia_Pintscher, jayvdb, aude, JeroenDeDauw, Wikidata-bugs, Elitre ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T58613: Cleanup code that handles comments in client
Krinkle added a project: TechnicalDebt. Krinkle added a subscriber: Krinkle. TASK DETAIL https://phabricator.wikimedia.org/T58613 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: Krinkle Cc: thiemowmde, Lydia_Pintscher, Tobi_WMDE_SW, aude, Wikidata-bugs, Krinkle, Elitre ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T76006: code cleanup and refactoring of the mediawiki file page to be able to store structured data in it
Krinkle added a project: TechnicalDebt. Krinkle added a subscriber: Krinkle. TASK DETAIL https://phabricator.wikimedia.org/T76006 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: Krinkle Cc: JanZerebecki, Gilles, Krinkle, Wikidata-bugs, aude, Fabrice_Florin, Elitre, Tgr ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Merged] T76965: z-index: 1 for "[edit]" button generates a overlap
Krinkle merged this task into T40848: Security: CSS "position" and "z-index" property to hijack user clicks. TASK DETAIL https://phabricator.wikimedia.org/T76965 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: Krinkle Cc: Aklapper, Fomafix, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T75649: Unable to "Edit pages on double click" on Wikidata
Krinkle closed blocking task T59713: Unable to "Edit pages on double click": Uncaught TypeError: Cannot call method 'click' of undefined as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T75649 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: Krinkle Cc: He7d3r, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T59713: Unable to "Edit pages on double click": Uncaught TypeError: Cannot call method 'click' of undefined
Krinkle closed this task as "Resolved". Krinkle claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T59713 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: Krinkle Cc: Snaterlicious, adrianlang, He7d3r, thiemowmde, Lydia_Pintscher, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit
Krinkle added a comment. Downloading the log artefacts shows there are only two errors: ``` # --- mw-dberror.log (3 lines) integration-slave1003 build4924 SqlBagOStuff::set/single-row 5 database is locked REPLACE INTO objectcache (keyname,value,exptime) VALUES ('build4924:resourceloader:modulemodifiedhash:startup:a51e88377de6e214bb3e8742a98d3e6b',x'15..3f','20..07') # --- mw-error.log (7000 lines) integration-slave1003 build4924: [0bc103a0] /jenkins-mwext-Wikibase-qunit-4924/index.php?title=Special:BlankPage ErrorException from line 376 of includes/debug/logger/legacy/Logger.php: PHP Warning: file_put_contents(mw-debug.log): failed to open stream: Permission denied ``` TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . To: Krinkle Cc: wikibugs-l, greg, adrianlang, JohnLewis, JanZerebecki, hoo, Lydia_Pintscher, hashar, Krinkle, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs