[Wikidata-bugs] [Maniphest] T286655: Review wd_propertysuggester A/B testing schema
Mholloway closed this task as "Resolved". Mholloway added a comment. Ship sailed. TASK DETAIL https://phabricator.wikimedia.org/T286655 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jlinehan, Mholloway Cc: Lydia_Pintscher, Addshore, Michaelcochez, Martaannaj, ldelench_wmf, DAbad, Mholloway, Aklapper, jlinehan, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T285098: Production A/B test deployment - Improved Property Suggester/Recommender
Mholloway closed subtask T286655: Review wd_propertysuggester A/B testing schema as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T285098 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: karapayneWMDE, Joe, Ladsgroup, Ottomata, Lucas_Werkmeister_WMDE, Martaannaj, Michaelcochez, Michael, Addshore, Aklapper, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T263491: [EPIC] WDQS behind API Gateway
Mholloway removed a project: Patch-For-Review. Mholloway added a comment. Faulty bug tag, sorry! TASK DETAIL https://phabricator.wikimedia.org/T263491 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, Aklapper, Gehel, MPhamWMF, Naike, NavinRizwi, CBogen, Akuckartz, Nandana, Namenlos314, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Dinoguy1000, Manybubbles, Mbch331, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T270226: HTTP request blocked: https://meta.wikimedia.org/w/api.php?action=jsonschema=18910134=2=json by RemoteSchema::httpGet. Use MockHttpTrait
Mholloway closed this task as "Resolved". Mholloway added a comment. The culprit was a missing check to ensure that the eventlogging service base URI was defined. A fixed version of the change is here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventLogging/+/649961 TASK DETAIL https://phabricator.wikimedia.org/T270226 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: jlinehan, Mholloway, Nikerabbit, kostajh, Catrope, Lucas_Werkmeister_WMDE, Michael, Aklapper, Reedy, Alter-paule, Beast1978, Un1tY, Akuckartz, 4748kitoko, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Akovalyov, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, JAllemandou, terrrydactyl, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T191831: Track implicit use of non-overridden wikidata description
Mholloway removed a project: Product-Infrastructure-Team-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T191831 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Ladsgroup, hoo, TomT0m, Bencemac, Addshore, Lea_Lacroix_WMDE, Aklapper, Tgr, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jgiannelos ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown
Mholloway closed this task as "Resolved". Mholloway claimed this task. Mholloway added a comment. The request in this task was for the Wikipedia Android app to show the article description in the correct language variant if a description exists in Wikidata for that variant. That's long-since resolved. Please file requests for refining the current behavior (or for fixing ApiQueryDescription) as new tasks. TASK DETAIL https://phabricator.wikimedia.org/T173842 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: LGoto, Charlotte, JoeWalsh, shinjiman, Yuriy_kosygin, Addshore, CXuesong, fantasticfears, cscott, gerritbot, Liuxinyu970226, cooltey, Dbrant, Mholloway, bearND, Tbayer, Aklapper, RHo, Ryansama, Confetti68, Akuckartz, Joye_Zhang, darthmon_wmde, VulpesVulpes825, Sunny00217, 94rain, Nandana, Hamishcn, Lahi, Gq86, Sharvaniharan, BJ6123C7BTD, schoenbaechler, Maggouri, Jcasariego, GoranSMilovanovic, lisong, Allthingsgo, QZanden, LawExplorer, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, LNDDYL, Fuzheado, Cwek, Wikidata-bugs, aude, zhuyifei1999, Shizhao, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown
Mholloway added a comment. @cooltey Just to be clear, am I correct that the remaining issue here is that the service should NOT fall back to using the description from another variant if the preferred variant is unavailable? Using your example title, I see that the description on https://zh.wikipedia.org/api/rest_v1/page/mobile-html/%E4%B8%89%E7%81%A3%E9%84%89_(%E5%8F%B0%E7%81%A3) uses the correct variant when `Accept-Language: zh-hant` is sent. But when `Accept-Language: zh-hans` is sent or no language variant is specified, the generic "Chinese" description is shown, which (IIUC) is incorrect. If what you're asking is to fix ApiQueryDescription <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/refs/heads/master/client/includes/Api/Description.php> (?action=query=description) to handle language variants generally, then that's a separate task, and one probably best performed by someone with in-depth knowledge of Wikibase concepts and architecture (hint: probably someone from WMDE and not WMF Product Infrastructure). But I wouldn't agree with the prioritization in that case, because descriptions in the correct variant are already available by other means. TASK DETAIL https://phabricator.wikimedia.org/T173842 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: LGoto, Charlotte, JoeWalsh, shinjiman, Yuriy_kosygin, Addshore, CXuesong, fantasticfears, cscott, gerritbot, Liuxinyu970226, cooltey, Dbrant, Mholloway, bearND, Tbayer, Aklapper, RHo, Confetti68, Akuckartz, Joye_Zhang, darthmon_wmde, VulpesVulpes825, Sunny00217, 94rain, Nandana, Hamishcn, Lahi, Gq86, Sharvaniharan, BJ6123C7BTD, schoenbaechler, Maggouri, Jcasariego, GoranSMilovanovic, lisong, Allthingsgo, QZanden, LawExplorer, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, LNDDYL, Fuzheado, Cwek, Wikidata-bugs, aude, zhuyifei1999, Shizhao, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T251550: Description property missing in beta cluster WP
Mholloway added a comment. Verified on Beta Cluster that this is resolved. TASK DETAIL https://phabricator.wikimedia.org/T251550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: JoeWalsh, Mholloway, Tgr, Pchelolo, Aklapper, bearND, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T251550: Description property missing in beta cluster WP
Mholloway closed this task as "Resolved". Mholloway claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T251550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: JoeWalsh, Mholloway, Tgr, Pchelolo, Aklapper, bearND, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T251550: Description property missing in beta cluster WP
Mholloway added a comment. Update: The breaking change was reverted in wmf.31 but left in master, so production wikis shouldn't be affected any longer, but the Beta Cluster will be broken until the real fix lands on master. TASK DETAIL https://phabricator.wikimedia.org/T251550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: JoeWalsh, Mholloway, Tgr, Pchelolo, Aklapper, bearND, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T251550: Description property missing in beta cluster WP
Mholloway added a comment. Now visible on group1 production Wikipedias, for example, hewiki: https://he.wikipedia.org/w/api.php?action=query=description=%D7%9B%D7%93%D7%95%D7%A8_%D7%94%D7%90%D7%A8%D7%A5 T252079 <https://phabricator.wikimedia.org/T252079> is UBN and very likely related. TASK DETAIL https://phabricator.wikimedia.org/T251550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: JoeWalsh, Mholloway, Tgr, Pchelolo, Aklapper, bearND, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T252079: mw.wikibase.getLabelByLang('Q1', 'en') returning nil today
Mholloway added a comment. We've noticed something similar on the Beta Cluster since last week: T251550: Description property missing in beta cluster WP <https://phabricator.wikimedia.org/T251550> UBN is appropriate, in my opinion. TASK DETAIL https://phabricator.wikimedia.org/T252079 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, WilliamGraham, LucasWerkmeister, Lydia_Pintscher, Liuxinyu970226, Aklapper, matej_suchanek, Jarekt, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T251550: Description property missing in beta cluster WP
Mholloway triaged this task as "High" priority. Mholloway added a comment. I'm going to be bold and call this high-priority since it's now broken testing workflows for two different teams that I know about. TASK DETAIL https://phabricator.wikimedia.org/T251550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: JoeWalsh, Mholloway, Tgr, Pchelolo, Aklapper, bearND, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T251550: Description property missing in beta cluster WP
Mholloway added a project: Product-Infrastructure-Team-Backlog. Mholloway added a comment. Adding PI backlog for tracking. TASK DETAIL https://phabricator.wikimedia.org/T251550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: JoeWalsh, Mholloway, Tgr, Pchelolo, Aklapper, bearND, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T251550: Description property missing in beta cluster WP
Mholloway added a project: Beta-Cluster-Infrastructure. TASK DETAIL https://phabricator.wikimedia.org/T251550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: JoeWalsh, Mholloway, Tgr, Pchelolo, Aklapper, bearND, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Merged] T251550: Description property missing in beta cluster WP
Mholloway merged a task: T252067: mobile-html: wikipedia.beta.wmflabs.org doesnt include the title description. Mholloway added a subscriber: JoeWalsh. TASK DETAIL https://phabricator.wikimedia.org/T251550 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: JoeWalsh, Mholloway, Tgr, Pchelolo, Aklapper, bearND, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T247479: All edits on Wikidata and Commons tagged as "suggested edits" between approx. 23:40 and 00:00 UTC on 2020-03-11
Mholloway added a comment. Forgot to add: thanks very much @Bugreporter for quickly noticing and reporting this! TASK DETAIL https://phabricator.wikimedia.org/T247479 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, Liuxinyu970226, Aklapper, Bugreporter, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, SBisson, Wikidata-bugs, bearND, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T247479: All edits on Wikidata and Commons tagged as "suggested edits" between approx. 23:40 and 00:00 UTC on 2020-03-11
Mholloway closed this task as "Resolved". Mholloway added a comment. After some discussion, it's probably best just to let the affected revisions be. There were 11,903 affected revisions on Wikidata, and 3,579 on Commons. I've uploaded lists of affected revision IDs as F31678573 <https://phabricator.wikimedia.org/F31678573> and F31678574 <https://phabricator.wikimedia.org/F31678574>. TASK DETAIL https://phabricator.wikimedia.org/T247479 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, Liuxinyu970226, Aklapper, Bugreporter, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, SBisson, Wikidata-bugs, bearND, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T247458: PHP Notice: Undefined index: wgKartographerLiveData
Mholloway added subscribers: hoo, Mholloway. Mholloway added a comment. I haven't managed to find any documentation about `wgKartographerLiveData` anywhere, but as best I can tell from the Kartographer codebase, it's not safe to assume it will be defined. It looks like @hoo originally wrote this code, so maybe he can provide some insight. TASK DETAIL https://phabricator.wikimedia.org/T247458 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, hoo, thiemowmde, Agusbou2015, Krinkle, Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T247479: All edits on Wikidata and Commons tagged as "suggested edits" between approx. 23:40 and 00:00 UTC on 2020-03-11
Mholloway updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T247479 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, Liuxinyu970226, Aklapper, Bugreporter, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, SBisson, Wikidata-bugs, bearND, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T247479: All edits on Wikidata and Commons tagged as "suggested edits" between approx. 23:40 and 00:00 UTC on 2020-03-11
Mholloway renamed this task from "All edits in Wikidata tagged as "suggested edits" between approx. 23:40 and 00:00 UTC on 2020-03-11" to "All edits on Wikidata and Commons tagged as "suggested edits" between approx. 23:40 and 00:00 UTC on 2020-03-11". TASK DETAIL https://phabricator.wikimedia.org/T247479 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, Liuxinyu970226, Aklapper, Bugreporter, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, SBisson, Wikidata-bugs, bearND, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T247479: All edits in Wikidata tagged as "suggested edits" between approx. 23:40 and 00:00 UTC on 2020-03-11
Mholloway edited projects, added Product-Infrastructure-Team-Backlog (Kanban); removed Product-Infrastructure-Team-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T247479 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, Liuxinyu970226, Aklapper, Bugreporter, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, SBisson, Wikidata-bugs, bearND, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T247479: All edits in Wikidata tagged as "suggested edits" between approx. 23:40 and 00:00 UTC on 2020-03-11
Mholloway renamed this task from "All edits in Wikidata are tagged as "suggested edits"" to "All edits in Wikidata tagged as "suggested edits" between approx. 23:40 and 00:00 UTC on 2020-03-11". TASK DETAIL https://phabricator.wikimedia.org/T247479 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, Liuxinyu970226, Aklapper, Bugreporter, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Lowered Priority] T247479: All edits in Wikidata are tagged as "suggested edits"
Mholloway lowered the priority of this task from "Unbreak Now!" to "High". Mholloway added a comment. Lowering the priority since this is no longer happening. TASK DETAIL https://phabricator.wikimedia.org/T247479 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, Liuxinyu970226, Aklapper, Bugreporter, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T247479: All edits in Wikidata are tagged as "suggested edits"
Mholloway added a comment. The code that caused the issue was reverted. Some additional cleanup will be needed. TASK DETAIL https://phabricator.wikimedia.org/T247479 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, Liuxinyu970226, Aklapper, Bugreporter, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T247479: All edits in Wikidata are tagged as "suggested edits"
Mholloway added a comment. Should be fixed by the above, can someone verify? TASK DETAIL https://phabricator.wikimedia.org/T247479 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, Liuxinyu970226, Aklapper, Bugreporter, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T247479: All edits in Wikidata are tagged as "suggested edits"
Mholloway claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T247479 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, Liuxinyu970226, Aklapper, Bugreporter, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)
Mholloway added a comment. I abandoned my patch in favor of those from @WMDE-leszek, which look good to me. I'll add my +1s but I think it's probably more appropriate for full-time Wikibase and WikibaseMediaInfo devs to merge. TASK DETAIL https://phabricator.wikimedia.org/T229280 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Tarrow, Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T233610: Internal error from MachineVision on action=info for files: argument to RandomWikidataIdHandler must be WikidataDepictsSetter, LabelResolver given
Mholloway closed this task as "Resolved". Mholloway claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T233610 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Ramsey-WMF, Mholloway, Lucas_Werkmeister_WMDE, Aklapper, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Af420, E1presidente, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Salgo60, WSH1906, Lewizho99, Maathavan, Silverfish, _jensen, rosalieper, Susannaanas, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Jdforrester-WMF, Steinsplitter, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T233610: Internal error from MachineVision on action=info for files: argument to RandomWikidataIdHandler must be WikidataDepictsSetter, LabelResolver given
Mholloway added a comment. Sorry, pretty sure a config needs updating. Will do now. TASK DETAIL https://phabricator.wikimedia.org/T233610 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Ramsey-WMF, Mholloway, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, DannyS712, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Susannaanas, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Jdforrester-WMF, Steinsplitter, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)
Mholloway added a comment. Update: https://commons.wikimedia.org/wiki/File:Susana_Pavon_Instagram.jpg and https://commons.wikimedia.org/wiki/File:Rockstar_San_Diego_Logo.svg.png / https://commons.wikimedia.org/w/index.php?title=File:Rockstar_San_Diego_Logo.svg.png=no are fixed (by https://gerrit.wikimedia.org/r/534854, presumably), but https://commons.wikimedia.org/w/index.php?title=File:Buddha_with_Naga_(snake).jpg=no still throws. TASK DETAIL https://phabricator.wikimedia.org/T229280 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Edtadros, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T232063: RuntimeException breaking CI builds
Mholloway closed this task as "Resolved". Mholloway added a comment. Looks resolved, thanks! TASK DETAIL https://phabricator.wikimedia.org/T232063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde, Mholloway Cc: Pablo-WMDE, hashar, WMDE-leszek, Aklapper, Mholloway, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, thcipriani, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)
Mholloway added a comment. Yeah, this is something of a stopgap. I think part of the issue here is that just creating a redirect to the file page of a duplicate file seems like the wrong thing to do on an editor's part, though I'd need to check on-wiki for what it has to say about this. There is the capability to delete a file and its page on grounds that it's a duplicate (though only admins and the like have this right), which seems like what should have happened here, but it doesn't appear to do any reconciliation of content. It would be good if Commons had something like Phabricator's "close as duplicate" functionality that would at least attempt to merge the mediainfo content for the two. TASK DETAIL https://phabricator.wikimedia.org/T229280 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Edtadros, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T232063: RuntimeException breaking CI builds
Mholloway updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T232063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Aklapper, Mholloway, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T232063: RuntimeException breaking CI builds
Mholloway triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T232063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Aklapper, Mholloway, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g, hashar ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T232063: RuntimeException breaking CI builds
Mholloway created this task.
Mholloway added projects: Continuous-Integration-Infrastructure, DataValues.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.
TASK DESCRIPTION
As illustrated on the CI results for
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/534536/13, a
dependency issue is breaking CI builds for most jobs. My guess is that it's
related to the recent release
<https://github.com/DataValues/DataValues/releases> of DataValues 2.2.0.
23:04:13 [178.9MB/4.90s] Generating autoload files
23:04:13
23:04:13
23:04:13 [RuntimeException]
23:04:13 Could not scan for classes inside
"/workspace/src/extensions/Wikibase/vendor/data-values/data-values/tests/phpunit/DataValueTest.php"
which does not appear to be a file nor a folder
23:04:13
23:04:13
23:04:13 Exception trace:
23:04:13 () at
/srv/composer/vendor/composer/composer/src/Composer/Autoload/ClassMapGenerator.php:69
23:04:13 Composer\Autoload\ClassMapGenerator::createMap() at
/srv/composer/vendor/composer/composer/src/Composer/Autoload/AutoloadGenerator.php:336
23:04:13 Composer\Autoload\AutoloadGenerator->generateClassMap() at
/srv/composer/vendor/composer/composer/src/Composer/Autoload/AutoloadGenerator.php:319
23:04:13 Composer\Autoload\AutoloadGenerator->addClassMapCode() at
/srv/composer/vendor/composer/composer/src/Composer/Autoload/AutoloadGenerator.php:266
23:04:13 Composer\Autoload\AutoloadGenerator->dump() at
/srv/composer/vendor/composer/composer/src/Composer/Installer.php:303
23:04:13 Composer\Installer->run() at
/srv/composer/vendor/composer/composer/src/Composer/Command/InstallCommand.php:119
23:04:13 Composer\Command\InstallCommand->execute() at
/srv/composer/vendor/symfony/console/Command/Command.php:241
23:04:13 Symfony\Component\Console\Command\Command->run() at
/srv/composer/vendor/symfony/console/Application.php:843
23:04:13 Symfony\Component\Console\Application->doRunCommand() at
/srv/composer/vendor/symfony/console/Application.php:193
23:04:13 Symfony\Component\Console\Application->doRun() at
/srv/composer/vendor/composer/composer/src/Composer/Console/Application.php:251
23:04:13 Composer\Console\Application->doRun() at
/srv/composer/vendor/symfony/console/Application.php:117
23:04:13 Symfony\Component\Console\Application->run() at
/srv/composer/vendor/composer/composer/src/Composer/Console/Application.php:100
23:04:13 Composer\Console\Application->run() at
/srv/composer/vendor/composer/composer/bin/composer:60
23:04:13
23:04:13 install [--prefer-source] [--prefer-dist] [--dry-run] [--dev]
[--no-dev] [--no-custom-installers] [--no-autoloader] [--no-scripts]
[--no-progress] [--no-suggest] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader]
[-a|--classmap-authoritative] [--apcu-autoloader] [--ignore-platform-reqs] [--]
[]...
23:04:13
23:04:13 multiprocessing.pool.RemoteTraceback:
23:04:13 """
23:04:13 Traceback (most recent call last):
23:04:13 File "/usr/lib/python3.5/multiprocessing/pool.py", line 119, in
worker
23:04:13 result = (True, func(*args, **kwds))
23:04:13 File "/usr/local/lib/python3.5/dist-packages/quibble/util.py",
line 39, in task_wrapper
23:04:13 ret = func(*func_args)
23:04:13 File
"/usr/local/lib/python3.5/dist-packages/quibble/commands.py", line 220, in
run_extskin_composer
23:04:13 subprocess.check_call(cmd, cwd=self.directory)
23:04:13 File "/usr/lib/python3.5/subprocess.py", line 271, in check_call
23:04:13 raise CalledProcessError(retcode, cmd)
23:04:13 subprocess.CalledProcessError: Command '['composer', '--ansi',
'install', '--no-progress', '--prefer-dist', '--profile', '-v']' returned
non-zero exit status 1
23:04:13 """
23:04:13
23:04:13 The above exception was the direct cause of the following
exception:
23:04:13
23:04:13 Traceback (most recent call last):
23:04:13 File "/usr/local/bin/quibble", line 11, in
23:04:13 load_entry_point('quibble==0.0.0', 'console_scripts',
'quibble')()
23:04:13 File "/usr/local/lib/python3.5/dist-packages/quibble/cmd.py",
line 465, in main
23:04:13 cmd.execut
[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)
Mholloway added a comment. Propsed a possible fix, but needs review by someone with deeper Wikibase knowledge than I have in case there are negative implications I'm not seeing. TASK DETAIL https://phabricator.wikimedia.org/T229280 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Edtadros, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)
Mholloway added a comment. This can be reproduced locally by uploading a file, adding mediainfo content, then editing the page wikitext to hand-create a redirect (e.g., change the page content to `#REDIRECT [[File:Foo.jpg]]`). TASK DETAIL https://phabricator.wikimedia.org/T229280 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, darthmon_wmde, Edtadros, DannyS712, Nandana, JKSTNK, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)
Mholloway added a comment.
From the various reports it sounds like there are a couple of
probably-related errors here, but I think this is the code path at least one of
them. TL;DR There seems to be an expectation of some bookkeeping happening in
the entity content when a related page becomes a redirect page, and that isn't
actually happening, which breaks subsequent assumptions.
File:Rockstar_San_Diego_Logo.svg.png
<https://commons.wikimedia.org/wiki/File:Rockstar_San_Diego_Logo.svg.png> has
page ID 76630136.
RevisionBasedEntityLookup::hasEntity() calls getLatestRevisionId() on its
member EntityRevisionLookup, which is a WikiPageEntityRevisionLookup.
WikiPageEntityRevisionLookup loads page and revision info from the DB, and sees
that the associated page is a redirect page:
mysql:research@dbstore1004.eqiad.wmnet [commonswiki]> select
page_is_redirect from page where page_id = 76630136;
+--+
| page_is_redirect |
+--+
|1 |
+--+
1 row in set (0.00 sec)
Seeing that the page is a redirect, it attempts to load an EntityRedirect
object in its private loadEntity method, but instead finds a still-existing,
valid MediaInfo entity:
>>> $slot =
MediaWiki\MediaWikiServices::getInstance()->getRevisionStore()->getRevisionByTitle(
Title::newFromText( 'File:Rockstar_San_Diego_Logo.svg.png' ) )->getSlot(
'mediainfo' );
=> MediaWiki\Revision\SlotRecord {#1459}
>>> $blob =
Mediawiki\MediawikiServices::getInstance()->getBlobStore()->getBlob(
$slot->getAddress() );
=>
"{"type":"mediainfo","id":"M76630136","labels":{"ja":{"language":"ja","value":"\u30ed\u30b4"}},"descriptions":[],"statements":[]}"
>>> $entity =
Wikibase\Repo\WikibaseRepo::getDefaultInstance()->getEntityContentDataCodec()->decodeEntity(
$blob, $slot->getFormat() );
=> Wikibase\MediaInfo\DataModel\MediaInfo {#6194}
So it returns that and a null EntityRedirect instead of the EntityRedirect
that the calling was expecting, and then errors out when calling getTargetId()
on the null EntityRevision.
From looking at the decodeEntity and decodeRedirect methods of
EntityContentDataCodec, It looks like the expectation is that the entity
content would have a `redirect` key, causing decodeEntity to return null and
signal to the caller to attempt to decode the content as a redirect, but we as
we can see from the content blob, there is no `redirect` key present:
=>
"{"type":"mediainfo","id":"M76630136","labels":{"ja":{"language":"ja","value":"\u30ed\u30b4"}},"descriptions":[],"statements":[]}"
TASK DETAIL
https://phabricator.wikimedia.org/T229280
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Mholloway
Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin,
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen,
darthmon_wmde, Edtadros, DannyS712, Nandana, JKSTNK, Lahi, Gq86,
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas,
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331,
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979
Mholloway added a comment. Better, if we want to preserve the correspondence between mediainfo IDs and page IDs, would be to hook into ArticleUndelete <https://www.mediawiki.org/wiki/Manual:Hooks/ArticleUndelete> and update the mediainfo ID if the page ID has changed. (Despite what its name might suggest, that hook isn't restricted to NS_MAIN, but appears to fire when any page from any namespace is restored.) TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Cparle, Mholloway, Addshore, hashar, ArielGlenn, Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979
Mholloway added a comment. What //should// happen here? Should the entity always retain its original ID even after a page move, or should the entity ID always reflect the current page ID of the page with which it's associated? The assumption that the entity ID will always reflect the (current) page ID seems pretty well baked in at this point, so maybe the entity IDs should just be updated as discrepancies are found. On the other hand, that risks masking any deeper issues that arise. TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Cparle, Mholloway, Addshore, hashar, ArielGlenn, Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T231367: Update /page/definitions to use lexemes from Wikidata
Mholloway updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T231367 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Aklapper, Mholloway, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, bearND, aude, Darkdadaah, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T229482: PHP Warning: Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup::getEntityRevision: Entity not loaded
Mholloway closed this task as "Resolved". Mholloway claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T229482 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: daniel, WMDE-leszek, Smalyshev, egardner, Mholloway, Lydia_Pintscher, Ladsgroup, alaa_wmde, Liuxinyu970226, Aklapper, brennen, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Jonas, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Jdforrester-WMF, Steinsplitter, Mbch331, Jay8g, Krenair, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T229482: PHP Warning: Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup::getEntityRevision: Entity not loaded
Mholloway added a comment. Confirmed on the Beta Cluster that this is working as intended. TASK DETAIL https://phabricator.wikimedia.org/T229482 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: daniel, WMDE-leszek, Smalyshev, egardner, Mholloway, Lydia_Pintscher, Ladsgroup, alaa_wmde, Liuxinyu970226, Aklapper, brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Jonas, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Jdforrester-WMF, Steinsplitter, Mbch331, Jay8g, Krenair, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T229482: PHP Warning: Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup::getEntityRevision: Entity not loaded
Mholloway added a comment. The patch just merged drops the log level for this to `debug`, and I see that this follow-up (https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/527090/) changes it again to `info`. Does dropping the log level below `warning` suffice to unblock the train? TASK DETAIL https://phabricator.wikimedia.org/T229482 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: daniel, WMDE-leszek, Smalyshev, egardner, Mholloway, Lydia_Pintscher, Ladsgroup, alaa_wmde, Liuxinyu970226, Aklapper, brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Jonas, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Jdforrester-WMF, Steinsplitter, Mbch331, Jay8g, Krenair, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T229482: PHP Warning: Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup::getEntityRevision: Entity not loaded
Mholloway added a comment. I believe this warning occurs in a scenario that indicates an error in Wikidata but is expected in WikibaseMediaInfo/Structured Data on Commons, namely that an entity ID exists but there is no Wikibase content blob yet associated with it. So these warnings don't indicate a problem per se. It's just that WikibaseMediaInfo changed how it initializes a UI component in a way that hits this code path. The fix is to find a principled way of determining whether we should care about the absence of a content blob before logging the warning. TASK DETAIL https://phabricator.wikimedia.org/T229482 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, Lydia_Pintscher, Ladsgroup, alaa_wmde, Liuxinyu970226, Aklapper, brennen, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Jdforrester-WMF, Steinsplitter, Mbch331, Jay8g, Krenair, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Reassigned] T200594: Add client identifier to requests sent from Kartotherian to WDQS
Mholloway reassigned this task from Mholloway to MSantos. TASK DETAIL https://phabricator.wikimedia.org/T200594 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: MSantos, Mholloway Cc: Stashbot, mobrovac, MSantos, Gehel, Aklapper, MaxSem, Pnorman, Mholloway, Smalyshev, darthmon_wmde, holger.knust, Nandana, Amatissart, Lahi, Gq86, Looniverse, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, Orienteerix, merbst, LawExplorer, _jensen, rosalieper, JGirault, Pchelolo, Jonas, phabyogi, Xmlizer, Susannaanas, lxbarth, Eevans, jkroll, Planemad, Hardikj, Wikidata-bugs, Jdouglas, bearND, aude, Tobias1984, Manybubbles, Yurik, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200594: Add client identifier to requests sent from Kartotherian to WDQS
Mholloway added a comment. @Gehel I believe I had marked this blocked earlier pending the Stretch migration, but now that's complete and the Geoshapes update should be deployed. Can you confirm whether Kartotherian is now sending `X-Client-IP`? TASK DETAIL https://phabricator.wikimedia.org/T200594 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Stashbot, mobrovac, MSantos, Gehel, Aklapper, MaxSem, Pnorman, Mholloway, Smalyshev, darthmon_wmde, Nandana, Amatissart, Lahi, Gq86, Looniverse, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, Orienteerix, merbst, LawExplorer, _jensen, rosalieper, JGirault, Pchelolo, Jonas, phabyogi, Xmlizer, Susannaanas, lxbarth, Eevans, jkroll, Planemad, Hardikj, Wikidata-bugs, Jdouglas, bearND, aude, Tobias1984, Manybubbles, Yurik, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service
Mholloway added a comment. Hmm, now that I'm digging, I see that the batching was just introduced: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/services/recommendation-api/+/9603d4282492103eecc0b1646ea2911138c848af%5E%21/lib/article.creation.translation.js TASK DETAIL https://phabricator.wikimedia.org/T226264 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Smalyshev, MSantos, Aklapper, Mholloway, darthmon_wmde, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Capt_Swing, Manybubbles, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service
Mholloway added a comment.
Sure. The specific URL that the flaky test is hitting is
https://de.wikipedia.org/api/rest_v1/data/recommendation/article/creation/translation/en.
Under the hood, the service is querying WDQS with this up to 10 times in
rapid succession, for a batched set of ~500 Wikidata item IDs:
SELECT ?item (COUNT(?sitelink) as ?count) WHERE {
VALUES ?item { }
FILTER NOT EXISTS { ?item wdt:P31 wd:Q4167410 . }
OPTIONAL { ?sitelink schema:about ?item }
FILTER NOT EXISTS {
?article schema:about ?item .
?article schema:isPartOf <https://${target}.${projectDomain}/> .
}
} GROUP BY ?item
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/services/recommendation-api/+/master/lib/article.creation.translation.js#158
TASK DETAIL
https://phabricator.wikimedia.org/T226264
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Mholloway
Cc: Smalyshev, MSantos, Aklapper, Mholloway, darthmon_wmde, Nandana, Lahi,
Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst,
LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Wikidata-bugs,
Jdouglas, aude, Tobias1984, Capt_Swing, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service
Mholloway renamed this task from "CI testing is flaky due to frequent 429s from Wikidata Query Service" to "Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service". TASK DETAIL https://phabricator.wikimedia.org/T226264 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Aklapper, Mholloway, darthmon_wmde, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Capt_Swing, Manybubbles, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T226264: CI testing is flaky due to frequent 429s from Wikidata Query Service
Mholloway created this task. Mholloway added projects: Recommendation-API, Wikidata-Query-Service. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION The recommendation API CI tests frequently fail due to a 429 response from WDQS in the one test that consumes it. Example: https://integration.wikimedia.org/ci/job/service-pipeline-test/2270/console Is CI really consuming WDQS to the point of regularly hitting the intended rate limiting threshold, or is this a WDQS bug? If not a bug, can some provision for CI be made in WDQS, or should this be addressed on the recommendation API side (perhaps by running the offending test on something like one run in ten)? TASK DETAIL https://phabricator.wikimedia.org/T226264 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Aklapper, Mholloway, darthmon_wmde, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Capt_Swing, Manybubbles, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T224678: Feature request: ability to include labels for related entities in wbgetentities responses
Mholloway added a project: Reading-Infrastructure-Team-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T224678 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, Aklapper, JoeWalsh, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T224125: Wikibase and WikibaseLexeme Selenium tests fail when UseCirrus is true in WikibaseCirrusSearch
Mholloway updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T224125 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Aklapper, EBernhardson, Smalyshev, zeljkofilipin, Mholloway, darthmon_wmde, Redabr4, Zanziii, Sadisticturd, Nandana, A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, hashar, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T224125: Wikibase and WikibaseLexeme Selenium tests fail when UseCirrus is true in WikibaseCirrusSearch
Mholloway updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T224125 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Aklapper, EBernhardson, Smalyshev, zeljkofilipin, Mholloway, darthmon_wmde, Redabr4, Zanziii, Sadisticturd, Nandana, A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, hashar, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T224125: Wikibase and WikibaseLexeme Selenium tests fail when UseCirrus is true in WikibaseCirrusSearch
Mholloway created this task. Mholloway added projects: MediaWiki-extensions-WikibaseRepository, CirrusSearch, Continuous-Integration-Config, Reading-Infrastructure-Team-Backlog. Restricted Application added a subscriber: Aklapper. Restricted Application added projects: Wikidata, Discovery-Search. TASK DESCRIPTION WikibaseCirrusSearch has a `UseCirrus` config variable that currently defaults to false, disabling its functionality. This is a confusing default, and can create hassles for developers trying to set it up in a testing environment. It should default to true. The trouble is that changing the default to true breaks several Selenium tests for the Wikibase and WikibaseLexeme extensions, as shown in the failing test jobs on https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseCirrusSearch/+/507597/. Adding a `$wgWBCSUseCirrus = false;` directive to `tests/selenium/LocalSettings.php` in WikibaseCirrusSearch does not resolve this problem, and based on my local testing, adding the same directive directly to Wikibase does not help, either. Ultimately, we shouldn't be trying to work around the problem; the testing environment should be able to accommodate WikibaseCirrusSearch. TASK DETAIL https://phabricator.wikimedia.org/T224125 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Aklapper, EBernhardson, Smalyshev, zeljkofilipin, Mholloway, darthmon_wmde, Redabr4, Zanziii, Sadisticturd, Nandana, A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, hashar, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T220153: Beta Wikidata: Error: 1146 Table 'wikishared.wikimedia_editor_tasks_keys' doesn't exist
Mholloway claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T220153 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, Krinkle, Aklapper, MarcoAurelio, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T220153: Beta Wikidata: Error: 1146 Table 'wikishared.wikimedia_editor_tasks_keys' doesn't exist
Mholloway edited projects, added Reading-Infrastructure-Team-Backlog (Kanban); removed Reading-Infrastructure-Team-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T220153 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Mholloway, Krinkle, Aklapper, MarcoAurelio, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, bearND, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T200594: Add client identifier to requests sent from Kartotherian to WDQS
Mholloway edited projects, added Reading-Infrastructure-Team-Backlog; removed Reading-Infrastructure-Team-Backlog (Kanban). TASK DETAIL https://phabricator.wikimedia.org/T200594 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: Stashbot, mobrovac, MSantos, Gehel, Aklapper, MaxSem, Pnorman, Mholloway, Smalyshev, alaa_wmde, Nandana, Amatissart, Lahi, Gq86, Looniverse, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, Orienteerix, merbst, LawExplorer, _jensen, rosalieper, JGirault, Jonas, phabyogi, Xmlizer, Susannaanas, lxbarth, Eevans, jkroll, Planemad, Hardikj, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Yurik, Jdforrester-WMF, Mbch331, Jay8g, bearND ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T215337: Cannot add sitelinks to items in MW-Vagrant
Mholloway closed this task as "Resolved".Mholloway claimed this task.Mholloway added a comment. Trimming the trailing '://' from the site_protocol values seems to fix this. (The docs for the sites table are misleading on this point.) A link can now be created to MWV's enwiki. (A PHP notice is thrown about enwiki being unknown when following the link, but the page loads.) I'll close this since my issue is resolved, but would suggest either updating the wikidata role to automate this linking, or updating the docs for the role to explain the additional needed setup.TASK DETAILhttps://phabricator.wikimedia.org/T215337EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: Aklapper, Mholloway, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T215337: Cannot add sitelinks to items in MW-Vagrant
Mholloway added a comment.
Update: I've managed to get the UI for adding new sitelinks to show by manually adding entries to the sites table for wikidatawiki. Still, when attempting to add one I'm getting an error message stating that the referenced page isn't found:
A page "Foo" could not be found on "enwiki".
The external client site "enwiki" did not provide page information for page "Foo".
Current sites table content (I'm just trying to link to enwiki (en.wiki.local.wmftest.net:8080) for now):
site_idsite_global_keysite_typesite_groupsite_sourcesite_languagesite_protocolsite_domainsite_datasite_forwardsite_config
1enwikimediawikiwikipedialocalenhttp://ten.tsetfmw.lacol.ikiw.ne.a:1:{s:5:"paths";a:2:{s:9:"file_path";s:42:"http://en.wiki.local.wmftest.net:8080/w/$1";s:9:"page_path";s:45:"http://en.wiki.local.wmftest.net:8080/wiki/$1";}}0a:0:{}
2eswikimediawikiwikipedialocaleshttp://.a:0:{}0a:0:{}
3frwikimediawikiwikipedialocalfrhttp://.a:0:{}0a:0:{}
4ruwikimediawikiwikipedialocalruhttp://.a:0:{}0a:0:{}
TASK DETAILhttps://phabricator.wikimedia.org/T215337EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: Aklapper, Mholloway, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T215337: Cannot add sitelinks to items in MW-Vagrant
Mholloway updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...I've created a new item Q1, and would like to add one or more sitelinks. The [[ https://www.mediawiki.org/wiki/MediaWiki-Vagrant/Roles | docs state]] indicate that the `wikidata` role sets up the rest of the configured wikis as clients of `wikidatawiki`, but when attempting to add a sitelink, I'm not provided with any wikis to link:...TASK DETAILhttps://phabricator.wikimedia.org/T215337EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: Aklapper, Mholloway, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T215337: Cannot add sitelinks to items in MW-Vagrant
Mholloway created this task.Mholloway added projects: Wikidata, Reading-Infrastructure-Team-Backlog.Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONI am working with a fresh MediaWiki-Vagrant instance with the wikidata role applied. I've created a new item Q1, and would like to add one or more sitelinks. The docs state that the wikidata role sets up the rest of the configured wikis as clients of wikidatawiki, but when attempting to add a sitelink, I'm not provided with any wikis to link: F28128440: Kapture 2019-02-05 at 14.25.18.gif (Screengrab created at https://wikidata-edit-counts.wmflabs.org/wiki/Q1) Is additional manual configuration required, or is this a bug in the Vagrant role?TASK DETAILhttps://phabricator.wikimedia.org/T215337EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: Aklapper, Mholloway, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T194750: Deploy Structured Data on Commons baseline
Mholloway added a parent task: T209997: Create a new API endpoint which returns Commons images in need of a caption translation. TASK DETAILhttps://phabricator.wikimedia.org/T194750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: RP88, Cparle, Aklapper, Abit, Ramsey-WMF, daniel, EvanProdromou, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, LawExplorer, JJMC89, _jensen, Agabi10, D3r1ck01, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Fabrice_Florin, Jdforrester-WMF, Matanya, Mbch331, Ltrlg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T194750: Deploy Structured Data on Commons baseline
Mholloway removed a subtask: T209997: Create a new API endpoint which returns Commons images in need of a caption translation. TASK DETAILhttps://phabricator.wikimedia.org/T194750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: RP88, Cparle, Aklapper, Abit, Ramsey-WMF, daniel, EvanProdromou, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, LawExplorer, JJMC89, _jensen, Agabi10, D3r1ck01, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Fabrice_Florin, Jdforrester-WMF, Matanya, Mbch331, Ltrlg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T194750: Deploy Structured Data on Commons baseline
Mholloway added a subtask: T209997: Create a new API endpoint which returns Commons images in need of a caption translation. TASK DETAILhttps://phabricator.wikimedia.org/T194750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: RP88, Cparle, Aklapper, Abit, Ramsey-WMF, daniel, EvanProdromou, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, LawExplorer, JJMC89, _jensen, Agabi10, D3r1ck01, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Fabrice_Florin, Jdforrester-WMF, Matanya, Mbch331, Ltrlg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T156358: enable Wikivoyage maps on Welsh Wikipedia (cywiki) for lists from Wikidata
Mholloway triaged this task as "Lowest" priority. TASK DETAILhttps://phabricator.wikimedia.org/T156358EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: Ayack, Aklapper, Esc3300, Nandana, MSantos, Lahi, Gq86, Looniverse, GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, Ddproxy, JGirault, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Yurik, Jdforrester-WMF, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T156358: enable Wikivoyage maps on Welsh Wikipedia (cywiki) for lists from Wikidata
Mholloway added a project: Reading-Infrastructure-Team-Backlog. TASK DETAILhttps://phabricator.wikimedia.org/T156358EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: Ayack, Aklapper, Esc3300, Nandana, MSantos, Lahi, Gq86, Looniverse, GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, Ddproxy, JGirault, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, Yurik, Jdforrester-WMF, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T159205: List of openstreetmap items with Wikidata id
Mholloway removed a project: Maps (Kartographer). TASK DETAILhttps://phabricator.wikimedia.org/T159205EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: mxn, PokestarFan, Pnorman, Sabas88, Abbe98, MaxSem, Yurik, Deskana, JGirault, Zache, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331, MSantos, Looniverse, Orienteerix, Ddproxy, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T173052: Show OpenStreetMap features associated with Wikidata items
Mholloway added a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T173052EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mxn, MhollowayCc: debt, TheDJ, Planemad, Pigsonthewing, Aklapper, mxn, PokestarFan, MSantos, Lahi, Gq86, Looniverse, GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, Ddproxy, JGirault, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Wikidata-bugs, aude, Yurik, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200594: Add client identifier to requests sent from Kartotherian to WDQS
Mholloway added a comment. https://github.com/kartotherian/geoshapes/pull/1TASK DETAILhttps://phabricator.wikimedia.org/T200594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: mobrovac, MSantos, Gehel, Aklapper, MaxSem, Pnorman, Mholloway, Smalyshev, Amatissart, Lahi, Gq86, Looniverse, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Naveenpf, JGirault, Jonas, phabyogi, Xmlizer, Susannaanas, lxbarth, Eevans, jkroll, Planemad, Hardikj, Wikidata-bugs, Jdouglas, bearND, aude, Tobias1984, Manybubbles, Yurik, Jdforrester-WMF, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T200594: Add client identifier to requests sent from Kartotherian to WDQS
Mholloway claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T200594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: mobrovac, MSantos, Gehel, Aklapper, MaxSem, Pnorman, Mholloway, Smalyshev, Amatissart, Lahi, Gq86, Looniverse, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Naveenpf, JGirault, Jonas, phabyogi, Xmlizer, Susannaanas, lxbarth, Eevans, jkroll, Planemad, Hardikj, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Yurik, Jdforrester-WMF, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T200594: Add client identifier to requests sent from Kartotherian to WDQS
Mholloway edited projects, added Reading-Infrastructure-Team-Backlog (Kanban); removed Reading-Infrastructure-Team-Backlog. TASK DETAILhttps://phabricator.wikimedia.org/T200594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: mobrovac, MSantos, Gehel, Aklapper, MaxSem, Pnorman, Mholloway, Smalyshev, Amatissart, Lahi, Gq86, Looniverse, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Naveenpf, JGirault, Jonas, phabyogi, Xmlizer, Susannaanas, lxbarth, Eevans, jkroll, Planemad, Hardikj, Wikidata-bugs, Jdouglas, bearND, aude, Tobias1984, Manybubbles, Yurik, Jdforrester-WMF, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200594: Add client identifier to requests sent from Kartotherian to WDQS
Mholloway added a comment.
I've got a patch to pass through the X-Client-IP header to WDQS. However, if I'm interpreting the VCL code correctly, it looks like it will be stripped in Varnish and replaced with the IP of the requesting Kartotherian host when hitting the public WDQS endpoint:
https://github.com/wikimedia/puppet/blob/production/modules/varnish/templates/vcl/wikimedia-frontend.vcl.erb#L186-L191
sub recv_fe_ip_processing {
[...]
if (client.ip !~ local_host) {
// only the local nginx TLS terminator should set these at all -
// there are no other internal exceptions to that rule
unset req.http.X-Client-IP;
unset req.http.X-Connection-Properties;
}
[...]
}
If we're sure that it's reasonably safe to bypass the cache and hit the internal WDQS endpoint instead, then that doesn't matter, of course. Updating Kartotherian to hit the internal endpoint is just a matter of deploying a config change. (I should note that we're blocked on deploying Kartotherian in production until updating the maps cluster to Stretch is complete, but we could still test this in the beta cluster in the meantime.)TASK DETAILhttps://phabricator.wikimedia.org/T200594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: mobrovac, MSantos, Gehel, Aklapper, MaxSem, Pnorman, Mholloway, Smalyshev, Amatissart, Lahi, Gq86, Looniverse, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Naveenpf, JGirault, Jonas, phabyogi, Xmlizer, Susannaanas, lxbarth, Eevans, jkroll, Planemad, Hardikj, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Yurik, Jdforrester-WMF, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200594: Add client identifier to requests sent from Kartotherian to WDQS
Mholloway added a comment. It would be very easy to add the requesting IP to the user-agent string. We could also explore adding an X-Client-IP header; needs investigation on the Varnish end. Does WDQS have an internal URI (similar to restbase.svc.codfw.wmnet) that we could/should use in production? Currently we're using the public endpoint. config.wikidataQueryService = 'https://query.wikidata.org/bigdata/namespace/wdq/sparql'; https://github.com/kartotherian/geoshapes/blob/1acbc3768278ef4478517f16cc1a317e364bde99/geoshapes.js#L36TASK DETAILhttps://phabricator.wikimedia.org/T200594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: MSantos, Gehel, Aklapper, MaxSem, Pnorman, Mholloway, Smalyshev, Amatissart, Lahi, Gq86, Looniverse, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, Orienteerix, merbst, LawExplorer, debt, JGirault, Jonas, phabyogi, Xmlizer, Susannaanas, lxbarth, Eevans, mobrovac, jkroll, Planemad, Hardikj, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Yurik, Jdforrester-WMF, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177475: Create a map-on-the-fly feature for people and objects for Wikidata items
Mholloway added a comment. The WMF maps team won't have bandwidth to work on this in the foreseeable future. WMDE or volunteer patches welcome.TASK DETAILhttps://phabricator.wikimedia.org/T177475EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: Mholloway, Lucas_Werkmeister_WMDE, Jonas, Fnielsen, Smalyshev, debt, mxn, Multichill, Aklapper, Jane023, Lahi, Gq86, Looniverse, GoranSMilovanovic, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Salgo60, JGirault, phabyogi, Xmlizer, Susannaanas, lxbarth, jkroll, Planemad, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Yurik, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T200594: Add client identifier to requests sent from Kartotherian to WDQS
Mholloway updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONIt would be nice if Kartotherian when calling [[ https://www.wikidata.org/wiki/Wikidata:SPARQL_query_service | Wikidata Query Service (WDQS) ]] on behalf of the client would identify which client requested it. Since WDQS is an internal WMF service, there should be no PII proliferation concern about it, and we could have more efficient load controls and throttling for itTASK DETAILhttps://phabricator.wikimedia.org/T200594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: MSantos, Gehel, Aklapper, MaxSem, Pnorman, Mholloway, Smalyshev, Amatissart, Lahi, Gq86, Looniverse, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, Orienteerix, merbst, LawExplorer, debt, JGirault, Jonas, phabyogi, Xmlizer, Susannaanas, lxbarth, Eevans, mobrovac, jkroll, Planemad, Hardikj, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Yurik, Jdforrester-WMF, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T200594: Add client identifier to requests sent from Kartotherian to WDQS
Mholloway added projects: Reading-Infrastructure-Team-Backlog, Services, Maps-Sprint. TASK DETAILhttps://phabricator.wikimedia.org/T200594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: Gehel, Aklapper, MaxSem, Pnorman, Mholloway, Smalyshev, Amatissart, Lahi, Gq86, Looniverse, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, Orienteerix, merbst, LawExplorer, debt, JGirault, Jonas, phabyogi, Xmlizer, Susannaanas, lxbarth, Eevans, mobrovac, jkroll, Planemad, Hardikj, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Yurik, Jdforrester-WMF, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T186218: Show wikidata descriptions on wikipedias
Mholloway removed a project: Extension-MobileApp. TASK DETAILhttps://phabricator.wikimedia.org/T186218EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: Tbayer, jhsoby, Lydia_Pintscher, Addshore, Aklapper, daniel, Lahi, Gq86, Sharvaniharan, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Dbrant, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T173841: [BUG] Wikidata description for Simple English should be shown on Simple English articles if it differs from the value for English
Mholloway added a comment. The action API on Simple English Wikipedia returns the "regular" English description for Algae despite a separate one being defined for Simple English: https://simple.wikipedia.org/w/api.php?action=""> Based on other issues in #ContentTranslation having to do with the Simple English language code (see T110190 for related discussion) I have a hunch this isn't a MediaWiki API problem but rather an underlying config issue.TASK DETAILhttps://phabricator.wikimedia.org/T173841EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: Mholloway, Tbayer, Aklapper, RHo, Maggouri, Jcasariego, GoranSMilovanovic, nickisverygood, QZanden, Designsbydavesconcepts, Serumulapiet, Sethakill, dg711, donaldepig, Izno, LNDDYL, Wikidata-bugs, aude, Dbrant, jayvdb, Anomie, Mbch331, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T172829: Wikidata doesn't return wikidata description for main page
Mholloway added a comment. Nothing to block it in the Android app.TASK DETAILhttps://phabricator.wikimedia.org/T172829EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: bearND, Fjalapeno, gerritbot, aude, Mholloway, Aklapper, PokestarFan, Jdlrobson, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T159678: [Bug] Special:Nearby isn't showing thumbnails on Wikidata
Mholloway removed a parent task: T153823: Verify page images API free / nonfree image changes don't cause a regression in the Android app.. TASK DETAILhttps://phabricator.wikimedia.org/T159678EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MhollowayCc: hoo, aude, Jonas, thiemowmde, Aklapper, Lydia_Pintscher, Antohabio, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T149456: Wikidata description change doesn't trigger mobile-sections update
Mholloway edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Kanban).Mholloway added a comment. Moving this back off the kanban board and to Tracking on the main app board since I don't think there's anything for Android engineering to do at this point.TASK DETAILhttps://phabricator.wikimedia.org/T149456EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pchelolo, MhollowayCc: Niedzielski, mobrovac, daniel, aude, hoo, Pchelolo, Aklapper, Dbrant, Mholloway, gerritbot, bearND, Ramalepe, Liugev6, Designsbydavesconcepts, Serumulapiet, Lewizho99, Maathavan, D3r1ck01, donaldepig, Izno, Eevans, Hardikj, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T97566: Add an instruction field for Wikidata items
Mholloway moved this task from Backlog to Tracking on the Mobile-Apps board. TASK DETAIL https://phabricator.wikimedia.org/T97566 WORKBOARD https://phabricator.wikimedia.org/project/board/66/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mholloway Cc: StudiesWorld, Smalyshev, Ricordisamoa, Wwes, jeremyb, thiemowmde, MGChecker, aude, JKatzWMF, Thryduulf, Moushira, Yair_rand, Tbayer, Filceolaire, Jdforrester-WMF, Pigsonthewing, Tfinc, Deskana, Mhurd, Lydia_Pintscher, Aklapper, kaldari, D3r1ck01, Izno, Mholloway, Wikidata-bugs, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T90765: Hacking: Make app Wikidata description editable
Mholloway removed a subscriber: Mholloway. TASK DETAIL https://phabricator.wikimedia.org/T90765 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Vibhabamba, Mholloway Cc: Matanya, Yair_rand, Ainali, Lydia_Pintscher, kaldari, JKatzWMF, Fjalapeno, jeblad, aude, bearND, Tbayer, Rberchie, hoo, Krenair, Qgil, Vibhabamba, Mhurd, Aklapper, Cxyshine, AlexWang, Wikidata-bugs, Daniel_Mietchen, Dbrant, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T90765: Hacking: Make app Wikidata description editable
Mholloway removed a project: Wikimania-Hackathon-2015. TASK DETAIL https://phabricator.wikimedia.org/T90765 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Vibhabamba, Mholloway Cc: Mholloway, Matanya, Yair_rand, Ainali, Lydia_Pintscher, kaldari, JKatzWMF, Fjalapeno, jeblad, aude, bearND, Tbayer, Rberchie, hoo, Krenair, Qgil, Vibhabamba, Mhurd, Aklapper, Cxyshine, AlexWang, Wikidata-bugs, Daniel_Mietchen, Dbrant, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T90765: Hacking: Make app Wikidata description editable
Mholloway added a project: Wikimania-Hackathon-2015. TASK DETAIL https://phabricator.wikimedia.org/T90765 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Vibhabamba, Mholloway Cc: Matanya, Yair_rand, Ainali, Lydia_Pintscher, kaldari, JKatzWMF, Fjalapeno, jeblad, aude, bearND, Tbayer, Rberchie, hoo, Krenair, Qgil, Vibhabamba, Mhurd, Aklapper, Lynhg, Cxyshine, AlexWang, Wikidata-bugs, Malyacko, Daniel_Mietchen, Dbrant, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
