[Wikidata-bugs] [Maniphest] [Commented On] T216590: Queries of a certain size-range produce errors in Wikidata Query Service GUI
NoInkling added a comment. Thank you. TASK DETAIL https://phabricator.wikimedia.org/T216590 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: NoInkling Cc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, NoInkling, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T216590: Queries of a certain size-range produce errors in Wikidata Query Service GUI
NoInkling added a comment. @Lucas_Werkmeister_WMDE I can do it, but I didn't really want to go through the trouble of opening a developer account and going through the whole Gerrit setup and learning the workflow just for one change. Plus I'm not sure if it also requires regression tests. So you have my permission (it's only a tiny change anyway), otherwise I'll try and get around to it when I'm able. TASK DETAIL https://phabricator.wikimedia.org/T216590 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: NoInkling Cc: Lucas_Werkmeister_WMDE, Aklapper, NoInkling, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T216590: Queries of a certain size-range produce errors in Wikidata Query Service GUI
NoInkling created this task.NoInkling added projects: Wikidata, Wikidata-Query-Service.Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONLargish (but not too large) queries are failing with URI/header "too large" errors when using the interface at https://query.wikidata.org Browser/OS: Chrome 72 and Firefox 65 on Windows 10. Example 1 (431 error) Bad Message 431reason: Request Header Fields Too Large Example 2 (414 error) 414 Request-URI Too Large 414 Request-URI Too Large nginx/1.13.6 Once the query grows sufficiently large it works fine again: example I first noticed this around the 9th of January (2019) and posted here: https://www.mediawiki.org/wiki/Talk:Wikidata_Query_Service#Error:_%22414_Request-URI_Too_Large%22 As that post states, I had an unchanged query that was working only a couple of days before that. Technically, I believe that those errors arise due to the limits on GET requests, as noted in the manual. But if you look at the working example with the network tab open in your browser devtools, the GUI can transparently switch/fallback to making a POST request. Looking at the code repo for the client, the frontend logic that controls this fallback doesn't seem to have changed anytime recently, so my assumption is that there has been some sort of server upgrade or configuration change that changed how it responds when it fails. I'm guessing the frontend needs to be changed to account for that.TASK DETAILhttps://phabricator.wikimedia.org/T216590EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NoInklingCc: Aklapper, NoInkling, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T216590: Queries of a certain size-range produce errors in Wikidata Query Service GUI
NoInkling added a comment.
By modifying the code using browser local overrides, I can confirm that doing the equivalent (since it's minified) of changing the condition to this works:
if ( request.getAllResponseHeaders() === '' || request.status === 414 || request.status === 431 ) {
TASK DETAILhttps://phabricator.wikimedia.org/T216590EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NoInklingCc: Aklapper, NoInkling, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T216590: Queries of a certain size-range produce errors in Wikidata Query Service GUI
NoInkling added a comment. Whoops, this seems to be a dupe of T213889. Still, I hope the extra info is useful.TASK DETAILhttps://phabricator.wikimedia.org/T216590EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NoInklingCc: Aklapper, NoInkling, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T216590: Queries of a certain size-range produce errors in Wikidata Query Service GUI
NoInkling updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Looking at the [[ https://gerrit.wikimedia.org/r/plugins/gitiles/wikidata/query/gui/+blame/master/wikibase/queryService/api/Sparql.js#176 | code repo for the client ]], thecode repo for the client, the [[ https://gerrit.wikimedia.org/r/plugins/gitiles/wikidata/query/gui/+blame/master/wikibase/queryService/api/Sparql.js#176 | frontend logic that controls this fallback ]] doesn't seem to have changed anytime recently, so my assumption is that there has been some sort of server upgrade or configuration change that changed how it responds when it fails. I'm guessing the frontend needs to be changed to account for that.TASK DETAILhttps://phabricator.wikimedia.org/T216590EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NoInklingCc: Aklapper, NoInkling, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T216590: Queries of a certain size-range produce errors in Wikidata Query Service GUI
NoInkling added a comment. Also I might as well add here that clicking on the "Help" dropdown > "Give Feedback!" goes to https://www.mediawiki.org/w/index.php?title=Talk:Wikidata_query_service=""> (notice lower case) which doesn't post to the real page at Talk:Wikidata_Query_Service. There is a redirect set up, but the "new section" page doesn't respect that.TASK DETAILhttps://phabricator.wikimedia.org/T216590EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NoInklingCc: Aklapper, NoInkling, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T216590: Queries of a certain size-range produce errors in Wikidata Query Service GUI
NoInkling edited projects, added Wikidata Query UI; removed Wikidata-Query-Service. TASK DETAILhttps://phabricator.wikimedia.org/T216590EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NoInklingCc: Aklapper, NoInkling, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []
NoInkling added a comment. Here's a new example that's currently missing everything except claims, since the original was updated: https://www.wikidata.org/wiki/Special:EntityData/Q61519072.json As I noted elsewhere, it might not be such a big deal for _javascript_ clients since JS syntax/APIs that work on plain objects tend to also work on arrays, but in other languages this obviously isn't the case. Since it's kinda rare for an entity not to have a single label/description/alias/claim/sitelink, and this behaviour doesn't seem to be documented anywhere, it's not very likely that the person writing the client will think to account for this until it's too late.TASK DETAILhttps://phabricator.wikimedia.org/T138104EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NoInklingCc: NoInkling, hoo, Lucas_Werkmeister_WMDE, PokestarFan, Nikki, Ricordisamoa, Aklapper, Zppix, Tpt, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
