[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder
Peter closed this task as "Resolved". Peter added a comment. Cool, lets close this for now. TASK DETAIL https://phabricator.wikimedia.org/T287769 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Peter Cc: ItamarWMDE, larissagaulia, RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Astuthiodit_1, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder
Peter added a comment. @Lydia_Pintscher I think the main concern from the beginning would be if the JavaScript performance got worse over time and we wanted to add an alert for that. Today when I look at the metric (we measure CPU long tasks https://developer.mozilla.org/en-US/docs/Web/API/Long_Tasks_API) to see JavaScript is blocking the main thread. Looking at the data on that page I could only see one CPU long tasks that is 53 ms, and that is much better than the rest of our performance, so from my point of view I think we can skip it. TASK DETAIL https://phabricator.wikimedia.org/T287769 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Peter Cc: larissagaulia, RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder
Peter added a comment. So it turns out I never added the alert. I can add it now, but who should receive it? TASK DETAIL https://phabricator.wikimedia.org/T287769 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Peter Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder
Peter added a comment. I think this is ok as it is now. I can add a simple alert for the size and then if it fires we can sit-down and have look together. TASK DETAIL https://phabricator.wikimedia.org/T287769 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Peter Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder
Peter added a comment. Cool @Ladsgroup, do you have time so I can walk you through the data we collect? TASK DETAIL https://phabricator.wikimedia.org/T287769 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Peter Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder
Peter added a comment. Cool, I just added a comment to the your push @Ladsgroup ! TASK DETAIL https://phabricator.wikimedia.org/T287769 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Peter Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder
Peter added a comment. @Ladsgroup I'm thinking maybe a user journey is better to measure instead of a cold hit? Then we can measure every part of it? Let me explain, I think like this: 1. You add user timings that is meaningful to you (like either the full JS execution or parts of it if that could help you in the future). 2. We add user user journey to the synthetic tests: I can do that if you help me with a good journey. That could be like going to the start URL, adding a property(/value and run the query. That way we will automatically collect the user timings but also devtools timeline data for JS where the time is spent. If we do that for one URL/user journey that is good because then we have a history of data so if you do change later on, we have something that we can compare with. Does that sounds ok @Ladsgroup ? TASK DETAIL https://phabricator.wikimedia.org/T287769 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Peter Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder
Peter added a comment. I'll start with this later this week. One thing you can start with is this: > We don't have ongoing measurement of javascript performance so it might get worse without us noticing. You can use the User Timing API <https://developer.mozilla.org/en-US/docs/Web/API/User_Timing_API> for that, that would be super helpful if that is added before its used by real users. If you use the API those metrics are automatically picked up by our synthetic measurement tools if we point them to the query builder. If you feel like it you can create your own synthetic test, you can checkout searchWvuiObama.js in https://github.com/wikimedia/performance-synthetic-monitoring-tests/tree/master/tests/desktop how that can be done (I can also help you). You can also have a look how the team implemented user timings for the Wvui search. You can also beacon those metrics back to your server from real users, that is good so we can pickup if there are some users that struggle with the performance. Could those tag along with the other metrics you are measuring or are those backend only in your graphs? TASK DETAIL https://phabricator.wikimedia.org/T287769 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Peter Cc: dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Invadibot, maantietaja, Akuckartz, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] [Commented On] T189184: Update Wikidata WebPageTest dashboard to use the new Linux WebPageTest instance
Peter added a comment. The dashboard is updated: https://grafana.wikimedia.org/dashboard/db/wikidata-webpagetest Close this when you had time to check the it is ok.TASK DETAILhttps://phabricator.wikimedia.org/T189184EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PeterCc: Lydia_Pintscher, Aklapper, Peter, Noriega21, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189184: Update Wikidata WebPageTest dashboard to use the new Linux WebPageTest instance
Peter added a comment. FYI: I'm changing the dashboard today. The Windows agent went crazy the 31/3 and metrics are too high.TASK DETAILhttps://phabricator.wikimedia.org/T189184EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PeterCc: Lydia_Pintscher, Aklapper, Peter, Noriega21, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189184: Update Wikidata WebPageTest dashboard to use the new Linux WebPageTest instance
Peter added a comment. Just let me know if you need any help with this, I've changed the other dashboards so I can do it here too if you want. Most important is that you all is aware of the switch because the metrics will differ before/after since we run on different OS.TASK DETAILhttps://phabricator.wikimedia.org/T189184EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PeterCc: Lydia_Pintscher, Aklapper, Peter, Noriega21, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
