[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly
Sebastian_Berlin-WMSE added a comment. In T213704#5068924 <https://phabricator.wikimedia.org/T213704#5068924>, @Ladsgroup wrote: > In T213704#5068921 <https://phabricator.wikimedia.org/T213704#5068921>, @Sebastian_Berlin-WMSE wrote: > > > It's hard to work on this without being able to test the code myself. Is it possible to setup my common.js to run the tour code in a way that I can experiment there? I had a look at that, but couldn't figure out how to do it properly. Alternatively if I could have the rights to edit the actual tour script, that could work too. > > > You can just put it in "User:Sebastian_Berlin-WMSE/common.js" Will that override the original tours script? I thought it would just add it on top, which probably wouldn't turn out great. TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sebastian_Berlin-WMSE Cc: MartinPoulter, Ladsgroup, Addshore, Sebastian_Berlin-WMSE, Lydia_Pintscher, johl, Jopparn, Alicia_Fagerving_WMSE, Tarrow, NavinoEvans, Ragesoss, Pasleim, Aklapper, Mrjohncummings, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly
Sebastian_Berlin-WMSE added a comment. In T213704#5051741 <https://phabricator.wikimedia.org/T213704#5051741>, @Pasleim wrote: > Otherwise I think we can proceed with the hack by @Ladsgroup. The problem with this solution is that it's quite fragile: if the delay for the other operation is longer than the timeout, you will still get the unwanted behaviour. On the other hand, increasing the timeout to prevent this means that the user will experience a delay, even when not necessary. The best solution I can think of is to use a callback for the other operation, but judging from previous comments, it seems that that code was to "far away" to do that. TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sebastian_Berlin-WMSE Cc: MartinPoulter, Ladsgroup, Addshore, Sebastian_Berlin-WMSE, Lydia_Pintscher, johl, Jopparn, Alicia_Fagerving_WMSE, Tarrow, NavinoEvans, Ragesoss, Pasleim, Aklapper, Mrjohncummings, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly
Sebastian_Berlin-WMSE added a comment. It's hard to work on this without being able to test the code myself. Is it possible to setup my common.js to run the tour code in a way that I can experiment there? I had a look at that, but couldn't figure out how to do it properly. Alternatively if I could have the rights to edit the actual tour script, that could work too. TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sebastian_Berlin-WMSE Cc: MartinPoulter, Ladsgroup, Addshore, Sebastian_Berlin-WMSE, Lydia_Pintscher, johl, Jopparn, Alicia_Fagerving_WMSE, Tarrow, NavinoEvans, Ragesoss, Pasleim, Aklapper, Mrjohncummings, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly
Sebastian_Berlin-WMSE added a comment. My proposed code hasn't been added. Someone with the necessary user right needs to do this; I don't have those. TASK DETAIL https://phabricator.wikimedia.org/T213704 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sebastian_Berlin-WMSE Cc: Ladsgroup, Addshore, Sebastian_Berlin-WMSE, Lydia_Pintscher, johl, Jopparn, Alicia_Fagerving_WMSE, Tarrow, NavinoEvans, Ragesoss, Pasleim, Aklapper, Mrjohncummings, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly
Sebastian_Berlin-WMSE added a comment.
I did some experiments and I think this might work:
if($(step.attachTo).length === 0 {
var observer = new MutationObserver(function (mutationList, observer) {
for(var mutation of mutationList) {
for(var node of mutation.addedNodes) {
if(node === $(step.attachTo)) {
e.stopPropagation();
mw.libs.guiders.next();
}
}
}
});
var targetNode = $("body").get(0);
var observerOptions = {
childList: true,
subtree: true
}
observer.observe(targetNode, observerOptions);
} else {
e.stopPropagation();
mw.libs.guiders.next();
}
I don't have the rights to edit Guidedtour-lib.js; @Ladsgroup, can you try replacing the timeout with the above snippet and see if it works?TASK DETAILhttps://phabricator.wikimedia.org/T213704EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Sebastian_Berlin-WMSECc: Ladsgroup, Addshore, Sebastian_Berlin-WMSE, Lydia_Pintscher, johl, Jopparn, Alicia_Fagerving_WMSE, Tarrow, NavinoEvans, Ragesoss, Pasleim, Aklapper, Mrjohncummings, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Jonas, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly
Sebastian_Berlin-WMSE added a comment. Eww, race conditions. Would it be feasible to do something with MutationObserver to not have to use timers? That is if I understand it correctly, that the element we want to attach to hasn't been added yet when we want to attach it.TASK DETAILhttps://phabricator.wikimedia.org/T213704EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Sebastian_Berlin-WMSECc: Ladsgroup, Addshore, Sebastian_Berlin-WMSE, Lydia_Pintscher, johl, Jopparn, Alicia_Fagerving_WMSE, Tarrow, NavinoEvans, Ragesoss, Pasleim, Aklapper, Mrjohncummings, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Jonas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly
Sebastian_Berlin-WMSE added a comment. The fact that I put it in my "This Week" initially means that I will investigate this; I haven't worked with tours before, so I need to figure out what's going on. @Addshore, do you know how tours work and have time to work on this? If so, you're more qualified than me.TASK DETAILhttps://phabricator.wikimedia.org/T213704EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Sebastian_Berlin-WMSECc: Addshore, Sebastian_Berlin-WMSE, Lydia_Pintscher, johl, Jopparn, Alicia_Fagerving_WMSE, Tarrow, NavinoEvans, Ragesoss, Pasleim, Aklapper, Mrjohncummings, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Jonas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T213704: Wikidata Tours don't load correctly
Sebastian_Berlin-WMSE added a project: User-Sebastian_Berlin-WMSE. TASK DETAILhttps://phabricator.wikimedia.org/T213704EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Sebastian_Berlin-WMSECc: Jopparn, Alicia_Fagerving_WMSE, Tarrow, NavinoEvans, Ragesoss, Pasleim, Aklapper, Mrjohncummings, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T162561: Expose geoShapeStorageFrontendUrl through siteinfo
Sebastian_Berlin-WMSE added a project: WMSE-Bug-Reporting-and-Translation-2017. TASK DETAILhttps://phabricator.wikimedia.org/T162561EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_Profil, Sebastian_Berlin-WMSECc: Ladsgroup, Jonas, Aleksey_WMDE, thiemowmde, Lydia_Pintscher, gerritbot, Lokal_Profil, Aklapper, GoranSMilovanovic, QZanden, Izno, Ambrosiani, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T164413: Expose tabularDataStorageFrontendUrl through siteinfo
Sebastian_Berlin-WMSE added a project: WMSE-Bug-Reporting-and-Translation-2017. TASK DETAILhttps://phabricator.wikimedia.org/T164413EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_Profil, Sebastian_Berlin-WMSECc: gerritbot, Lokal_Profil, Aklapper, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Ambrosiani, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T160422: wdqs-app-footer-updated not transcluded
Sebastian_Berlin-WMSE added a project: WMSE-Bug-Reporting-and-Translation-2017. TASK DETAILhttps://phabricator.wikimedia.org/T160422EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Sebastian_Berlin-WMSECc: Smalyshev, Jonas, Alicia_Fagerving_WMSE, Lokal_Profil, Aklapper, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, FloNight, Xmlizer, MuhammadShuaib, Izno, LNDDYL, Ambrosiani, Psychoslave, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T160413: Duplicate claims are shown as one in query results
Sebastian_Berlin-WMSE added a project: WMSE-Bug-Reporting-and-Translation-2017. TASK DETAILhttps://phabricator.wikimedia.org/T160413EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Sebastian_Berlin-WMSECc: Smalyshev, Aklapper, Alicia_Fagerving_WMSE, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, Jonas, FloNight, Xmlizer, Izno, Ambrosiani, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
