[Wikidata-bugs] [Maniphest] [Closed] T137319: Graph Display icons should have explanatory tooltips
divadsn closed this task as "Resolved".divadsn added a comment. Jenkins has successfully merged my second change, so I will close this as finally resolved! :)TASK DETAILhttps://phabricator.wikimedia.org/T137319EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: divadsnCc: gerritbot, divadsn, Jonas, Designbygio, Addshore, Aklapper, Yair_rand, Zppix, Th3d3v1ls, SacredWKnight, Ramalepe, Liugev6, EBjune, mschwarzer, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, D3r1ck01, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, jayvdb, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T137319: Graph Display icons should have explanatory tooltips
divadsn added a comment. @Jonas could you please explain what these buttons are acutally supposed to do, so I can make proper i18n messages? :)TASK DETAILhttps://phabricator.wikimedia.org/T137319EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: divadsnCc: gerritbot, divadsn, Jonas, Designbygio, Addshore, Aklapper, Yair_rand, Zppix, Th3d3v1ls, SacredWKnight, Ramalepe, Liugev6, EBjune, mschwarzer, Avner, Lewizho99, Maathavan, debt, Gehel, D3r1ck01, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, jayvdb, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T137319: Graph Display icons should have explanatory tooltips
divadsn added a comment. I am ready, but I am missing i18n messages. Could someone please explain what these buttons actually are supposed to do? F5243240: firefox_2017-01-06_19-46-02.pngTASK DETAILhttps://phabricator.wikimedia.org/T137319EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: divadsnCc: gerritbot, divadsn, Jonas, Designbygio, Addshore, Aklapper, Yair_rand, Zppix, Th3d3v1ls, SacredWKnight, Ramalepe, Liugev6, EBjune, mschwarzer, Avner, Lewizho99, Maathavan, debt, Gehel, D3r1ck01, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, jayvdb, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T137319: Graph Display icons should have explanatory tooltips
divadsn added a comment. Will look into that tonight and provide a next patch.TASK DETAILhttps://phabricator.wikimedia.org/T137319EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: divadsnCc: gerritbot, divadsn, Jonas, Designbygio, Addshore, Aklapper, Yair_rand, Zppix, Th3d3v1ls, SacredWKnight, Ramalepe, Liugev6, EBjune, mschwarzer, Avner, Lewizho99, Maathavan, debt, Gehel, D3r1ck01, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, jayvdb, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T137319: Graph Display icons should have explanatory tooltips
divadsn added a comment. I am sorry, but in the screenshot given in the bug report actually wasn't any buttons in the middle.TASK DETAILhttps://phabricator.wikimedia.org/T137319EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: divadsnCc: gerritbot, divadsn, Jonas, Designbygio, Addshore, Aklapper, Yair_rand, Zppix, Th3d3v1ls, SacredWKnight, Ramalepe, Liugev6, EBjune, mschwarzer, Avner, Lewizho99, Maathavan, debt, Gehel, D3r1ck01, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, jayvdb, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T137319: Graph Display icons should have explanatory tooltips
divadsn closed this task as "Resolved".divadsn added a comment. Change has been merged, hence marking this as resolved.TASK DETAILhttps://phabricator.wikimedia.org/T137319EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: divadsnCc: gerritbot, divadsn, Jonas, Designbygio, Addshore, Aklapper, Yair_rand, Zppix, Th3d3v1ls, SacredWKnight, Ramalepe, Liugev6, EBjune, mschwarzer, Avner, Lewizho99, Maathavan, debt, Gehel, D3r1ck01, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, jayvdb, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T137319: Graph Display icons should have explanatory tooltips
divadsn claimed this task.divadsn added a comment. Where I am supposed to start? Should this fix also support l18n messages?TASK DETAILhttps://phabricator.wikimedia.org/T137319EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: divadsnCc: divadsn, Jonas, Designbygio, Addshore, Aklapper, Yair_rand, Zppix, SacredWKnight, EBjune, mschwarzer, Avner, debt, Gehel, D3r1ck01, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, jayvdb, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images
divadsn added a comment. @Jdlrobson what do you mean with this comment here? How should I avoid sending the image to the template when we don't know about the image aspect ratio at that point? https://gerrit.wikimedia.org/r/#/c/324775/4/includes/WikidataPageBanner.hooks.php@128TASK DETAILhttps://phabricator.wikimedia.org/T131424EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: divadsnCc: gerritbot, divadsn, Jdlrobson, Dbrant, JKatzWMF, Florian, Jhernandez, Sumit, KHammerstein, Nirzar, Aklapper, Ramalepe, Liugev6, Winter, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T131424: WikidataPageBanner when using page images generated API renders badly cropped images
divadsn claimed this task.divadsn added a comment. @Jdlrobson Thanks, everything is ready to go! I will reply back when I'm done or when I will have a problem with Vagrant or the code.TASK DETAILhttps://phabricator.wikimedia.org/T131424EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: divadsnCc: divadsn, Jdlrobson, Dbrant, JKatzWMF, Florian, Jhernandez, Sumit, KHammerstein, Nirzar, Aklapper, Winter, D3r1ck01, Izno, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images
divadsn added a comment. @Jdlrobson Thank you for the clarification, now I will setup my dev environment. One question, will vagrant run fine? on a old laptop with 4 GB RAM and Ubuntu 16.10 64-bit installation?TASK DETAILhttps://phabricator.wikimedia.org/T131424EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: divadsnCc: divadsn, Jdlrobson, Dbrant, JKatzWMF, Florian, Jhernandez, Sumit, KHammerstein, Nirzar, Aklapper, Winter, D3r1ck01, Izno, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images
divadsn added a comment. I will work to fix it in the next 2 days as a Google Code-in student. As far as I understood the task is to find the corresponding code section and add a check if the image is not landscape, right?TASK DETAILhttps://phabricator.wikimedia.org/T131424EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: divadsnCc: divadsn, Jdlrobson, Dbrant, JKatzWMF, Florian, Jhernandez, Sumit, KHammerstein, Nirzar, Aklapper, Winter, D3r1ck01, Izno, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
