[Wikidata-bugs] [Maniphest] [Changed Subscribers] T230326: Reuse EventEmittingButton from termbox

[Charlie_WMDE]

Charlie_WMDE added a subscriber: Volker_E.
Charlie_WMDE added a comment.


  thanks for bringing this up @Michael
  
  > 1. OOUI buttons look different when they are clicked with the mouse or 
activated by the enter or space key. We are not entirely sure whether this is 
actually intended by the people of OOUI, but we are currently implementing that 
nonetheless.
  
  @Matthias_Geisler_WMDE already talked to me about this quickly. As I 
understood it, you are currently not sure whether this is a bug or intended, 
right? Maybe @Volker_E 
  can shed some light on this. Since we don't expect this behavior to appear in 
our feature anyway because there can be no previous state of clicking the 
primaryProgressive button and then tabbing back to it, I suggested to neglect 
that state for now until we can verify that it is indeed an intended behavior. 
(I hope i understood correctly what this is about)
  
  > 1. Not relevant right now, but it might be worth to keep the tab order in 
mind. That is the order in which the elements are selected by pressing the tab 
key on the keyboard. The default order is determined by how the elements 
appear, but that order doesn't necessarily need to be the order deem best.
  
  That is a good point and on my list of things to figure out. thank you

TASK DETAIL
  https://phabricator.wikimedia.org/T230326

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE, Charlie_WMDE
Cc: Volker_E, Matthias_Geisler_WMDE, alaa_wmde, Hanna_Petruschat_WMDE, 
Lucas_Werkmeister_WMDE, Lydia_Pintscher, Charlie_WMDE, Jakob_WMDE, Michael, 
Aklapper, Pablo-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T230326: Reuse EventEmittingButton from termbox

[Pablo-WMDE]

Pablo-WMDE added a subscriber: Hanna_Petruschat_WMDE.
Pablo-WMDE added a comment.


  Had a brief chat with @Lydia_Pintscher @Charlie_WMDE - the following may (or 
may not) be considered obvious but I'm making the expressed mutual 
understanding explicit to eliminate other interpretations. Given the task of 
this ticket and to reduce complexity, focus is limited to the 
"primaryprogressive" 

 button as an example.
  
  - the save button used in bridge is supposed to be //visually// identical to 
the one seen in OOUI
  - the actual OOUI elements can not reasonably be used inside of bridge for 
//technical reasons//
  - as far as the devs understand it, the "primaryprogressive" button 
implemented for termbox back when was supposed to be //visually// identical to 
the one seen in OOUI
  - devs want to avoid redundantly implementing components, are tempted to 
reuse ("share") the component from termbox inside bridge
  
  The consequence of this would be: discrepancies between the shared 
"primaryprogressive" button and OOUI specification be detected **(now and in 
the future)** and fixed, these changes would then apply to **both** termbox 
**and** bridge alike. From the dev point of view this is perceived as something 
desirable, from the product and UX side it still seems open for debate 
apparently.
  !! @Charlie_WMDE wants to clarify that with @Hanna_Petruschat_WMDE. The 
concrete question: were any of the discrepancies btw. the termbox 
"primaryprogressive" 

 button and its OOUI equivalent 

 intentional or are they unintentional and merely a result of an imperfect copy 
job by dev?!!
  The outcome of this determines if this component can really be reused and 
shared or not.
  
  Specimen F30229847: Bildschirmfoto von 2019-09-05 16-15-36.png 


TASK DETAIL
  https://phabricator.wikimedia.org/T230326

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Matthias_Geisler_WMDE, Pablo-WMDE
Cc: Hanna_Petruschat_WMDE, Lucas_Werkmeister_WMDE, Lydia_Pintscher, 
Charlie_WMDE, Jakob_WMDE, Michael, Aklapper, Pablo-WMDE, Hook696, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, DannyS712, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T230326: Reuse EventEmittingButton from termbox

[Charlie_WMDE]

Charlie_WMDE added a subscriber: Lydia_Pintscher.
Charlie_WMDE added a comment.


  hello everyone, after getting some help from @Matthias_Geisler_WMDE in 
understanding this i must say, i think this is mainly a tech decision as well 
as product @Lydia_Pintscher would you take a look at this?
  
  I think the implication for UX/product would be that the permutation-option 
allows for quicker button creation in the future (which is good since we'll 
definitely need more buttons and different kinds of buttons) and from my 
perspective that also means, i can look at the finished product quicker. The 
other thing that comes to mind is that we don't have to maintain the "same" 
buttons in two places which makes things easier as well, and I don't need to 
specify which of the "same" type of button i mean.
  
  I don't claim to understand all of the implications of doing it one way or 
the other, so there is no judgement on that from my side. This is simply my 
preference, judging from what this would mean for my work.
  
  But overall, as long as the look, feel and functionality in the end is as 
specified by me, I don't mind too much where the buttons come from and what 
went into developing them. I want things we do to be reusable and sustainable, 
but ultimately the details on the implementation are of a technical nature and 
as long as the result is the same this should be a engineering/product decision 
imo.
  
  Hope this helps somewhat.

TASK DETAIL
  https://phabricator.wikimedia.org/T230326

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Matthias_Geisler_WMDE, Charlie_WMDE
Cc: Lydia_Pintscher, Charlie_WMDE, Jakob_WMDE, Michael, Aklapper, Pablo-WMDE, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T230326: Reuse EventEmittingButton from termbox

[Matthias_Geisler_WMDE]

Matthias_Geisler_WMDE added a subscriber: Charlie_WMDE.
Matthias_Geisler_WMDE added a comment.


  ccing @Charlie_WMDE

TASK DETAIL
  https://phabricator.wikimedia.org/T230326

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Matthias_Geisler_WMDE
Cc: Charlie_WMDE, Jakob_WMDE, Michael, Aklapper, Pablo-WMDE, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, 
DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T230326: Reuse EventEmittingButton from termbox

[Michael]

Michael added a subscriber: Jakob_WMDE.
Michael added a comment.


  After consulting with @Jakob_WMDE  the motivation to use an `` tag in 
termbox was that there is apparently one situation where there SSR needs to 
render an actual link, which should then act as a js-button in the frontend.
  We don't have these circumstances here, so we can use a button straight away.

TASK DETAIL
  https://phabricator.wikimedia.org/T230326

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Jakob_WMDE, Michael, Aklapper, Pablo-WMDE, darthmon_wmde, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs