[Wikidata-bugs] [Maniphest] [Changed Subscribers] T99775: Qunit test always fail in Wikidata Jenkins jobs.

2015-05-20 Thread daniel
daniel added subscribers: JanZerebecki, Addshore, hashar.

TASK DETAIL
  https://phabricator.wikimedia.org/T99775

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle, daniel
Cc: hashar, Addshore, JanZerebecki, Aklapper, daniel, Wikidata-bugs, aude



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T99775: Qunit test always fail in Wikidata Jenkins jobs.

2015-05-20 Thread hashar
hashar added subscribers: aaron, ori.
hashar added a comment.

The mwext-Wikibase-qunit 
https://integration.wikimedia.org/ci/job/mwext-Wikibase-qunit/ job started 
failing between May 18th 12:39:11 UTC 
https://integration.wikimedia.org/ci/job/mwext-Wikibase-qunit/9770/ and May 
18th 13:36:51 UTC 
https://integration.wikimedia.org/ci/job/mwext-Wikibase-qunit/9771/.

Looking at the first failing build, there is an `mw-error.log` file attached to 
it which is `$wgDebugLogGroups['error']` with:

  2015-05-19 13:38:25 integration-slave-trusty-1014 jenkins_u1_mw: [a97629d3] 
[no req]   ErrorException from line 419 of includes/jobqueue/JobQueueGroup.php: 
PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted.
  #0 [internal function]: MWExceptionHandler::handleError(1024, 
'JobQueueGroup::...', '/mnt/jenkins-wo...', 419, Array)
  #1 includes/jobqueue/JobQueueGroup.php(419): 
trigger_error('JobQueueGroup::...')
  #2 [internal function]: JobQueueGroup-__destruct()
  #3 {main}
  2015-05-19 13:38:25 integration-slave-trusty-1014 jenkins_u1_mw: [30a22e70] 
[no req]   ErrorException from line 419 of includes/jobqueue/JobQueueGroup.php: 
PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted.
  #0 [internal function]: MWExceptionHandler::handleError(1024, 
'JobQueueGroup::...', '/mnt/jenkins-wo...', 419, Array)
  #1 includes/jobqueue/JobQueueGroup.php(419): 
trigger_error('JobQueueGroup::...')
  #2 [internal function]: JobQueueGroup-__destruct()
  #3 {main}
  2015-05-19 13:38:26 integration-slave-trusty-1014 jenkins_u1_mw: [2cd5481b] 
[no req]   ErrorException from line 419 of includes/jobqueue/JobQueueGroup.php: 
PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted.
  #0 [internal function]: MWExceptionHandler::handleError(1024, 
'JobQueueGroup::...', '/mnt/jenkins-wo...', 419, Array)
  #1 includes/jobqueue/JobQueueGroup.php(419): 
trigger_error('JobQueueGroup::...')
  #2 [internal function]: JobQueueGroup-__destruct()
  #3 {main}
  2015-05-19 13:38:28 integration-slave-trusty-1014 jenkins_u1_mw: [b61c63d2] 
[no req]   ErrorException from line 419 of includes/jobqueue/JobQueueGroup.php: 
PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted.
  #0 [internal function]: MWExceptionHandler::handleError(1024, 
'JobQueueGroup::...', '/mnt/jenkins-wo...', 419, Array)
  #1 includes/jobqueue/JobQueueGroup.php(419): 
trigger_error('JobQueueGroup::...')
  #2 [internal function]: JobQueueGroup-__destruct()
  #3 {main}

So it seems some HTTP queries fails, and the curl error would potentially be 
caused by it.

A few JobQueue related changes landed in MediaWiki core that day which might be 
related:

- https://gerrit.wikimedia.org/r/#/c/211320/ //Added JobQueueGroup::lazyPush 
method// which also does clean ups
- https://gerrit.wikimedia.org/r/#/c/211748/ //Use lazyPush() instead of push() 
in a few places for jobs//

The first actually adds the `__destruct` method to JobQueueGroup so that would 
explain it.

So it might just be a breaking change or a flaw in 
https://gerrit.wikimedia.org/r/#/c/211320/ which we might well want to revert 
to unreal the Wikidata job.


TASK DETAIL
  https://phabricator.wikimedia.org/T99775

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle, hashar
Cc: ori, aaron, thcipriani, Manybubbles, zeljkofilipin, hashar, Addshore, 
JanZerebecki, Aklapper, daniel, Wikidata-bugs, aude



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs