Michael claimed this task.
Michael added a subscriber: Pablo-WMDE.
Michael moved this task from Doing to Peer Review on the
Wikidata-Bridge-Sprint-4 board.
Michael added a comment.
Restricted Application added a project: User-Michael.
I adjusted the variables in _variables.scss in two ways:
1. I renamed `$base-font-size-desired` to `$container-relative-font-size` as
that is what it is and that makes its purpose in the calculations clear: to
undo the change in font-size coming from container by dividing by
`$container-relative-font-size`
2. I kept the explizit `px` units for the calculation as I find them to
helpful in understanding the calculations. I assume they are not in the
common.less because Less handles units in calculations strangely. (This is an
update from my previous position that it is better to remove thos `px` units.)
Let me know what you think!
TASK DETAIL
https://phabricator.wikimedia.org/T230895
WORKBOARD
https://phabricator.wikimedia.org/project/board/4246/
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Michael
Cc: Pablo-WMDE, Aklapper, Michael, Hook696, Daryl-TTMG, RomaAmorRoma,
0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, DannyS712, CucyNoiD,
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci,
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis,
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden,
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs,
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
