[Wikidata-bugs] [Maniphest] [Commented On] T100983: Banner not displayed correctly in preview

2015-06-22 Thread Sumit 
Sumit added a comment.

Updated the test wiki to show previews.


TASK DETAIL
  https://phabricator.wikimedia.org/T100983

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sumit
Cc: Jdlrobson, gerritbot, Nicolas_Raoul, Aklapper, Wikidata-bugs, aude, 
Lydia_Pintscher



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T100983: Banner not displayed correctly in preview

2015-06-17 Thread gerritbot 
gerritbot added a comment.

Change 218691 merged by jenkins-bot:
WikidataPageBanner custom banner on page-preview

https://gerrit.wikimedia.org/r/218691


TASK DETAIL
  https://phabricator.wikimedia.org/T100983

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sumit, gerritbot
Cc: gerritbot, Nicolas_Raoul, Aklapper, Wikidata-bugs, aude, Lydia_Pintscher



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T100983: Banner not displayed correctly in preview

2015-06-16 Thread gerritbot 
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.

Change 218691 had a related patch set uploaded (by Sumit):
WikidataPageBanner custom banner on page-preview

https://gerrit.wikimedia.org/r/218691


TASK DETAIL
  https://phabricator.wikimedia.org/T100983

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sumit, gerritbot
Cc: gerritbot, Nicolas_Raoul, Aklapper, Wikidata-bugs, aude, Lydia_Pintscher



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T100983: Banner not displayed correctly in preview

2015-06-01 Thread Sumit 
Sumit added a comment.

The problem is the stylesheet ins't being added on viewing the preview. This is 
probably due to the fact that BeforePageDisplay hook is adding the stylesheet, 
which runs just before the page is displayed. On saving the page, stylesheet 
adds. I'll look into if the styles can be added even on preview.


TASK DETAIL
  https://phabricator.wikimedia.org/T100983

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sumit
Cc: Nicolas_Raoul, Aklapper, Wikidata-bugs, aude, Lydia_Pintscher



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs